inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Apr 8, 2015 13:09:20 GMT -8
NM - I derped. I had <div class='awards'></div> twice.
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,285
January 2004
todge
|
Post by Todge on Apr 8, 2015 14:13:43 GMT -8
No worries.. Saves me pulling my hair out.
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,285
January 2004
todge
|
Post by Todge on Apr 8, 2015 14:32:16 GMT -8
]You still cannot say one cannot effect the other as you have just stated that the Notification Plugin does grab data from the Awards plugin. So any changes made to either could cause issues due to the data grab requirement. It's silly to say it won't or can't. Especially as issues occurred after updating either both or one of them. Before updates of either there were no issues. I can and still do. The Notification Plugin reads the KEY DATA from the Awards plugin, it does not grab data from the plugin itself at all, and as I already said that I hadn't touched the way the data was stored, then there is no way any updates to the Awards plugin can effect the Notification plugin. If the awards were displayed, then the reason the pop-up repeated was because the key was not being updated.. Nothing to do with the Awards Plugin as they use different keys. Strange how moving it to the bottom of the list rectified it, as plugin position will not effect whether or not the key can be written to.
|
|
inherit
201984
0
Sept 11, 2023 1:23:07 GMT -8
P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓
Using My Talents Elsewhere
3,314
November 2013
pastuleo23
|
Post by P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓ on Apr 8, 2015 15:38:49 GMT -8
I can and still do. The Notification Plugin reads the KEY DATA from the Awards plugin, it does not grab data from the plugin itself at all, and as I already said that I hadn't touched the way the data was stored, then there is no way any updates to the Awards plugin can effect the Notification plugin. If the awards were displayed, then the reason the pop-up repeated was because the key was not being updated.. Nothing to do with the Awards Plugin as they use different keys. Strange how moving it to the bottom of the list rectified it, as plugin position will not effect whether or not the key can be written to. The Key Data that needs to be read would not exist were it not for the Awards Plugin. Furthermore that data could be corrupted if something was amiss in the Awards Plugin. Ergo, there will always be a possibility that The Awards Plugin will effect the Notification Plugin in a negative way. I hate to state the obvious, but without the Awards Plugin the Notification Plugin would produce no results. You can't have one working without the other. The only thing that is certain is The Awards Plugin cannot be effected by the Notification one (unless you purposely put something in it to do so). Lastly, it has been proven by updating the Awards plugin (by many forum admin) that the Awards Notification Plugin has produced a problem. The proof is right there that there is a cause and effect happening. Why deny the evidence? hold on here. I think what todge is saying is not that the awards plugin doesn't affect the notification plugin, he's saying that UPDATING the awards plugin cannot affect the notification plugin. This is because the data STRUCTURE in the KEY has NEVER changed. This is what I agree on. Todge is saying if you delete the awards plugin (and leave the key) the notification plugin would work as intended. Because the key is still there and the key structure has never changed. And if you update the awards plugin, the key is still the same, and the notification plugin is still the same. IF updating the awards plugin changed the way data was saved, or a bug introduced broke the key structure, then neither the awards plugin, nor the notification plugin would work properly. But the notification plugin would never break unless the awards plugin was also broken. If you look at the reasoning behind the whole who's on top it's not too complex of something to do. In theory it shouldn't matter. But that depends on how the plugin is functioning. By your evidence showing that a double popup occurs, either proboards data calling or the awards plugin is directly affecting the order of operations in the notification system proving you, @demonbarber correct. It is somehow inadvertently affected by the awards plugin. (but none of his updates has caused that bug, it will be in every version and updating either of them will never make that problem occur or go away UNLESS it changes the position that plugins are placed) In the case of most plugin updating, the last plugin to be updated is usually positioned at the bottom of the plugin list. Inadvertently placing awards after the notification whereas previous it was before. This is something that cannot be fixed and will happen most likely 100% of the time. This is not the Awards Plugins fault. It would be Proboards fault. Further proving that the awards doesn't affect the notification plugin. If the notification plugin was changed to run completely after document.ready() (global variables etc), the awards plugin could be in either position without causing an issue. This is due to the notification system looking for a key that hasn't been loaded yet. (most likely) Which means his line(var ak = proboards.plugin.key('todge_awards_key').get(me); ) is probably the culprit of this bug. This is in the notifications plugin. P.S. It is rude to argue about trivial things among a plugin creator and his masterpiece. You should be ashamed and agree to disagree.
|
|
inherit
201984
0
Sept 11, 2023 1:23:07 GMT -8
P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓
Using My Talents Elsewhere
3,314
November 2013
pastuleo23
|
Post by P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓ on Apr 8, 2015 16:05:18 GMT -8
Todge regarding the previous comment above, var ak breaks my animal keeper plugin. This is because I have ak set up as a namespace for my movement functions. So our codes aren't compatible based on that small thing. (which may also explain the double posts if the forums that have that problem are the ones that use the animal keeper) Which would mean I started this argument inadvertently. Long story short, can you choose a different variable name so that I don't have to change 200 lines of code? The reason I chose ak is because that is what virgil sovereign wrote out of a snippet for me when I didn't understand namespacing and he taught me. So I didn't want to change it for everything was working smoothly. Not thinking that the acronym would be popular for such things as an awards key notification system. It doesn't have trouble with the todge_awards_key. It's just that you used the same global variable as I did.
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Apr 8, 2015 21:11:15 GMT -8
Todge - now we have it solved can I ask if you'd be able to insert a way to notify when I want to place in a 'new line' ((even if its something like add a sign at the end of a line, though I'd like to be able to keep certain awards protected from being given as well))
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,285
January 2004
todge
|
Post by Todge on Apr 9, 2015 9:29:42 GMT -8
Todge regarding the previous comment above, var ak breaks my animal keeper plugin. This is because I have ak set up as a namespace for my movement functions. So our codes aren't compatible based on that small thing. (which may also explain the double posts if the forums that have that problem are the ones that use the animal keeper) Which would mean I started this argument inadvertently. Long story short, can you choose a different variable name so that I don't have to change 200 lines of code? The reason I chose ak is because that is what virgil sovereign wrote out of a snippet for me when I didn't understand namespacing and he taught me. So I didn't want to change it for everything was working smoothly. Not thinking that the acronym would be popular for such things as an awards key notification system. It doesn't have trouble with the todge_awards_key. It's just that you used the same global variable as I did. 'Tis done.. The code is now held within a function, so it wouldn't have mattered anyway, but have changed it anyhow.
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,285
January 2004
todge
|
Post by Todge on Apr 9, 2015 9:35:16 GMT -8
Todge - now we have it solved can I ask if you'd be able to insert a way to notify when I want to place in a 'new line' ((even if its something like add a sign at the end of a line, though I'd like to be able to keep certain awards protected from being given as well)) That is not as easy as it sounds.. I'll see if I can add a new line using a Footer Code, as this is something I'd rather not mess around with within the plugin itself. Do you want the new lines added in the mini-profiles, Profile pages or both?
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Apr 9, 2015 9:39:56 GMT -8
Both - but I need a way I can easily update it So for example I want to put a new line after the "Active Duty" Image Then one at the end of the awards in that category etc
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,285
January 2004
todge
|
Post by Todge on Apr 9, 2015 9:46:28 GMT -8
All I can do is add a new after an award number is reached, so, for instance, you add 10 to the code, a new line will be created before award number 11 is added, so a new line will be added whether or not award number 10 is displayed.. In fact a new line would be added even if all awards 1-10 are not displayed.
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Apr 9, 2015 9:50:50 GMT -8
@_@ Is there any way it could be done by the id of the awards?
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,285
January 2004
todge
|
Post by Todge on Apr 9, 2015 11:31:53 GMT -8
It would be done by the ID of the awards.. They are numbered, and is the only way I can identify them to put a line break.
The only other way would be to count 10 awards, add a break, and so on, but then the break would be placed after the 10th DISPLAYED award, no matter which one it was.
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Apr 9, 2015 11:45:19 GMT -8
I would rather it be done by an ID because not everything is after every 10 if that makes any sense?
|
|
inherit
201984
0
Sept 11, 2023 1:23:07 GMT -8
P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓
Using My Talents Elsewhere
3,314
November 2013
pastuleo23
|
Post by P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓ on Apr 9, 2015 21:34:18 GMT -8
Not making sense to me lol. Not that I'm contributing.
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Apr 9, 2015 21:39:38 GMT -8
|
|