Word Count Trophies [library support]

[Wormopolis]

For the Word Count Trophy plugin

www.proboards.com/library/plugins/item/158

[tpc]

hey Wormopolis is there a way to not add quotes within the trophy count? Sometimes just doing one count bumps up the word count by 100 words and gives them a bronze trophy before even typing? lol

[Wormopolis]

Well the first version did... but something might have changed in how quotes are since it was converted. I will look tonight.

[tpc]

Alright I look forward to your reply Wormopolis

[Wormopolis]

v1.1.2 was submitted

[tpc]

How long does that normally take to update? Do you have a link I can download the file?

[Wormopolis]

They typically look once a day, but if they get busy it takes longer.

I dont have a dropbox link for that update. Tim Camara will update the library when he gets some free time.

[Tim Camara]

*grumbles* It's done *grumbles*

[Wormopolis]

see now he is grumbly.. which usually means he demands a sacrifice of a fruit basket.

[Tiffy-Bean]

Getting an error associated to this plugin.

Kami: "Whatever plugin or JS you have for trophies is throwing an error into the mix. Looks like there's an undefined ID in the plugin, either in the build forum or you neglected to add an ID in your plugin options."

as there is no id in plugin options...I'm guessing it has to be in the build screen. Can you take a look wormo?

[Chris]

Wormo is currently out of the office, his trip to "explore strange new worlds, to seek out new life and new civilizations" has taken a bit longer than expected (I could have sworn he said 5 minutes..), in the mean time perhaps I could help if I could get a little bit more to go on such as a forum url where this error can be observed in its natural habitat and all factors can be taken into consideration.

[Tiffy-Bean]

forum url: thecityofsin.freeforums.net/

[Chris]

if (WCtrophyBoards.length==0 || jQuery.inArray(proboards.data('page').board.id.toString(), WCtrophyBoards)>-1) {

The error is coming from a line that is checking which board is currently being displayed then checking against a list of boards to see how to proceed. It is indeed an error but not a fatal error because it occurs when not in a board such as when viewing the homepage. The code neglects to check if in a board first before checking to see which board it is in.

[Tiffy-Bean]

Jan 5, 2017 15:18:44 GMT -8 Chris said:

if (WCtrophyBoards.length==0 || jQuery.inArray(proboards.data('page').board.id.toString(), WCtrophyBoards)>-1) {

The error is coming from a line that is checking which board is currently being displayed then checking against a list of boards to see how to proceed. It is indeed an error but not a fatal error because it occurs when not in a board such as when viewing the homepage. The code neglects to check if in a board first before checking to see which board it is in.

So, I should just ignore it?

[Chris]

It's not an error that will prevent the plugin from working ( "not fatal" ) unless it needs to do something on pages that are not within a board. I'm not the author of course but from glancing at the code I'd say the plugin deals exclusively with posts (and their mini-profiles) so has no need to run on any other pages such as home. The only other case I can see it needing to run outside of a board would be on a page where there are search results containing posts (or predefined search results such as "recent posts") and I am guessing it never worked in those cases anyway if it is checking against a board list and accessing page data rather than the "proboards.post" data.

Whether the error can be ignored is up to you, if the plugin is editable (don't think Wormo left any of his in that mode) then you could avoid the error by first checking if the returned object has a "board" property before proceeding to check the board's id

code:

if (WCtrophyBoards.length==0 || ( proboards.data('page').board && jQuery.inArray(proboards.data('page').board.id.toString(), WCtrophyBoards)>-1) ) {

ETA: I should also note that at one time "Oops" pages never used to return a page object which means you also had to check if pb.data("page") was an actual object before further testing for properties but that little bug was fixed.