pb_action curiosity

[MadMax™]

Jul 26, 2010 5:21:49 GMT -8 Chris said:

the scenarios where you need a RegEx over pb_action are few and far between.

Yes, but there are indeed situations where the pb_action isn't the way to go. I gave a quick example of that off the top of my head. There are definitely more. My whole point is that we need to pay attention to all the small details, in order to make our codes work in all situations. Even MM, or password protected boards...whatever the situation may be. I'm sure I don't have to tell you this, Chris, since we started out around the same time. My initial comment wasn't for your benefit, since I'm sure you already know this.

I hadn't even considered those were server names. Makes sense though.


Max

[SubDevo]

Jul 26, 2010 12:12:17 GMT -8 MadMax™ said:

Yes, but there are indeed situations where the pb_action isn't the way to go. I gave a quick example of that off the top of my head. There are definitely more. My whole point is that we need to pay attention to all the small details, in order to make our codes work in all situations. Even MM, or password protected boards...whatever the situation may be. I'm sure I don't have to tell you this, Chris, since we started out around the same time. My initial comment wasn't for your benefit, since I'm sure you already know this.

If the reason you started on this was for MY benefit, then obviously you did not read the paragraph that was in the same post from which you quoted in your first reply.

Either way my point was that you don't need to use location.href for everything. It still has it's pros and cons just like ONLY using pb_action. You need to decide which to use based upon the pages your code will be affecting. For some pages, I still prefer to check for the existance of a form name.

Like you said, this is coding 101...

Regards,
SubDevo

[Trill]

Jul 25, 2010 23:27:50 GMT -8 MadMax™ said:

That's a trip. What about the "pb_this" variable? "GLaDOS" & "betty" Wierd.

Beatrice, Jinto, and Mabel feel left out.

[/importantcontribution]

Edit: and Gertrude

[MadMax™]

Jul 26, 2010 15:01:32 GMT -8 SubDevo said:

If the reason you started on this was for MY benefit, then obviously you did not read the paragraph that was in the same post from which you quoted in your first reply.

As a matter of fact, yes, it was for your benefit. Because you made the erroneous statement...

Jun 1, 2010 18:30:19 GMT -8 SubDevo said:

We have all seen this or similar for checking for the main page:
if(location.href.match(/\.com(\/|.+cgi(\?|#.+|\?\w+=home)?)?$/i)){
Now you can just use if(pb_action=="home"){

To which I pointed out a scenario off the top of my head where that wouldn't work. You can take it for what it's worth, or blow it off. It really doesn't matter to me either way. I wasn't "calling you out" or anything like that. And your the one who brought this thread to my attention via PM to begin with. I could only assume you wanted some of my input on the discussion at hand? Had someone else made the exact same statement, I would have pointed it out to them as well. It wasn't a personal attack, in case that's what your thinking.


Max

[SubDevo]

I brought this thread to your attention, because I thought that you did not know about the variable since none of your codes utilize it in any fashion. Heck, since Chris didn't know about it (until recently), and you have been gone for so long, that you may have not known about it either.
Technically, my literal statement was erroneous because it doesn't cover EVERY case. But, from my experience and as Chris stated, it would be sufficient for 99% of the time. This is a programming discussion board, so I assume most of the people posting in here have coding knowledge and most would realize right away that it doesn't cover ALL circumstances but they can see the usefulness of it. I do not underestimate the intellect of people posting here. Ultimately, it is up to the coder to decide what location check is best for their code. Be it pb_action, href, form, title check etc. pb_action is a great tool for specific cases. Such as thread display (boardindex). All posts including recent, user recent and searches could be covered by (display|search2).
Checking pb_action is also immune to any URL mangling. For example a "Guests cannot view profiles" code that checks the href for a match of "viewprofile" can be easily bypassed by changing a letter in the URL to hex. support.proboards.com/index.cgi?action=view%70rofile
Any case where I can utilize pb_action safely, I will. Since, checking for an equality is faster than a match.

Regards,
SubDevo

[MadMax™]

Jul 26, 2010 20:46:35 GMT -8 SubDevo said:

I brought this thread to your attention, because I thought that you did not know about the variable since none of your codes utilize it in any fashion.

#1) My entire body of work resides at PBC&G, which has been in Maintenance Mode since WAY before the pb_action was ever implemented. You haven't had access to all my codes anyway, unless of course you have them saved on your hard drive. Even so, they were all written before the pb_action came about. But thank you so much for criticizing my work [on impossible criteria no less].
#2) I've recently undertaken the task of rewriting all my codes at PBC&G. Most of them are well over three years old [but still worked]. ProBoards has had many changes since then, and my scripting skills have improved since then as well. The pb_action is used in my newly updated codes quite extensively. I can only hope they get the "SubDevo stamp of approval."

Jul 26, 2010 20:46:35 GMT -8 SubDevo said:

Heck, since Chris didn't know about it (until recently), and you have been gone for so long, that you may have not known about it either.

Yes, I know about it. But thank you for your concern regarding the quality of my scripts.


Max

[James [a_leon]]

Jul 27, 2010 13:36:56 GMT -8 MadMax™ said:

[

Jul 26, 2010 20:46:35 GMT -8 SubDevo said:

Heck, since Chris didn't know about it (until recently), and you have been gone for so long, that you may have not known about it either.

Yes, I know about it. But thank you for your concern regarding the quality of my scripts.


Max

How does wanting to make sure you know about that variable have any reflection on the quality of your scripts? I'm not really sure what's warranting the tone.

[MadMax™]

Jul 27, 2010 20:07:29 GMT -8 James [a_leon] said:

I'm not really sure what's warranting the tone.

He most definitely does. My tone/attitude with him is more than justified too. Trust me.

I'm finished conversing with him anyway. Not sure why I even started to.

By the way, are you the same a_leon who used to submit codes at SSD, back in PB version 3?


Max

[bob2525]

Oh this is grand. SadMax is back and giving advice to the coders. The very same awesome group of guys/gals that stepped up to help the proboards community when this guy got his panties in a wad a couple years ago, deleted his forum and all his hosted codes. Causing major disruption and agony across hundreds of forums. Now obviously hitting a mid-life crisis [due to still living in mommys basement] he comes in here acting like he's the goddess of proboards and everyone should forgive him for his teenage girl antics, forgive him, bow down to him, and take his word as the final say. Because trust me gentlemen, he knows a few things about proboards. LAWLS

[MadMax™]

You had to create an account to hide your identity, just to post all those BS lies? How sad.

[Michael]

Max makes me laugh! ;D

[Jordan]

This isn't really going anywhere so you guys can take it to private messages from here.