Coding Pet Peeves

[wildgoosespeeder]

This applies to codes that use a similar syntax.

One thing that drives me nuts are people that code like this using brackets:

for(i=0;i<10;i++){
    if(i%2==0){
        alert("Even");
    } else {
        alert("Odd");
    }
}

I prefer it that the codes were like:

for(i=0;i<10;i++)
{
    if(i%2==0)
    {
        alert("Even");
    }
    else
    {
        alert("Odd");
    }
}

---

Another thing that drives me nuts is excessive use of variables. I prefer it that my codes are memory efficient. Example of what I hate:

var i=4;
var j=45;
var k=i*j;
document.write(k);

I prefer to do that in one line, not four:

document.write(4*45);

---

Another thing that drives me nuts are codes that need a function only once. I understand that functions remove the need to copy and paste the code they contain several times like CrAzY_J's Different On/Off Icons code but there is an example of a code on Studio Zero that does what I hate:

Sub-Boards in Board Cell (look at "analyzePage()" and "addListing()" at the very bottom of the code)

I only see the words "analyzePage" and "addListing" twice in that code, one for defining the function and another for calling it. I say take the code those functions contain and paste over each corresponding function.

---

Anyways, what kinds of coding pet peeves do you have?

[Thesealion]

I really don't have any...although it is nice when people space properly...

[wildgoosespeeder]

Sometimes the spacing is from ProBoards trying to not have accessive spacing in posts. Sometimes good, othertimes bad.

[proseth]

I guess you wouldn't like my coding much then as I do both of the things you pointed out.

#1 I learned JavaScript before any other languages and I just learned to use brackets the first way (the way you dislike). Since then I've learned C++ and if I remember correctly you have to do it the second way or it's incorrect.

#2 I only do for readability purposes. If it's something that other people won't see or that I won't need to decipher later I'll do it your preferred way though.

I dislike when people don't space their coding or when people use spaces rather than tabs for nested blocks of code. I also dislike when large codes have no comments - sure they're not necessary but it makes it easier on the writer and reader. And I dislike when people use // for multi-line comments rather than /* .. */ - it is a habit I've just recently broke myself.

[wildgoosespeeder]

I just remembered another thing I hate. Modified my first post.

[Jordan]

Nov 16, 2010 14:34:30 GMT -8 wildgoosespeeder said:

This applies to codes that use a similar syntax.

One thing that drives me nuts are people that code like this using brackets:

for(i=0;i<10;i++){
    if(i%2==0){
        alert("Even");
    } else {
        alert("Odd");
    }
}

I prefer it that the codes were like:

for(i=0;i<10;i++)
{
    if(i%2==0)
    {
        alert("Even");
    }
    else
    {
        alert("Odd");
    }
}

It's best to get used to it. Whenever you work on any group project such as an open source project you need to follow the style that is being used and both are used frequently. I do prefer the second, however, but I have to code in the first for school since every professor uses a different style on purpose (to get us used to adapting to all the styles).

Nov 16, 2010 14:34:30 GMT -8 wildgoosespeeder said:

Another thing that drives me nuts are codes that need a function only once. I understand that functions remove the need to copy and paste the code they contain several times like CrAzY_J's Different On/Off Icons code but there is an example of a code on Studio Zero that does what I hate:

Sub-Boards in Board Cell (look at "analyzePage()" and "addListing()" at the very bottom of the code)

I only see the words "analyzePage" and "addListing" twice in that code, one for defining the function and another for calling it. I say take the code those functions contain and paste over each corresponding function.

I would just like to point out that you should hate the first code more than the second because of how terribly inefficient it is. ;P Using functions like in the first code is slow because it has to restart every time. It's better to create an array and then make one pass through the page.

As for Chris' code, I don't think it's really that big of a deal. Almost all programming that is done these days is done with procedures/functions etc. It's just how most programmers think, and one function call isn't going to slow anything down. Plus, it allows someone to put that code into a file, cache it, and then call it from the page.

I do see your point, but I don't think it's a bad programming practice.

I'll add some peeves later.

[wildgoosespeeder]

Nov 17, 2010 1:21:53 GMT -8 Jordan said:

I would just like to point out that you should hate the first code more than the second because of how terribly inefficient it is. ;P Using functions like in the first code is slow because it has to restart every time. It's better to create an array and then make one pass through the page.

Yup, I hate it...until I tweaked it for my forum. Now I don't hate it as much. ;D

Almost all the codes I want for my forum I check for efficiency. If it isn't efficient enough, I tweak it.

[Charles Stover]

I hate brackets for one-line conditionals.

for (i=0;i<10;i++)
{
    if (i%2==0)
        alert("Even");
    else
        alert("Odd");
}

I also hate conditions when they can be inline.

for (i=0;i<10;i++)
    alert(i % 2 ? "Odd" : "Even");

EDIT:
P.S. space after for and if

[Chris]

wild: Hate that style if you wish. It was me trying something new (note the post is 4 years old). It is much more closely related to how people program in Java and other OOP languages though.

As for pet peeves I have... nothing off the top of my head.

[wildgoosespeeder]

I don't hate your code (because I use my modified version of your code on my forum), I just hate the way you coded it.

[Thesealion]

In other words you like the code but hate the person...



I really don't like it when people submit codes and don't say what it does....sometimes the name doesn't even hint to what it does and when i was a beginner at coding (not that i am not still) i couldn't recognize hardly anything inside a code to hint as to what it did...

[Bennett 🚀]

I like it when you use the brackets how you did in the first post.. looks nice and orderly.

[Thesealion]

I do it both ways...

[wildgoosespeeder]

Nov 17, 2010 20:10:00 GMT -8 Thesealion said:

In other words you like the code but hate the person...

That's a bit of a judgmental conclusion, don't you think? Codes and people are two totally different things.

Nov 17, 2010 20:10:00 GMT -8 Thesealion said:

I really don't like it when people submit codes and don't say what it does....sometimes the name doesn't even hint to what it does and when i was a beginner at coding (not that i am not still) i couldn't recognize hardly anything inside a code to hint as to what it did...

You don't have to worry about me. I will give a description of what the code will do. If it is unclear in text, I will most likely put a preview image to give you a general idea what my codes after execution will look like.

[Dove]

I hate when you can't use an html code "assist" and you have to hand-type codes and then you leave out one little bracket, or one tiny apostrophe, and the entire website goes into chaos.