inherit
153968
0
Nov 19, 2012 15:03:05 GMT -8
Thesealion
New Phone Who Dis?
4,124
April 2010
joemaggio
|
Post by Thesealion on Jan 14, 2013 20:32:06 GMT -8
We could also just do that in our codes couldn't we?
|
|
inherit
16846
0
Nov 19, 2012 15:20:20 GMT -8
Chris
3,036
December 2003
cddude
|
Post by Chris on Jan 14, 2013 21:16:20 GMT -8
We could also just do that in our codes couldn't we? Yes. That's how we'd do it. It's just a concern over whether or not Yootil might ever use a key or something similar. If we feel like there's nothing important gained by it being a plugin (instead of a single line like that), then by all means, that's the right approach. I just want to see if Peter has any concerns.
|
|
inherit
153968
0
Nov 19, 2012 15:03:05 GMT -8
Thesealion
New Phone Who Dis?
4,124
April 2010
joemaggio
|
Post by Thesealion on Jan 15, 2013 12:50:46 GMT -8
Ok I'll not do it unless you guys decide officially it's ok
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jan 15, 2013 15:16:18 GMT -8
I would prefer it remained as a plugin and not directly included in your codes. There isn't really any difference at the moment, but if we do make some changes (i.e a key), then I'd rather people were using the plugin to get the benefit of it.
|
|
inherit
14706
0
Jan 28, 2021 15:41:20 GMT -8
Xikeon
170
October 2003
mikeo
|
Post by Xikeon on Jan 16, 2013 2:18:56 GMT -8
Is it an idea to add yootil.page.thread? I'm missing a built in way to get the thread ID.
proboards.data("page").thread
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jan 16, 2013 2:50:36 GMT -8
Is it an idea to add yootil.page.thread? I'm missing a built in way to get the thread ID. proboards.data("page").thread It's something we will be adding, just haven't got round to it. Me and Chris are just busy right now, though the project is open source, so you can contribute to it if you wish
|
|
inherit
14706
0
Jan 28, 2021 15:41:20 GMT -8
Xikeon
170
October 2003
mikeo
|
Post by Xikeon on Jan 16, 2013 3:27:10 GMT -8
Peter: Alright, I sent a pull request. Quick test: $.each( yootil.page.thread, function (k, v) { if( k === '__get_data' ) return; console.log(k + ': ' + yootil.page.thread[k]()); }); id: 6 is_announcement: false is_bookmarked: false is_falling: false is_locked: false is_new: false is_poll: false is_sticky: false subject: another thread url: /thread/6/another-thread Don't have uglifyjs here set up though, so I only added source + merged.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jan 16, 2013 4:43:35 GMT -8
Thanks XikeonI've updated Yootil to 0.8.3 Docs updated as well. Also bin is now changed to build, and updated the build folder for those that may be on windows. I did think about including the build for the docs, but will not bother for now.
|
|
inherit
14706
0
Jan 28, 2021 15:41:20 GMT -8
Xikeon
170
October 2003
mikeo
|
Post by Xikeon on Jan 16, 2013 5:18:50 GMT -8
Sweet! Updated my references and I'll have a look at the build process sometime if I add more in the future.
|
|
inherit
16846
0
Nov 19, 2012 15:20:20 GMT -8
Chris
3,036
December 2003
cddude
|
Post by Chris on Jan 16, 2013 8:06:35 GMT -8
aww, our first pull request. I feel so warm and fuzzy right now.
|
|
inherit
14706
0
Jan 28, 2021 15:41:20 GMT -8
Xikeon
170
October 2003
mikeo
|
Post by Xikeon on Jan 16, 2013 8:38:49 GMT -8
It's becoming a big boy now Chris
|
|
inherit
onewillingsniper@hotmail.com
185552
0
Mar 13, 2014 12:52:02 GMT -8
Willing Sniper
559
November 2012
sergentpepper
|
Post by Willing Sniper on Jan 28, 2013 0:09:56 GMT -8
It would be nice if the ratings showed on recent posts page.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jan 28, 2013 3:00:57 GMT -8
It would be nice if the ratings showed on recent posts page. Wrong topic?
|
|
inherit
onewillingsniper@hotmail.com
185552
0
Mar 13, 2014 12:52:02 GMT -8
Willing Sniper
559
November 2012
sergentpepper
|
Post by Willing Sniper on Jan 28, 2013 8:31:15 GMT -8
It would be nice if the ratings showed on recent posts page. Wrong topic? Uh yes... On far too long.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Feb 10, 2013 2:28:38 GMT -8
Small update. 0.8.4 AJAX class has a new method called "after_search". yootil.pixeldepth.net/files/src/ajax-js.html#yootil.ajax.after_searchThis appears to be working fine for me for pagination. I've been using it for a while now, let me know if you have issues, or suggestions for a better way. Here is an example of how to use it. yootil.ajax.after_search(this.show_in_mini_profile, this); In the method, note the first 4 - 5 lines, the rest of the code isn't important. show_in_mini_profile: function(){ var minis = $("div.mini-profile"); if(minis && minis.length){ if(minis.find("div.info span[class^=pd_money_]").length){ return; } for(var m = 0, l = minis.length; m < l; m ++){ var info = $(minis[m]).find("div.info"); if(info && info.length){ var info_div = info.get(0); var user_link = $(minis[m]).find("a.user-link[href*='user']:first"); if(user_link && user_link.length){ var user_id_match = user_link.attr("href").match(/\/user\/(\d+)\/?/i); if(user_id_match && user_id_match.length == 2){ var user_id = user_id_match[1]; var money = 0; var money_name = this.settings.money_text; if(yootil.key.has_value("pixeldepth_money", user_id)){ var user_data = yootil.key.value("pixeldepth_money", user_id, true); if(user_data){ money = parseInt(user_data.m) || 0; } } money = money.toString().replace(/(\d)(?=(\d\d\d)+(?!\d))/g, "$1,"); if(money_name.toString().length){ money_name += ": "; } var money_str_html = "<span class=\"pd_money_" + user_id + "\">" + money_name + " " + this.settings.money_symbol + "<span class=\"pd_money_value_" + user_id + "\">" + money + "</span><br /></span>"; //var money_edit = this.bind_edit_dialog("<span class=\"pd_money_" + user_id + "\">" + money_name + " " + this.settings.money_symbol + "<span class=\"pd_money_value_" + user_id + "\">" + money + "</span><br /></span>", user_id); $(info_div).prepend(money_str_html); } } } } } }
|
|