inherit
16846
0
Nov 19, 2012 15:20:20 GMT -8
Chris
3,036
December 2003
cddude
|
Post by Chris on Nov 4, 2012 11:41:08 GMT -8
Learning curve from SVN = not too terrible. The git designer intentionally made it different from SVN because he hated SVN. The way to make the transition easiest is to use their GUI apps instead of the command line. Anyways, my only reason behind using git is it makes it much easier (as in, push of a button easy) to allow other users to submit "pull requests" (their own modifications to our code) that we review and then can easily merge directly into our code base. That way you can limit those with no-review write access to you and me, but allow everyone else to submit their own "suggestions." Anyways, I'm fine with SVN. No reason to not open source this, so Google Code maybe? Am liking the idea of code reviewing, but not understanding how that is done when a project is public. Am reading some stuff about it now, and also installed Git. Here it is... github.com/pixelDepth/yootilI'll give it a try and see. Not sure I get the whole push / pull thing. Seems like an extra step just to get my changes into the rep. So if you were to commit something to that now, how do I apply your changes to the rep? So, git is distributed source control, that's why there's a different between commit and push/pull. It also is better with branching. For example, we have "master," the normal branch. Now say I want to rewrite the built in template parser for yootil (dunno if there is one.) I'd create a branch called something like: epic-parser-rewrite Now, this has a different timeline of commits. I can write all my modifications there. Then, when I'm ready to go, I push my branch back to GitHub. I send you a pull request containing my branch. This will then show you my list of commits (why commit vs push is important), the diff on my files, and any other comments I wrote. When you're done reviewing it, you can just click "Merge request" and it'll automatically (if possible) merge it in. Very simple. Other benefits: You can comment inline on code in GitHub, so we can add notes (i.e. why we did what) or ask questions (during a pull request/code review) to individual lines of code. Very useful tool. I'll pull that now, make some small modification and submit a pull request. That'll help walk you through the process.
|
|
inherit
16846
0
Nov 19, 2012 15:20:20 GMT -8
Chris
3,036
December 2003
cddude
|
Post by Chris on Nov 4, 2012 11:45:14 GMT -8
Ok, sent a sample pull request. At the top of the repo home, you'll see "pull requests" there which contains it. Hopefully it's self-explanatory from there. Edit: To avoid the dreaded triple post, the version variable is still 0.1 and not 0.2.4 btw. Edit 2: For the pbp, you should probably include a check for if yootil is defined or not, and only load the file once then. I can foresee some developers just hotlinking to the .min.src in their header.... this way we avoid double loading.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Nov 4, 2012 14:01:04 GMT -8
Chris already knows, but for those that don't, I've settled on Git. Will update the first post with all the details tomorrow. Ok, sent a sample pull request. At the top of the repo home, you'll see "pull requests" there which contains it. Hopefully it's self-explanatory from there. Edit: To avoid the dreaded triple post, the version variable is still 0.1 and not 0.2.4 btw. Edit 2: For the pbp, you should probably include a check for if yootil is defined or not, and only load the file once then. I can foresee some developers just hotlinking to the .min.src in their header.... this way we avoid double loading. Yeah, that property needs removing, as I forget to update it. Definitely need to do that, will get onto that tomorrow.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Nov 4, 2012 15:07:42 GMT -8
First post has been updated.
Contains updated links for where the project is, docs, min, src etc
Plugin file has also been updated so that it only loads yootil if it doesn't already exist.
|
|
#00AF33
14306
0
1
Sept 8, 2023 8:54:17 GMT -8
Jordan
What is truth?
11,838
October 2003
jab2
|
Post by Jordan on Nov 5, 2012 13:32:49 GMT -8
Git is a good choice, I've been using it for a large C++ project and I like it.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Nov 6, 2012 5:14:28 GMT -8
|
|
inherit
91950
0
Sept 25, 2020 18:19:25 GMT -8
iSilverfyre
Penguins!
235
November 2006
crazywolf14
|
Post by iSilverfyre on Nov 6, 2012 5:52:28 GMT -8
I'm not sure about this so I will ask. When you update this plugin do I have to reimport it into my plugins on my forum or does it update automatically?
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Nov 6, 2012 6:10:50 GMT -8
Anyone using the actual plugin doesn't need to do anything. The plugin contains a small script to pull in the yootils.min.js file if it doesn't already exist. The JS file is auto updated by me.
|
|
inherit
91950
0
Sept 25, 2020 18:19:25 GMT -8
iSilverfyre
Penguins!
235
November 2006
crazywolf14
|
Post by iSilverfyre on Nov 6, 2012 6:13:29 GMT -8
Awesome!
Thank you so much.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Nov 6, 2012 11:47:42 GMT -8
|
|
inherit
16846
0
Nov 19, 2012 15:20:20 GMT -8
Chris
3,036
December 2003
cddude
|
Post by Chris on Nov 6, 2012 13:55:49 GMT -8
Peter: Should we write test cases so that if PB changes anything, we get notified more easily of what broke? Edit: Also, we should probably split the modules into different files so the source doesn't get crowded.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Nov 6, 2012 14:14:11 GMT -8
Peter: Should we write test cases so that if PB changes anything, we get notified more easily of what broke? Edit: Also, we should probably split the modules into different files so the source doesn't get crowded. Test cases; yeah, I did look at QUnit a while back, so maybe that could work for us? I do have them split, I just hadn't wrote something to join them into 1 file yet, so it's a manual job right now. I need to push my src folder, but I'll sort that out some point this week and update you.
|
|
inherit
16846
0
Nov 19, 2012 15:20:20 GMT -8
Chris
3,036
December 2003
cddude
|
Post by Chris on Nov 6, 2012 14:36:59 GMT -8
Peter: Should we write test cases so that if PB changes anything, we get notified more easily of what broke? Edit: Also, we should probably split the modules into different files so the source doesn't get crowded. Test cases; yeah, I did look at QUnit a while back, so maybe that could work for us? I do have them split, I just hadn't wrote something to join them into 1 file yet, so it's a manual job right now. I need to push my src folder, but I'll sort that out some point this week and update you. Was about to push two new modules, so yeah, that'd help. Haha. Bash script for it?
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Nov 6, 2012 16:04:08 GMT -8
Test cases; yeah, I did look at QUnit a while back, so maybe that could work for us? I do have them split, I just hadn't wrote something to join them into 1 file yet, so it's a manual job right now. I need to push my src folder, but I'll sort that out some point this week and update you. Was about to push two new modules, so yeah, that'd help. Haha. Bash script for it? Go ahead with your push, I've pushed everything my side now... github.com/pixelDepth/Yootil/tree/master/srcI tried a batch script, but windows wasn't liking it, so I wrote a couple of PHP scripts to run via a bat file. Worth the effort as well, no more manually compressing the library now as well.
|
|
inherit
16846
0
Nov 19, 2012 15:20:20 GMT -8
Chris
3,036
December 2003
cddude
|
Post by Chris on Nov 6, 2012 18:56:33 GMT -8
Was about to push two new modules, so yeah, that'd help. Haha. Bash script for it? Go ahead with your push, I've pushed everything my side now... github.com/pixelDepth/Yootil/tree/master/srcI tried a batch script, but windows wasn't liking it, so I wrote a couple of PHP scripts to run via a bat file. Worth the effort as well, no more manually compressing the library now as well. I don't have anything installed on my laptop to run the min for me. I might run a bash script to update the src for me and update the min manually and commit it.
|
|