[Request] Quote only highlighted text

[Alanna 🥀🖤]

Feb 5, 2017 23:45:33 GMT -8 Chris said:

@khristian , I could most likely tell in a matter of minutes exactly why the plugin is not liking the terrain if the plugin was installed and running at the given link (at least I as a guest cannot see it) but let's take a stab in the dark and say the horizontal profile looks to have removed the mini-profile class and replaced it with post-mini-profile, this usually means a plugin trying to identify the mini-profile would be unable to continue...

It might be so much easier to remove a class and replace with your own but for compatibility you should keep BOTH classes and give your CSS rules more weight to override anything you do not want in the default class.

Honestly I COMPLETELY forgot I removed the mini-profile class. It's because I'm not using the mini profiles at all considering the variables I needed in the mini profile area didn't work in the mini profile template.

EDIT: Wait- but the plugin doesn't input the information into the mini profile... why would it matter?

[Chris]

The plugin needs to identify who is speaking in order to fill in the "author" of the quote

[Alanna 🥀🖤]

Ah. I added it back and hide it so the classname is still there but no cigar?

[Chris]

I could throw another stab in the dark at you or you could enable the plugin for m so I can see it in the light.

[Alanna 🥀🖤]

Feb 6, 2017 0:56:30 GMT -8 Chris said:

I could throw another stab in the dark at you or you could enable the plugin for m so I can see it in the light.

It is enabled.

[Chris]

?

[Alanna 🥀🖤]

Chris, it is enabled.

[Chris]

enabled for members so I would have to create an account then...

[Alanna 🥀🖤]

Feb 6, 2017 6:09:50 GMT -8 Chris said:

enabled for members so I would have to create an account then...

Didn't catch that, but too late for me to change it now as I see you already registered. *shrugs*

Feb 6, 2017 0:56:30 GMT -8 Chris said:

I could throw another stab in the dark at you or you could enable the plugin for m so I can see it in the light.

Sorry m didn't translate to members for me... just thought it was a typo.

[Chris]

Feb 6, 2017 6:15:53 GMT -8 @khristian said:

Feb 6, 2017 0:56:30 GMT -8 Chris said:

I could throw another stab in the dark at you or you could enable the plugin for m so I can see it in the light.

Sorry m didn't translate to members for me... just thought it was a typo.

LOL, "m" was abbreviation for "me" not "members" 

The hidden mini-profile appears to be in a tabular form and does not contain the avatar class, the plugin targets that class to grab the avatar image


ETA: also looks for $('.content-head .info', post) but that does not appear to be present in the restructuring as well.

ETA2:  should also be noted that in the beginning when God created V5, there used to be metadata for users available on the page but that was subsequently removed and remains only when viewing the members page pb.data("proboards.user"). This is why codes are now reduced to scrubbing the HTML for any crumbs that may have fallen off the table and are very susceptible to changes made to that HTML. In retrospect, in a system that allows for easy HTML changes through layouts may have considered it wise to keep that metadata around so a consistent and reliable source could be had without having to depend on template mods retaining the correct classes and structures. As with anything else the devil is in the details. [/rant]

[Alanna 🥀🖤]

Feb 6, 2017 6:30:55 GMT -8 Chris said:

Feb 6, 2017 6:15:53 GMT -8 @khristian said:

Sorry m didn't translate to members for me... just thought it was a typo.

LOL, "m" was abbreviation for "me" not "members" 

The hidden mini-profile appears to be in a tabular form and does not contain the avatar class, the plugin targets that class to grab the avatar image


ETA: also looks for $('.content-head .info', post) but that does not appear to be present in the restructuring as well.

ETA2: should also be noted that in the beginning when God created V5, there used to be metadata for users available on the page but that was subsequently removed and remains only when viewing the members page pb.data("proboards.user"), this is why codes are now reduced to scrubbing the HTML for any crumbs that may have fallen off the table. As with anything else the devil is in the details.

Not sure what you are referring to in ETA2... but- I got it all working with some tweaking.

BUT quotes aren't pulling info correctly in messages? Avatars won't display and usernames are just plain text.

[Chris]

Nevermind my rant, that was just my exasperation at seeing the V5 alpha that I fell in love with having to get a few limbs amputated by the bean counters.

I haven't checked the conversation page layouts and I am assuming that is what you meant by "messages", were there template mods made there as well?

If on the other hand you are referring to the thread summary, that first tab titled "Summary" is what you would see if the plugin was never installed, it's the other three tabs (Quotes, permaQuotes, WebQuotes) that are added by the plugin and contain content created through the plugin.





ETA: just did a test with quoting in personal messages and worked as expected for the most part (problem with floating selection checkbox on PMs which has not been reported, hmmm).


ETA: now I see what you mean, quotes within PMs have no avatar unless the quote author is a participant of that conversation (although preview still shows avatar). This was not previously the case and looks to have been another bean counter change that went under the radar. To be fair, the use cases for having quotes in a PM not involving participants might just be very low and number crunching probably showed this to be a way to optimize (Matej ?)

[Matej]

Looks like that might be a bug.

It's been added to the list to fix, but I can't say when that would be worked on.