Private user key won't store up to 4,000 bytes

[Jordan]

1) The URL to the page you are on when the bug occurred.

support.proboards.com/post/5194042/thread

Plugin: Posting Templates

2) What happened, in detail?

The plugin can't store up to 4,000 bytes of data using a private user key. See the link above to see what I am talking about.

3) What do you think should have happened instead?

Should allow me to store up to 4,000 bytes of data.

4) Can you reproduce this on every pageview?

Yes

5) What browser, version, and operating system are you using?

Lastest version of Chrome and Firefox, Windows 7

[Michael]

I asked around and nobody seems to come up with a plausible reason why it shouldn't allow more, so I'm creating a bug report for it.

[Jordan]

Thanks.

You guys are storing the text with ASCII encoding, right? So one byte per character?

[Michael]

Feb 28, 2013 11:08:21 GMT -8 Jordan said:

Thanks.

You guys are storing the text with ASCII encoding, right? So one byte per character?

As far as I remember, yes. Four thousand characters should be possible. 

[Jordan]

I'd like to add that the fail method is not being called when an attempt to set a private key fails. If "this.templates" is too long (such as 500 or so characters), I get a "Uncaught SyntaxError: Unexpected end of input" error in my console.

      saveTemplates: function() {
            this.plugin_key.set(this.templates, {
                  success: function() {
                        $('#posting_templates_save_message').html('Sucessfully saved!');
                        setTimeout(function() { $('#posting_templates_save_message').html(''); }, 3000);
                  },
                  fail: function(error) {
                        $('#posting_templates_save_message').html('Error ' + error.code + ': ' + error.reason);
                        // error.code will contain an error code id:
                              // 1 = value is too big
                              // 2 = server did not respond / general error
                              // 3 = this user does not have permission to change this key
                              // 4 = Invalid data received by the server
                        // error.reason will contain a friendly response from the server corresponding to the error code
                  }
            });
      }

Seems like an error code of 1 should be returned, but something curious happens because the data actually still gets sent to the server. However, this ends up completely breaking the page because this happens. The JSON just gets cut off.

proboards.plugin.keys.init(["posting_templates",1],["collapsible_memory",1]);proboards.plugin.keys.init_permissions(["posting_templates",{1:[1,1]}],["collapsible_memory",{1:[1,1]}]);proboards.plugin.keys.init_values(["collapsible_memory", 1, {"3":1,"4":1,"5":1,"6":1}],["posting_templates", 1, {"one":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\naaaaaaaaaaaaaaaaaaaaaaaaaa]);

[Michael]

Hey Jordan,

I went ahead and linked the devs to this thread in the bug report, so anything that you think is relevant you can post here for the devs to read when they get to this bug.

[Jordan]

Awesome, thanks Michael.

[Pebble]

Just wondering if there has been any progress or news update on this subject.
I've been using a 'thread' key and it seems to have the same problem.

proboards.plugin.keys.init(["preds",3]);proboards.plugin.keys.init_permissions(["preds",{3462:[1,1]}]);proboards.plugin.keys.init_values(["preds", 3462, {"predders":["biggatpne","burnleyfc1976","cartersrightpeg","clockworktangerine","deepdale10","deepedaleduck","dropout","prestonclaret","fenners","finneyfan","jas600","leylandlad","mooney","n7pne","northend","northenderontour","pnefromafar","pneskegs","dropout","prestonpete","proudpreston29","roadchefourstands","sherbetlemon","themaclad","whitepassion","jttt","minimooney"],"nowpreds":[5,0,0,0,0,0,0,0,0,0,0,9,1,1,1,1,1,1,1,1,1,1,8,2,2,2,2,2,2,2,2,2,2,7,3,3,3,3,3,3,3,3,3,3,6,3,3,3,3,3,3,3,3,3,3,nul]);
The data just gets cut off and 'breaks'.
Also, I can get an alert for when the key is saved successfully , but if it fails then there seems to no response.

If this is the limit, then I can split it into two seperate keys but would obviously prefer to keep it at one.
Thanks,
Pebble.

</pre>

[Michael]

This task has not yet been started yet, and I currently do not have an ETA yet. Sorry

[Pebble]

Thanks for the reply Michael,
Setting up another key doesn't work either as it lumps them both together, thus breaking it.
I suppose this one goes on the back burner for a while....

[Michael Hill]

The key size limitation issue has been fixed for the current boards reported and should be fixed on all forums shortly. Thank you for the report!

[Jordan]

Awesome, thanks for getting this fixed.

[Pebble]

Excellent news
Thanks.

[Jordan]

Any idea when this is going to be pushed out to all live forums? It's still not working here. I don't really care about my forum, I just want to be sure it has been fixed for all forums so I can add it to the plugin database (so no need to fix it for my forum individually like you did to the other forum).

[Michael]

This has not yet gone live, despite my assumption to the contrary. I poked Martyn about this and he assured me that it would be taken care of soon. My apologies for the delay.