Requesting Plug-In for Numbered Replies

[Rajiv]

Thanks for the code - added it to Layout Templates > Thread > Post List > line 14

<span class="date"><b>Posted by $[post.created_by.link]</b> $[post.created_on]</span>

The "Posted by" appears in bold, but not the Display Name.

Will follow up on the other thread.

Once again, thanks.

[♥ ℒʊ√ ♥]

Chris, I'm sad to report it seems the reply numbers aren't working in Chrome (latest Version 43.0.2357.124 m) any longer.

They're still fine in Firefox.


Can you please check it out?


Thank you!

[Chris]

Jun 21, 2015 13:06:23 GMT -8 ♥ ℒʊ√ ♥ said:

Chris, I'm sad to report it seems the reply numbers aren't working in Chrome (latest Version 43.0.2357.124 m) any longer.

They're still fine in Firefox.


Can you please check it out?


Thank you!

Hi ♥ ℒʊ√ ♥, I am unfortunately unable to break the code using the version of Chrome you mentioned as well as a newer version (43.0.2357.130 m) and it is imperative that I am able to view this breakage in order to track down the cause so if you could open your Chrome console (CTRL+SHIFT+J) and give me a listing of the errors that were logged to that console it will most likely help. In that version of Chrome you have the option to right click the console and choose save log but I still prefer the highlight a word then press CTRL+A and CTRL+C method since that preserves line references.

There are a few possible causes that come to mind with the limited amount of clues that I have so far (assuming "aren't working" means no longer visible and not some other type of malfunction such as wrong numbering, "NaN" showing instead, etc.) :

1. Theme (layout) Conflict
   Knowing how much you luv themes, is it possible this is happening in one or more theme and not in others? Would it be possible to ask the members that say they can still see the numbers what theme they are using and if you switch to that theme yourself does the problem still exist for you? This could hopefully be a simple case of a bunch of CSS rules unique to these themes cascading and conspiring to hide the link added by the code.
2. Code Conflict
   A code or plugin may have changed something in the matrix causing black cats, yadda yadda yadda...
   
3. OS
   I saw mention of the mac OS being a possible factor in who could see or not see so would it be possible to poll the various operating systems in use and their results regarding this issue for any correlation? (I'm testing on a Vista Laptop)
4. "use strict"
   The code makes use of a couple practices that would not be considered "safe" in strict mode but it doesn't explicitly ask to be evaluated in a strict mode. A change in 43 perhaps combined with the toggle of an experimental chrome flag or an extension might have cause the code to fail in your browser by somehow forcing strict mode on all evaluated codes
5. Library Host Failure
   A few days ago I and a few others were experiencing slow or failed access to some google services. In particular, Proboards uses Google's CDN for the jQuery library which would mean a cascade of failures for any codes that use the provided jQuery library (see spoiler) including codes native to Proboards (e.g. posting "cog" options do not appear and timestamps remain in their raw timezone offset form)
   
   SPOILER: Click to show
   
   

EDIT:

---

Joining your forum then viewing a thread finally showed me the problem and it appears to be plugin related but not for guests (I could see the numbers viewing as guest). There is a plugin named "post LOL" that adds "float:left" to the div with the class of "info" but also removes that class in the process. $('#post-'+postNum).find('.content-head>.info').removeClass().css('float','left');
The post numbering code specifically looks for classes in this order to confidently locate the landing area:
.content-head .info .date
but "info" has been removed by that plugin. It's not a terribly hard fix (just modify the code to look for .content-head .date instead of .content-head .info .date but that increases the chances of a false positive for aditional dates that may appear in that header area in the future or added by third-party code. It might be worth asking the author the reasoning behind removing the class. If it is, as I suspect, to override the importance placed on line-height for that class then there are other non-destructive means of doing so such as providing a higher specificity rule with dueling importance (aka "arms race" and why frivolously using !important defeats the idea behind "cascading") or by an inline rule set as important where only user accessibility styles can override. It might also be useful to see if that mac user is able to use that LOL plugin and if not inform the author so that can be addressed if possible .

[♥ ℒʊ√ ♥]

Ah, ha! Chris, thank you!

I just added that LOL plugin from Todge.


I should have considered that, but I didn't.


Thank you so much for joining and figuring it out.


I guess I'll have to disable that plugin again.


But reply numbers are needed as they are often referred to on our board.

Enjoy your weekend!

[♥ ℒʊ√ ♥]

I just disabled that plugin and yes, it did the trick, Chris.

[Chris]

That's good to hear ♥ ℒʊ√ ♥ but keep in mind that the edit to the numbered post code, that I mentioned earlier, should also do the trick and get both code and plugin coexisting but for greater compatibility with the entire coding community it would be best that the LOL plugin avoid removing that class. I had never heard of that plugin much less know that Todge was the author but that makes things much easier.

[♥ ℒʊ√ ♥]

Yikes, I'm so glad you tagged me, Chris. somehow I skimmed over that with all of the strike outs in your post.

Let me read that more thoroughly. If we can get "peace in the valley" between your code and Todge's plugin that would be great.

It's a new plugin that Todge graciously did for a request on the plugin thread.


And he already had to make some changes for me because it wasn't playing nice with the mini-profile, so I didn't wish to bother with yet another re-do.


All of you coders give so unselfishly of your time, and we're all so appreciative. The last thing I want to do is make more work for any of you.

[Todge]

Jun 26, 2015 16:40:36 GMT -8 Chris said:

That's good to hear ♥ ℒʊ√ ♥ but keep in mind that the edit to the numbered post code, that I mentioned earlier, should also do the trick and get both code and plugin coexisting but for greater compatibility with the entire coding community it would be best that the LOL plugin avoid removing that class. I had never heard of that plugin much less know that Todge was the author but that makes things much easier.

Jun 26, 2015 18:55:57 GMT -8 ♥ ℒʊ√ ♥ said:

Yikes, I'm so glad you tagged me, Chris. somehow I skimmed over that with all of the strike outs in your post.

Let me read that more thoroughly. If we can get "peace in the valley" between your code and Todge's plugin that would be great.

It's a new plugin that Todge graciously did for a request on the plugin thread.


And he already had to make some changes for me because it wasn't playing nice with the mini-profile, so I didn't wish to bother with yet another re-do.


All of you coders give so unselfishly of your time, and we're all so appreciative. The last thing I want to do is make more work for any of you.

Hey-ya,

I have updated the plugin so that it no longer strips the classname from the 'info' cell.. I never knew that you could set the 'style' attribute and it would overwrite any existing !important classes, I did try setting it with .css(), but that failed, which is why I resorted to removing the classname originally.

Sorry about that, and good to see back EB

[♥ ℒʊ√ ♥]

Todge, thank you so much. I truly appreciate this. My members are using the LOL button, and I would have done the edit to the numbered post code, but am very happy you reworked the plug-in.

I'm heading out for a bit but will get the updated plugin and let you know how that goes.


You guys really are the best ~ and, as I said, so generous of both your talent and your time.

[♥ ℒʊ√ ♥]

Todge, you did it! Chris's post numbers and your LOL plugin are playing nicely together.

Thank you!

[Todge]

No worries..

[Chris]

Glad it is sorted for you Luv.

Jun 27, 2015 7:33:18 GMT -8 Todge said:

I did try setting it with .css(), but that failed, which is why I resorted to removing the classname originally.

Sorry about that, and good to see back EB

Thanks Todge, priorities have changed for me so I'll be here just not as frequently as before.

It should be noted for future reference that most browsers will invalidate an inline css value with a modifier:
element.style.color = "red!important"; //ignored value
element.style.color = "red"; //accepted value
and since this is the underlying method used by jQuery's .css() it would also inherit that limitation.

Setting it as a style attribute however doesn't have this limitation:
element.style.cssText = "color:red!important";
$(element).attr('style', 'color:red!important'); //jquery equivalent
The drawback of course being you might be overwriting inline styles already existing on the element so it might be safer to read what is there and then append your style to whatever is already there. You could also prepend to any existing value which would simplify semicolon detection differences between browsers but keep in mind that the last value wins in case of conflict and there is a bug in older IE where an important value will be ignored if followed by a conflicting value even if that second value was had no important modifier.

[Todge]

Thanks Chris, after going back and trying both the above mentioned techniques for setting the style of an element, I realised that both would have worked, though I went with the later.

I did wonder if it would overwrite any existing style attributes, not just the one targeted, so thanks for that info and I'll keep that in mind.