inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,018
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Dec 26, 2016 18:33:53 GMT -8
So just to be clear, the avatar option as it is implemented now, is treated as a "dependent option of last resort" meaning if the setting to automatically choose an image if none was specified is turned off ("use first image found") then the avatar setting becomes meaningless (and ignored) which is what it sounds like from your description of the first test case not having "use first image found" enabled (ergo no attempt to find a suitable image with no failure to find such an image then ultimately avatar kicking in as the option of last resort).
It sounds like what you're asking for is the option to initiate a search for an image regardless of whether "use first image found" is enabled and therefore have the new option act independent of that setting? That is quite straightforward with the avatar option resulting only in avatars when used by itself and only serving as a safety net when used in conjunction with the other options.
I might revisit it tonight if time permits
|
|
inherit
210338
0
Nov 21, 2024 20:26:10 GMT -8
RichardInTN
472
June 2014
richardintn
|
Post by RichardInTN on Dec 26, 2016 18:42:42 GMT -8
So just to be clear, the avatar option as it is implemented now, is treated as a "dependent option of last resort" meaning if the setting to automatically choose an image if none was specified is turned off ("use first image found") then the avatar setting becomes meaningless (and ignored) which is what it sounds like from your description of the first test case not having " use first image found" enabled (ergo no attempt to find a suitable image with no failure to find such an image then ultimately avatar kicking in as the option of last resort). It sounds like what you're asking for is the option to initiate a search for an image regardless of whether "use first image found" is enabled and therefore have the new option act independent of that setting? That is quite straightforward with the avatar option resulting only in avatars when used by itself and only serving as a safety net when used in conjunction with the other options. I might revisit it tonight if time permits My though process was for (if the option is selected) it to default to Avatar first, THEN use something else if an image is picked from the list or if the thread creator specifies an image. It would work wholly independent of search for first image (when I initially thought was "search thread/originating post for first image in posts(s)", not "search icons list for first icon"). ETA: cool on revisiting it whenever you get the chance. It's just a suggestion.
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,018
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Dec 26, 2016 19:43:27 GMT -8
The "search" is initiated whenever there is inaction from the user and the option to find a suitable image is also enabled (either from the contents of the post or via the menu if "Force" is enabled). With the advent of this new option there exists a conflict since either one can now initiate a search for a suitable image. This is why I had initially made one dependent on the other but with independence then some way of deciding which gets precedence has to be established. According to your last post I'm getting that if both options are enabled then precedence goes to the avatar option whenever user inaction occurs but someone else may prefer the complete opposite. It might be best to make the options mutually exclusive then...
|
|
inherit
210338
0
Nov 21, 2024 20:26:10 GMT -8
RichardInTN
472
June 2014
richardintn
|
Post by RichardInTN on Dec 26, 2016 20:41:18 GMT -8
Mutual exclusivity would probably be best.
ETA: Maybe make that a separate three choices from the other three choices.
Whereby choosing one of the following automatically de-selects the other two? Can a plug-in do that? Something like:
If no image is chosen: [ ] Use Avatar [ ] Use First Image [ ] Use Neither (revert to default provided image with theme)
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,018
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Dec 27, 2016 15:55:15 GMT -8
RichardInTN give this edited version a try. This includes the mutually exclusive (single select) options we previously discussed as well as a few minor patches such as automatic detection of smiley images via the "smile" class (which was added sometime after plugin creation)
|
|
inherit
210338
0
Nov 21, 2024 20:26:10 GMT -8
RichardInTN
472
June 2014
richardintn
|
Post by RichardInTN on Dec 27, 2016 18:00:36 GMT -8
Giving it a try now... will see what happens!
ETA: By Jove! I do believe that's done it!
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,018
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Dec 30, 2016 6:43:35 GMT -8
If you have no bugs to report RichardInTN (or anybody else) I'll update the main link once baby new year stops walking around and decides to take a nap.
|
|
inherit
210338
0
Nov 21, 2024 20:26:10 GMT -8
RichardInTN
472
June 2014
richardintn
|
Post by RichardInTN on Dec 30, 2016 17:12:54 GMT -8
It's working great for me!
|
|
inherit
210338
0
Nov 21, 2024 20:26:10 GMT -8
RichardInTN
472
June 2014
richardintn
|
Post by RichardInTN on Dec 31, 2016 0:02:54 GMT -8
Well... no "bugs"... but one of my Forum Moderators (who I've got helping me look for issues) just asked "Can you stop those spinning icons by these two threads?"... So... I looked on the setup for the plugin... and there's no way to opt out specific themes or members from SEEING them (and just let them be stuck with the default icons). All that exists now is opting out of letting them set them. I know this is a big "ask"... but would it be possible to add that functionality? Either one ("opt out theme", or "opt out member") ETA: the "spinning icons" in question are: and
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,018
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Dec 31, 2016 15:56:33 GMT -8
Well... no "bugs"... but one of my Forum Moderators (who I've got helping me look for issues) just asked "Can you stop those spinning icons by these two threads?"... So... I looked on the setup for the plugin... and there's no way to opt out specific themes or members from SEEING them (and just let them be stuck with the default icons). All that exists now is opting out of letting them set them. I know this is a big "ask"... but would it be possible to add that functionality? Either one ("opt out theme", or "opt out member") ETA: the "spinning icons" in question are: and RichardInTN , all plugins installed on your forum can be configured to run only on specific themes or be shown only to specific group members so going to your list of installed plugins on your MANAGE tab and clicking the edit permissions button will bring up a dialog that will allow you to include/exclude one or more groups or one or more themes from `seeing` the plugin. With that you can designate a theme that can be used to opt-out or perhaps add that member to a group made specifically to opt-out.
|
|
inherit
210338
0
Nov 21, 2024 20:26:10 GMT -8
RichardInTN
472
June 2014
richardintn
|
Post by RichardInTN on Dec 31, 2016 17:31:01 GMT -8
I knew that. Just didn't consider it because I figured the plugin added some text somewhere (to the thread title, maybe?) so it knows what Icon to grab. Didn't want the extra "stuff" showing up for people not running the plugin.
But... if you say that's the best way to do it, then that's good enough for me!
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,018
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Dec 31, 2016 17:38:06 GMT -8
The plugin uses a key to store and retrieve data so the old way of storing data in the nooks and crannies of the UI is no longer necessary.
|
|
inherit
210338
0
Nov 21, 2024 20:26:10 GMT -8
RichardInTN
472
June 2014
richardintn
|
Post by RichardInTN on Dec 31, 2016 18:45:48 GMT -8
The plugin uses a key to store and retrieve data so the old way of storing data in the nooks and crannies of the UI is no longer necessary. Cool!
|
|
inherit
167709
0
Sept 25, 2018 7:21:22 GMT -8
SailorEffinMoon
I think it's really cool how the word "OK" is a sideways person!
244
June 2011
cameronnat
|
Post by SailorEffinMoon on Nov 2, 2017 11:23:16 GMT -8
Hi there, having a little issue on my new site. I've got it on default theme, my permissions for the plugin are set to "Everyone" and applied to my default theme, but I (admin) am the only one who can see the thread icons. Am I having a brain fart and missing something? Here is the board in question
|
|
inherit
167709
0
Sept 25, 2018 7:21:22 GMT -8
SailorEffinMoon
I think it's really cool how the word "OK" is a sideways person!
244
June 2011
cameronnat
|
Post by SailorEffinMoon on Nov 4, 2017 7:03:56 GMT -8
BUMP
|
|