Talking Posts 0.2.1

[Former Member]

Jan 7, 2016 13:14:47 GMT -8 Peter said:

@joecool111 ,

You are starting to push my patience now. I've said "No", so please accept it.

ok thanks, my dinners cooked anyways  


Great plugin btw, good for a laugh  

thanks.

[Chris]

So Peter , any thoughts on why it would have been returning false for that hasOwnProperty? The only thing I could come up with is that it was a V8 engine optimization gone awry (never checked the other engines to confirm), with "lang" being one of the natively "implied" properties.

[Peter]

Jan 7, 2016 18:26:01 GMT -8 Chris said:

So Peter , any thoughts on why it would have been returning false for that hasOwnProperty? The only thing I could come up with is that it was a V8 engine optimization gone awry (never checked the other engines to confirm), with "lang" being one of the natively "implied" properties.

Am not 100% sure.  All the properties are inherited from the parent interface it seems (that being the EventTarget), so that could be the problem?  I tried digging through the "SpeechSynthesisUtterance" and "SpeechSynthesisUtteranceBinding" source as I was interested to see what was going on, but I can't say for certain.

[wildmaven]

Peter, mine sounds like it's speaking German.

I deleted the original plugin and uploaded the new one. Now there are 2 "Listen to Post" buttons and none of them work. *flail*

[Chris]

Jan 23, 2016 21:45:57 GMT -8 wildmaven said:

Peter , mine sounds like it's speaking German.

I deleted the original plugin and uploaded the new one. Now there are 2 "Listen to Post" buttons and none of them work. *flail*

The forum has an outdated version of the awards plugin (v2.2.0) which uses an outdated pagechange hack and that is what is responsible for the double buttons, try updating to the current version of the award plugin (v2.6.7)

Peter  added `.bind(this)` to function passed to PB event, didn't realize it used this so would resolve to window when passed as a standalone function

[Peter]

Jan 23, 2016 23:14:12 GMT -8 Chris said:

Peter  added `.bind(this)` to function passed to PB event, didn't realize it used this so would resolve to window when passed as a standalone function

You lost me there. I don't see what you are referring too in the code (aka I can't see a ".bind(this)").

[Chris]

Jan 24, 2016 10:46:26 GMT -8 Peter said:

Jan 23, 2016 23:14:12 GMT -8 Chris said:

Peter  added `.bind(this)` to function passed to PB event, didn't realize it used this so would resolve to window when passed as a standalone function

You lost me there. I don't see what you are referring too in the code (aka I can't see a ".bind(this)").

Jan 5, 2016 12:24:59 GMT -8 Chris said:

if(route && route.name && route.name.match(/^thread|search_results|all_recent_posts$/)){

this.add_hear_button();

               pb.events.on('afterSearch', this.add_hear_button.bind(this))

}



Peter , just noticed that the function has to be bound since it utilizes `this`

[Peter]

Chris,

Ah, ok. I didn't use all of your code, I modified it and forgot to create a proxy (I is dumb). So that's why I was confused, as there was no ".bind" in the code.

wildmaven,

Download 0.2.1 from the first post. It fixes a scope issue when clicking on the button if the page has changed.

[Peter]

Chris,

Forgot to say (posting as a new reply in case you already read previous message).

+ 1 for using "bind".  Been yonks since I looked at that, but it's pretty well standard now.  IE was the issue at the time (shocker), but who cares about anything < 9.

Link for others: developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_objects/Function/bind

[Chris]

I wasn't sure if the IE browser had added support for it yet but since this involved an experimental API supported only by Chrome (with Firefox possibly considering it?) then my thinking was IE wouldn't really matter anyway.

..although this API is almost directly lifted from Microsoft's win32 TTS at least the way I remember it since I recognize properties such as voiceURI (VB) from back when I used to play around with it.

Edit: LOL, refresh the page while it is talking and it continues talking which tells me it is offloading on windows TTS anyway.

[wildmaven]

Chris and Peter, thanks! That took care of it.

[Chris]

wildmaven , test it on a multi-page thread then switch pages and you'll see^* why Peter is recommending you update it to version 0.2.1

*sound will not play once you change pages in case you missed that