PM Notifications (D-NLS)

[aRMY83]

I have it installed on my test site:

twkooler.proboards.com/

and is now opened for you to register.

[aRMY83]

Opps... for to let you know that I did do the modification and still a no go:

[Lynx]

That's putting the >> and << around the number for the number of messages. I just put a space in there and no change on my test forum.

I see you have a Forums.net forum. If I recall correctly, do FDN forums require the full URL for different pages (I seem to recall this was something brought up with one of Todge's plugins awhile ago). If it does, then the culprit could be this line:


var nbrMsgs = $("[href='/conversations']").find('.tip-number').html();


which uses the shorter method for pages and not the full URL.

[Lynx]

I've also just registered on your test site.

[aRMY83]

Not sure on the FDN forums requiring the full URL for different pages.

[aRMY83]

Nov 19, 2016 16:44:18 GMT -8 Lynx said:

I've also just registered on your test site.

Do you want me to send you a PM or visa versa to see what happens?

[Lynx]

I sent myself a PM and I see the double instance. Working on it now.

[Lynx]

For some reason, it's adding a 2nd one. Looking at the element, I noticed the 2nd one has a font-size of 4 - which was something that was in there when I was converting my code. Here's a copy that has all defaults removed from the UI in the build. You may need to add test colors - as there will (or, should not be) any set and I didn't add in any catches for undefined's for the colors yet. I'd like to see if we can get rid of that duplicate first.

PM Notification 101.pbp (2.29 KB)

[Lynx]

The other thing that's bothering me, is that your page source is showing the one with the font-size of 4.

[aRMY83]

Sorry for the lateness Lynx as I was working on one of my PC's with some issues.

Just installed the 101 and I'll send you and one of my members a PM there to see what happens,

[aRMY83]

Sorry to say Lynx as it's still showing two:



Bed time for this ol' fellow and will check back here tomorrow morning.

Cheers...

[aRMY83]

Hello Lynx

Just now switched to the Wide Tester Theme and it works perfect showing only one NEW MESSAGE container:



There must be something in the Dark Edges theme that is causing the double container affect. I'm going to do some checking of that theme to see if I can come up with the cause of this and let you know here.

[aRMY83]

Well Lynx, you can rest at ease as it is not your plugin having issues, but that default theme (Dark Edges) of mine that has issues. Just installed 3 other themes and this plugin is working as should be.

Going to delete that default theme as over the span of a few years, I have modified it way to many times and because of that, I'm going to remove it and replace with another.

Great plugin my friend...

[aRMY83]

Just a thought here and that is with this part of the code:

if (!settings.msg_ca_size || settings.msg_ca_size <= 0) { // if the text size is undefined or is less than or equal to 0, set it to 18 (px).
caSize = 18;
}
else {
caSize = settings.msg_ca_size; // otherwise, set the text size to the setting in the plugin UI.

so that it will inherit the default forum text size?

Just to note, I added the letter u in the word plgin.

[Lynx]

Nov 20, 2016 4:57:09 GMT -8 aRMY83 said:

Well Lynx, you can rest at ease as it is not your plugin having issues, but that default theme (Dark Edges) of mine that has issues. Just installed 3 other themes and this plugin is working as should be.

Going to delete that default theme as over the span of a few years, I have modified it way to many times and because of that, I'm going to remove it and replace with another.

Great plugin my friend...

And here I am, with cup of coffee in hand, ready to take this thing on again.

I'm very glad to hear that you got it sorted! I was thinking about asking if you had done any template modifications next, as Todge had told me that it might be hit and miss with updated templates:

Nov 18, 2016 18:33:22 GMT -8 Todge said:

You can grab it from the standard template with this..

var PMS = $("[href='/conversations']").find('.tip-number').html();

But whether that would work with updated templates could be pretty hit and miss.

So, I was warned that it might not work for everyone. It would be nice to know what change in the template caused your double instance though. Ah, well - I'm just happy it's working for you!

Thank you for the compliment!