Navbar Links plugin

[Lynx]

I'm working on an update for my Navbar Links plugin. Here's the code:

SPOILER: Click to show


// Navbar Links
// Version: 1.0.1
// Author: MSG
// This header is to remain intact.

function navlinks() {
   var user = pb.data('user');
   var groups = pb.data('user').group_ids;
   var settings = pb.plugin.get('msg_navbar_links').settings;
   var linkName = "";
   var linkColor = "";
   var linkBGColor = "";
   var linkDest = "";
   var linkTarget = "";
   var linkBold = "";
   var whoCanUse = [];
   
   if (settings.msg_navlink.length) {
       for (z = 0; z < settings.msg_navlink.length; z++) {
           if (!settings.msg_navlink[z].link_name) {
               pb.window.alert('Plugin: Navbar Links says - Missing Link Name','You must provide a link name for the navbar link.<br /><br />Error at UI Entry: ' + (z + 1),{
                   minHeight: 200,
                   minWidth: 600
               });
               return;
           }
           else {
               linkName = settings.msg_navlink[z].link_name;
           }
           
           if (!settings.msg_navlink[z].text_color) {
               linkColor = "#ffffff";
           }
           else {
               linkColor = '#' + settings.msg_navlink[z].text_color;
           }
           
           if (!settings.msg_navlink[z].bg_color) {
               linkBGColor = "transparent";
           }
           else {
               linkBGColor = '#' + settings.msg_navlink[z].bg_color;
           }
           
           if (!settings.msg_navlink[z].dest_link) {
               pb.window.alert('Plugin: Navbar Links says - Missing Destination','You must provide a destination link.<br /><br />Error at UI Entry: ' + (z + 1),{
                   minHeight: 200,
                   minWidth: 600
               });
               return;
           }
           else {
               linkDest = settings.msg_navlink[z].dest_link;
           }
           
           if (!settings.msg_navlink[z].tab_type) {
               linkTarget = "_self";
           }
           else {
               linkTarget = settings.msg_navlink[z].tab_type;
           }
           
           if (!settings.msg_navlink[z].do_bold) {
               linkBold = "normal";
           }
           else {
               linkBold = settings.msg_navlink[z].do_bold;
           }
           
           if (settings.msg_navlink.length) {
               for (z = 0; z < settings.msg_navlink.length; z++) {
                   for (y = 0; y < settings.msg_navlink[z].who_can_use.length; y++) {
                       if ($.inArrayLoose(groups, settings.msg_navlink[z].who_can_use[y] != -1) || settings.msg_navlink[z].who_can_use[0] == undefined) {
                           $('#navigation-menu > ul').append('<li><a class="msg-navlnk" href="' + linkDest + '" style="color: ' + linkColor + ' !important; background-color: ' + linkBGColor + ' !important; font-weight: ' + linkBold + '" target="' + linkTarget + '">' + linkName + '</a></li>');
                       }
                   }
               }
           }
           
       }
   }
};

$(document).ready(function() {
   navlinks();
});


Here's the UI:



I've added using Member Groups, but I've got to be doing something wrong - as nothing shows in the navbar and no errors. I did have this line:


if ($.inArrayLoose(groups, settings.msg_navlink[z].who_can_use[y] != -1) || settings.msg_navlink[z].who_can_use[0] == undefined) {


like this:


if ($.inArrayLoose(groups, settings.msg_navlink[z][y].who_can_use != -1) || settings.msg_navlink[z][0].who_can_use == undefined) {


but no luck. The for loop for the y variable was added in, thinking I would need a separate loop to check that. Before I added the for loop for the y variable, I had 2 instances of Test 1 showing in the navbar, when there should have been a Test 1 and a Test 2:




If nothing is added into the Who Can Use? column, the link should show for everyone. Any advice / assistance would be appreciated.

Thanks!

[Peter]

$.inArrayLoose(groups, settings.msg_navlink[z].who_can_use[y]) != -1

[Lynx]

Thanks, Peter!

I see that I had put a parenthesis in the wrong spot. Sadly, though, I'm not getting anything on my navbar after the fix. Here's the link if you've got time to take a quick peek: codesndesigns.boards.net/

Do I even need the 2nd for loop (the one for the y variable)?

[Peter]

The reason for that is this line...

for (y = 0; y < settings.msg_navlink[z].who_can_use.length; y++) {

That loop will never happen if the length is 0.

Edit:  Just to be a little clearer.  Anything inside that loop will not get executed if the length of the array is 0.

[Lynx]

Should I put this above it:


if (settings.msg_navlink[z].who_can_use.length) {


[Peter]

So if I am right in what you are trying to do, you want it so that if there are groups, then check to see if the user is in any of those groups, and if so, show the nav links. Otherwise if there are no groups, show them to all.

If that is correct, then what I like to do is split that permission check out into a function. So your main loop would look like this now...

if (settings.msg_navlink.length) {
for (z = 0; z < settings.msg_navlink.length; z++) {
if(can_use_nav_link(groups, settings.msg_navlink[z].who_can_use) || settings.msg_navlink[z].who_can_use.length == 0){
  $('#navigation-menu > ul').append('<li><a class="msg-navlnk" href="' + linkDest + '" style="color: ' + linkColor + ' !important; background-color: ' + linkBGColor + ' !important; font-weight: ' + linkBold + '" target="' + linkTarget + '">' + linkName + '</a></li>');
}
}
}

And a new function...

function can_use_nav_link(groups, users){
for (y = 0; y < users.length; y++) {
if ($.inArrayLoose(groups, users) != -1){
return true;
}
}

return false;
}

Something like that will work.

[Lynx]

Thank you again, Peter.

I did that, but I'm still getting 2 Test 1's on the navbar:




even though I've got a Test 1 and a Test 2 in the UI:



And this is correct:

Sept 4, 2017 14:23:14 GMT -8 Peter said:

So if I am right in what you are trying to do, you want it so that if there are groups, then check to see if the user is in any of those groups, and if so, show the nav links. Otherwise if there are no groups, show them to all.

[Peter]

Lynx,

How come you have 2 loops with the inner loop doing the same as the outer? I missed that when I looked at your code.

So this...

if (settings.msg_navlink.length) {
for (z = 0; z < settings.msg_navlink.length; z++) {
if(can_use_nav_link(groups, settings.msg_navlink[z].who_can_use) || settings.msg_navlink[z].who_can_use.length == 0){
  $('#navigation-menu > ul').append('<li><a class="msg-navlnk" href="' + linkDest + '" style="color: ' + linkColor + ' !important; background-color: ' + linkBGColor + ' !important; font-weight: ' + linkBold + '" target="' + linkTarget + '">' + linkName + '</a></li>');
}
}
}

Becomes this...

if(can_use_nav_link(groups, settings.msg_navlink[z].who_can_use) || settings.msg_navlink[z].who_can_use.length == 0){
  $('#navigation-menu > ul').append('<li><a class="msg-navlnk" href="' + linkDest + '" style="color: ' + linkColor + ' !important; background-color: ' + linkBGColor + ' !important; font-weight: ' + linkBold + '" target="' + linkTarget + '">' + linkName + '</a></li>');
}

[Lynx]

Peter,

If I get rid of the z-loop, won't this line error:

if(can_use_nav_link(groups, settings.msg_navlink[z].who_can_use) || settings.msg_navlink[z].who_can_use.length == 0){

since there is no 'z' variable now?

[Peter]

Lynx,

No, as you already have that loop at the top. I think you may have copied and pasted an extra loop by mistake.

[Lynx]

DORT! I forgot all about the one up there. Thanks, Peter - I'll go try it out now.

EDIT: That did the trick! Thank you very much, Peter!

[Peter]

Lynx ,

lol, it happens

I took a quick look at the forum, seems to be working as expected. Just test the groups permission to be sure.

[Lynx]

Peter,

I just did. I added a group I was not in (I'm on with my alt account) and I no longer saw that link. Did the same for the other link, then both links. Working as intended! Thank you!

[Peter]

Lynx,

Nice one. And anytime

[Lynx]

Peter,

Sorry to bother you again, but I found a small problem that I can't seem to fix:




It seems that it's always going to return false because of it trying to compare a string to an integer. I tried changing this line:


if(can_use_nav_link(groups, settings.msg_navlink[z].who_can_use) || settings.msg_navlink[z].who_can_use.length == 0){


to this:


if(can_use_nav_link(groups, parseInt(settings.msg_navlink[z].who_can_use)) || settings.msg_navlink[z].who_can_use.length == 0){


thinking it might convert the array to integers for the comparison. It converted it alright, but not as an array (it only returned the index 0 entry in the array) - so it still returned false.

(Note: When I tried yesterday, I failed to add my own group in as a test (alt account). Testing today, I'm seeing it as not working.)


Any ideas?

Thanks!