YourShop 0.3 donations not deleted when processed

[ysth]

Forum URL: Not Provided

Description: YourShop 0.3 donation messages are no longer getting deleted when they are processed, leaving the recipient able to process them multiple times.

The attempt to delete the message results in an error page saying "You did not access this page through the correct form." (though the donation continues to process, redirecting away from this page).

This appears to have been introduced by a proboards change to improve security against cross-site-scripting attacks.


Experienced By: Not sure

Code URL: support.proboards.com/index.cgi?board=codedatabase&action=display&thread=70569

Web Browser: Not sure

[ysth]

This patch fixes the problem:


--- shop/0.3/donation.js.orig 2011-10-05 21:45:35.923015503 -0700
+++ shop/0.3/donation.js 2011-10-05 21:45:32.416014679 -0700
@@ -271,7 +271,7 @@
if (conf){
setCookie("shp-act", "sendToModifyProfile2");
setCookie("shp-amt", donAmt);
- window.location = location.href.replace(/pmview/i, "pmdelete");
+ postRequest(location.href.replace(/pmview/i, "pmdelete&l=1"),1);
}
}