External Link Confirmation

[Quozzo]

Displays an alert to anyone whenever they click on an external link that it takes them off your board.

You can customize the title and message of the confirmation that is seen.


www.proboards.com/library/plugins/item/984

[P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓]

Doesn't work with links posted in the shoutbox. They have target="_blank" so it opens in a new tab. I'm not saying this is something that your plugin has to account for but I thought I would bring it to your attention.

I really like your plugin. It seems to work well and it allows for a custom title and message with a yes no dialog. This is definitely a well thought out plugin.

[Quozzo]

Thanks.

I forgot about the shoutbox   I'll add it when I can.

[Quozzo]

I've updated the code's even delegation so it now works for messages retrieved via AJAX!

[P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓]

Apr 24, 2015 18:42:41 GMT -8 Quozzo said:

I've updated the code's even delegation so it now works for messages retrieved via AJAX!

May I ask what code you used to look at the shoutbox ajax to compare to mine. I'd like to see your thought process

[Quozzo]

Hi P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓, I didn't use any ajax method. I used event delegation as i only need to listen for an event. So I bind an event to the container for the .message elements which only fires if a click event is triggered within one of those delegated elements.

$('.container').on('click', '.message a:not([href^="'+url+'"])', function(e){
Provided that the .container is static and not removed and reinserted then I bind the click event to that element which only triggers when a .message a element is clicked. If the .container is not static and is removed or destroyed, then you can bind the event listener to the document, but as all the click events would then need to propagate up the DOM tree it takes more resources, so it's much more efficient to bind the click event as close to the inserted elements as possible.

$(document).on('click', '.message a:not([href^="'+url+'"])', function(e){


You can read more about jQuery's on method on their site here


Feel free to take a look at my code. I learned a lot by studying other's codes to see the 

[P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓]

Apr 25, 2015 0:24:14 GMT -8 Quozzo said:

Hi P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓, I didn't use any ajax method. I used event delegation as i only need to listen for an event. So I bind an event to the container for the .message elements which only fires if a click event is triggered within one of those delegated elements.

$('.container').on('click', '.message a:not([href^="'+url+'"])', function(e){
Provided that the .container is static and not removed and reinserted then I bind the click event to that element which only triggers when a .message a element is clicked. If the .container is not static and is removed or destroyed, then you can bind the event listener to the document, but as all the click events would then need to propagate up the DOM tree it takes more resources, so it's much more efficient to bind the click event as close to the inserted elements as possible.

$(document).on('click', '.message a:not([href^="'+url+'"])', function(e){


You can read more about jQuery's on method on their site here


Feel free to take a look at my code. I learned a lot by studying other's codes to see the 

Sounds good. I just determined when the ajax was from the shoutbox and looked at all the properties of such request. You way sounds better.

[adminabp]

The plugin is mistaking my forum's 'SPOILER: Click to show/Click to hide' link as an external link.

abetterplace.boards.net/post/3664

The actual link is:

javascript:void(0);
Could you make it so it ignores JavaScript links like that?

[P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓]

May 9, 2015 19:00:02 GMT -8 adminabp said:

The plugin is mistaking my forum's 'SPOILER: Click to show/Click to hide' link as an external link.

abetterplace.boards.net/post/3664

The actual link is:

javascript:void(0);
Could you make it so it ignores JavaScript links like that?

Anything that would potentially navigate away, Javascript has that potential. The real question is what the function void actually does that makes the page think you are navigating away. a general 
[spoiler]Text[/spoiler]Will do that on all forums. This is a bug you have found and I'm sure a fix will be presented here soon.

[Quozzo]

May 9, 2015 19:00:02 GMT -8 adminabp said:

The plugin is mistaking my forum's 'SPOILER: Click to show/Click to hide' link as an external link.

abetterplace.boards.net/post/3664

The actual link is:

javascript:void(0);
Could you make it so it ignores JavaScript links like that?

Sure can. I'll post the update on here soon. It will also include an option to whitelist certain trusted links.

[Matt]

Hello, I have the plugin where you can type in a confirmation that warns members when they click on a link that leads outside of the forum, This plugin works as expected. however it is bringing up the external link confirmation when posting to my Forum's shoutbox, When i click submit it says i will be taken to an external link, which makes no sense, but that is what it is doing.

This also occurs when deleting a post from the shoutbox or clicking on the ban member button in the shoutbox.

this occurs on my forum at gameslounge.proboards.com if you need the link.
I have disabled the plugin for now but would like to enable it again if this could get fixed, thanks.

Quozzo

[Matt]

Hello I am still having this issue Quozzo
Just tagging you again in case you missed my post.

[Former Member]

Just to let you know, the external link confirmation comes up when you click on a notification in your profile too, which is not needed as you are still on your own site!

[Quozzo]

Hi @1mako (and a belated hi to Matt). The plugin has been updated to fix the notification issue (v1.1.1) Thanks. It was updated a while back with the fixes Matt mentioned a while back, I just never posted a response here.

[Former Member]

Thanks Quozzo!