Simple Tag not working correctly on theme

[viego]

FORUM LINK

Hello hello! I'm not sure whether to post in plugin or theme or support but it seems theme related because it works on our other theme just fine. this is v1. I'm using v2 but they work pretty much the same. The theme is currently private on our board because I'm trying to get out the issues first. If I need to link the theme, or open it up to public let me know!

Simple Tag plugin.
Usually, you click once on the button and you get all the tags that fall under the specific tag (all staff members for the staff tag) but on this theme, it's acting oddly. I know it's not that big of a deal if you know you have to click twice instead but it's not the way it works on our other theme, where its just 1 click and tada.

1 click only gives a ',' and none of the tags. Click 2 times on the tag and you get the tags as intended. Below a visual example ^^,



Thanks in advance!

[Scott]

viego - I'm not seeing the Simple Tag plugin installed on the forum.

[viego]

Sorry! I've made it default on our forum for now so it can be figured out

[Chris]

The latest version is 1.0.6, and I see you are running 1.0.5. I am, however, dubious if updating will fix that issue since the issue was mentioned in the support thread on Jan 2017^[1] and v1.0.6 was uploaded in Jul 2014. There could be a slight chance that the user reporting that problem was also using an outdated version, so obtaining the latest version is always the first step since newer versions often fix bugs in older versions.

I will note that the v1.0.5 of the plugin is looking for a div with a class of author in order to harvest names from the posting page. I could not, however, find a thread that allowed guest replies in order to investigate the double-click issue as well as see the classes in the summary (which I mentioned must be classed as div.author for the v1.0.5 plugin to pick it up and add the names to the "all" button correctly). I saw no double-click issue when creating a new thread.

[Scott]

Chris - I'm running v1.0.6 on my test forum and it's definitely something in the layout templates just haven't narrowed it down yet.

fwiw - one by one I was resetting to default each template and it resolved when the Post List template was reset, however resetting that template by itself did not fix the issue, so it's something in that template combined with one or more templates. Just haven't gotten there yet, lol.

[viego]

Chris Scott ah, I will at least update it to the latest version, but as said it probably won't help haha
The plugin says 1.0.6 but I'll reinstall anyway haha

A member has noted that the plugin also doesn't show if anyone has participated in the thread already, which usually makes them available to be clicked as well. This should be guest friendly. thanks for looking along.

Sorry for the issue, I hope it's easy to fix >_<

[Chris]

EDIT:

I finally duplicated the issue and identified the culprit as the jQuery tooltip styler (https://static.tumblr.com/iuw14ew/VSQma1786/jquery.style-my-tooltips.js).

The tooltip styler empties the title attribute when you hover over the button, so it can replace it with its styled tooltip and then replaces it once the hover is done. The problem is that the tagging plugin collects those tags on page load and stores them in the title attribute of the buttons, so when you click the button, it reads the title and places it in the typing area. That obviously cannot happen if the styler temporarily empties the title attribute.

---

Mar 13, 2023 16:44:00 GMT -8 viego said:

Chris Scott ah, I will at least update it to the latest version, but as said it probably won't help haha
The plugin says 1.0.6 but I'll reinstall anyway haha

My bad, the comment in the JavaScript file says v1.0.5 but the plugin metadata says v1.0.6

SPOILER: Click to show

Mar 13, 2023 16:44:00 GMT -8 viego said:

A member has noted that the plugin also doesn't show if anyone has participated in the thread already, which usually makes them available to be clicked as well. This should be guest friendly. thanks for looking along.

Sorry for the issue, I hope it's easy to fix >_<

My previous post about only being able to CREATE a thread but not REPLY to an existing thread goes to the heart of that thread participation observation. We already know the punishment theme omits the .left-panel class so name harvesting on a quick reply page would not work since the plugin would not be able to identify mini-profiles on the page without that class^[1].

Since I could not REPLY to a thread, I could not view a thread summary to ascertain if the harvesting of names still worked in the punishment theme on a full reply page to populate names for the "all" button. Also, note that the thread summary contains only users available from the page where the reply was created, and not all participated users in the thread should that thread span multiple pages.

I am still, however, unable to duplicate this first-click-gives-only-a-comma behavior on several browsers. Perhaps this only happens on replies to threads and not in thread creations?

SPOILER: Click to show

[viego]

Chris here is a board open to testing and posting, creating, replying and whatever else you hopefully need haha. hope that helps. I've created some posts as a guest and one on an account so now you should be able to reply too ^^

So, in order to go forward and make things work it'd probably require removing the tooltip thing?? I mean it's not really a necessity anyway

I'm trying to string everything together to make sense but I'm a little lost now haha

edit
would replacing the mini profile layout with a template that does have a left panel be able to fix some of those issues?

edit
I've asked some other members to try out the simple tag as well and they aren't getting the one-click-works either. double-click works. I did try on FF and Chrome, both as guest and logged, as a reply to thread and create a thread in but neither did it for me either. 

I've disabled that (https://static.tumblr.com/iuw14ew/VSQma1786/jquery.style-my-tooltips.js) with the <!-- --> and the plugin works like a charm again!

[Pebble]

Hi,
If it's a problem with the plugin I can take a look or upload an editable version.

While i'm here.... Scott, is it possible that someone at proboards could scoot through my plugins in the library and make them all editable?  Might be easier than me going through them and uploading again the editable versions.

[Scott]

Mar 15, 2023 10:56:37 GMT -8 Pebble said:

Hi,
If it's a problem with the plugin I can take a look or upload an editable version.

While i'm here.... Scott , is it possible that someone at proboards could scoot through my plugins in the library and make them all editable?  Might be easier than me going through them and uploading again the editable versions.

Unfortunately there isn't a way to for me to make them editable, you would need to upload the editable version. Sorry.  

[Chris]

Mar 15, 2023 10:54:27 GMT -8 viego said:

Chris here is a board open to testing and posting, creating, replying and whatever else you hopefully need haha. hope that helps. I've created some posts as a guest and one on an account so now you should be able to reply too ^^

So, in order to go forward and make things work it'd probably require removing the tooltip thing?? I mean it's not really a necessity anyway

I'm trying to string everything together to make sense but I'm a little lost now haha

edit
would replacing the mini profile layout with a template that does have a left panel be able to fix some of those issues?

edit
I've asked some other members to try out the simple tag as well and they aren't getting the one-click-works either. double-click works. I did try on FF and Chrome, both as guest and logged, as a reply to thread and create a thread in but neither did it for me either. 

I've disabled that (https://static.tumblr.com/iuw14ew/VSQma1786/jquery.style-my-tooltips.js) with the <!-- --> and the plugin works like a charm again!

Thanks for paving the runway!

I take it you are considering this resolved from that last edit regarding the styled tooltips JavaScript file.

I will, however, warn that you probably still cannot collect participated users from the thread into the quick reply due to the missing left-panel class in that theme. The plugin is looking for that left-panel class in order to identify mini-profiles and harvest author names from them. A quick fix might be to edit the post layout and add that class next to the punishment-mini-block class to get that part working but I cannot speak to any unintended effects adding that class back could bring until you've tested it across several pages and routes.

SPOILER: Click to show

Pebble , I would suggest switching from using the title attribute for data storage to perhaps a data-users attribute or, even better, a closure-protected variable to practice defensive coding. I know I've read best practices in the past advising it is OK if on an element such as this button that you've created yourself but not in this situation. Switching from left-panel to the more ubiquitous mini-profile (which this theme does use) could also help expand compatibility.

[viego]

EDIT 2!
A friend has managed to get the simple tag to work for us! thanks for the help <3



Chris Oh you're right haha! It's partially working. Works like a beautiful charm on regular reply but not the quick reply. Back to tinkering and see what happens haha

EDIT 1
Adding the left panel class next to the punishment block worked!