PHP: Specific Areas for each person

[Bennett 🚀]

I found a tut. on youtube for an image upload site.. and so far it is working fine

[Bennett 🚀]

Okay, now I need beta testers/code checkers.. Right now, I am stuck with and error. It's on line 38:
Parse error: syntax error, unexpected T_STRING, expecting ',' or ';' in /home/a9263330/public_html/login.php on line 38

<?php
session_start();
require("connect.php");

$post_username = $_POST['username'];
$post_password = $_POST['password'];

if($post_username&&$post_password)
{

if(strlen($post_username)>25 || strlen($post_password)>15)
die("Username and password are too long. Try again.");
}
else
{
//convert password to md5
$post_password = md5($post_password);

//query the db
$login = sprintf("SELECT * FROM users WHERE username='%s' AND password='%s'", mysql_real_escape_string($post_username), mysql_real_escape_string($post_password));

$rowcount = mysql_num_rows(mysql_query($login));
$fieldarray = mysql_fetch_assoc(mysql_query($login));

$id = $filedarray['id'];
echo $id;

if($rowcount == 1)
{
//log the user in
$_SESSION['user']=$post_username;
$_SESSION['id']=$id;
echo $_SESSION['user'].", you have been logged in! <a href='index.php'>Return to the main page.</a>;
}
else
{
die("Incorrect login information. Try again.");
}
}
else
{
die("Username and Password were not entered. Try again.");
}
?>

This is stumping me.. I looked over the line, and there is no error whatsoever, that I can see, however.

If you want to be a beta tester, you will have to wait like a day.. till i get the registration and such done.

[ŠΗäMΘηΘ]

echo $_SESSION['user'].", you have been logged in! <a href='index.php'>Return to the main page.</a>;

On that line you are missing the double quote at the end.
Also I would try some indentation, makes it much easier to read. Here try this out. I just did it real quick so hopefully its oaky.

<?php
session_start();
require("connect.php");
$post_username = $_POST['username'];
$post_password = $_POST['password'];
if($post_username&&$post_password){
if(strlen($post_username) > 25 || strlen($post_password) > 15)
die("Username and password are too long. Try again.");
}else{
//convert password to md5
$post_password = md5($post_password);
//query the db
$login = sprintf("SELECT * FROM users WHERE username='%s' AND password='%s'", mysql_real_escape_string($post_username), mysql_real_escape_string($post_password));
$rowcount = mysql_num_rows(mysql_query($login));
$fieldarray = mysql_fetch_assoc(mysql_query($login));
$id = $filedarray['id'];
echo $id;
if($rowcount == 1){
//log the user in
$_SESSION['user']=$post_username;
$_SESSION['id']=$id;
echo $_SESSION['user'].", you have been logged in! <a href='index.php'>Return to the main page.</a>;
}else{
die("Incorrect login information. Try again.");
}
}else{
die("Username and Password were not entered. Try again.");
}
?>

[Bennett 🚀]

I had it indented, though, proboards likes to un-indent things. And thanks, lol, small stuff like that mess me up.

EDIT: Still doesn't work.. imagepro.net84.net/ login with guest and password.

[ŠΗäMΘηΘ]

ahh, I see. and no problem.

[Bennett 🚀]

Parse error: syntax error, unexpected T_STRING, expecting ',' or ';' in /home/a9263330/public_html/login.php on line 24

New error message

[ŠΗäMΘηΘ]

<?php
session_start();
$post_username = $_POST['username'];
$post_password = $_POST['password'];
if($post_username&&$post_password){
if(strlen($post_username) > 25 || strlen($post_password) > 15){
die("Username and password are too long. Try again.");
}else{
//convert password to md5
$post_password = md5($post_password);
//query the db
$login = sprintf("SELECT * FROM users WHERE username='%s' AND password='%s'", mysql_real_escape_string($post_username), mysql_real_escape_string($post_password));
$rowcount = mysql_num_rows(mysql_query($login));
$fieldarray = mysql_fetch_assoc(mysql_query($login));
$id = $filedarray['id'];
echo $id;
if($rowcount == 1){
//log the user in
$_SESSION['user']=$post_username;
$_SESSION['id']=$id;
echo $_SESSION['user'].", you have been logged in! <a href='index.php'>Return to the main page.</a>";
}else{
die("Incorrect login information. Try again.");
}
}
}else{
die("Username and Password were not entered. Try again.");
}
?>

Looking over it again I see I missed a few more things. Try this now.

[Charles Stover]

iChristmas, use a code editor that color-codes programs. EditPlus, for example, will color-code strings and thus make it easy to spot unescaped strings.

[Bennett 🚀]

Okay, I'll try that! I have Notepad++ but it doesn't help much..

EDIT: Is there a free alternative?

[ŠΗäMΘηΘ]

(ha terrible quality. )

Notepad++ should do this. Take a look at the screenshot. The second block is missing its ending quote and thus everything after it changes color.

EDIT: not sure but I think you can turn this off too, check the settings and make sure its turned on.

[Bennett 🚀]

Oh, that's on.. I just don't see small stuff like that..

[ŠΗäMΘηΘ]

Perhaps that's a skill that you can build on then. Saves a lot of headache later on.

[Chris]

Nov 29, 2009 15:57:02 GMT -8 ŠΗäMΘηΘ said:

Perhaps that's a skill that you can build on then. Saves a lot of headache later on.

OR he could customize the colors to have a more noticeable difference. One of the two.

[ŠΗäMΘηΘ]

Nov 29, 2009 17:08:47 GMT -8 Chris said:

Nov 29, 2009 15:57:02 GMT -8 ŠΗäMΘηΘ said:

Perhaps that's a skill that you can build on then. Saves a lot of headache later on.

OR he could customize the colors to have a more noticeable difference. One of the two.

ah, neat. Didn't realize you could do that. Thanks.

[Bennett 🚀]

Where do you do that?