inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,017
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Aug 25, 2010 19:53:33 GMT -8
The code that needs fixing is the code that puts the blog entries into a marquee. The code that removes the blog still works fine without your "fix".
<script> if (location.href.match(/ion=(admin|headersfooters3)/i) && (pbBlog=document.getElementById('pb_admin_updates'))){ pbCell = pbBlog.parentNode; pbCell.parentNode.cells[0].width="33%"; pbCell.parentNode.cells[1].width="34%"; pbCell.parentNode.cells[2].width="33%"; pbRow = pbCell.parentNode.parentNode.insertRow(-1); pbRow.appendChild(pbCell); pbCell.colSpan=3; pbCell.appendChild(document.createElement('span')); pbCell.lastChild.innerHTML += '<marquee id="pbaablog" behavior="alternate" width="99%" class="windowbg2" style="padding: 5px;background-color: transparent;" onMouseOver = "this.stop()" onmouseout="this.start()"></marquee>'; for(y=0;y<pbBlog.childNodes.length;y++){ if(!/(#text|BR)/i.test(pbBlog.childNodes[y].nodeName)){ pbCell.lastChild.lastChild.appendChild(document.createTextNode('[')); pbCell.lastChild.lastChild.appendChild(pbBlog.childNodes[y]); pbCell.lastChild.lastChild.appendChild(document.createTextNode(']')); pbCell.lastChild.lastChild.appendChild(document.createTextNode('\xa0')); } } pbBlog.style.display="none"; if((x=pbCell.getElementsByTagName('center')) && x[0]){ for(y=0;y<x.length;y++){ for(z=x[y].childNodes.length-1;z>-1;z--){ if(x[y].childNodes[z].nodeName!="BR") x[y].parentNode.insertBefore(x[y].childNodes[z],x[y]); } x[y].style.display="none"; } } }
</script>
Edit: Proboards has once again changed the admin panel, the forum promotion has been moved from the last cell to the third and "Proboards Blog" section has been changed to simply "Proboards". This requires a change to the patch that removes the blog.
<script> (function(){ /* Patch - Remove ProBoards Blog from Admin Panel */ /* Top of Main Footer [9/1/2010]*/ var pau = document.getElementById('pb_admin_updates'); if(pau){ pau=pau.offsetParent.parentNode; pau.cells[0].width = "33%"; pau.cells[1].width = "34%"; pau.cells[2].width = "33%"; pau.deleteCell(3); }})() </script>
|
|
inherit
The Final Cylon
31521
0
Mar 3, 2015 14:39:33 GMT -8
Trublu
Maybe the duck is in the hat.
12,323
October 2004
trublusvufan
|
Post by Trublu on Aug 27, 2010 7:14:20 GMT -8
I wasn't sure what this code did and so i put it on my test forum...well it half does something but i don't think it works properly... I get an error on this line it says "lpp.split(">on ")[1] is undefined" gtd[2].innerHTML = lpp.split(">on ")[1].split(brr)[0]+"<br />"+lpp.split(brr+"in ")[1]; I just removed it from the database; it was an older code with no description, and the coder was banned from here so they wouldn't be able to update it. Thanks for the heads up. I'm waiting on adjusting the Crossfury post until there is some sort of consensus, just in case ya'll are wondering why I have not done so, yet.
|
|
inherit
143665
wildgoosespeeder wildgoosespeeder wildgoosespeeder
0
Jun 14, 2018 5:59:55 GMT -8
wildgoosespeeder
ProBoards V5 be trippin'. I'm disoriented. :P
4,393
August 2009
wildgoosespeeder
|
Post by wildgoosespeeder on Sept 14, 2010 18:14:25 GMT -8
A while ago I ran into the Ignore Members code and noticed a few flaws with it. Members can ignore themselves and guests can ignore! Same with unignoring. Below is a fixed version of the code ( red are the fixes): <script language="javascript"> //Ignore Members v1.0 [CB] //Revised for Proboards 4.5 - Eton //Copyright 01-02-2006 ~Wonder //May be reposted anywhere as long as this header remains in tact //Place in Global Footer
//Enter the group number of member groups people cannot ignore separated with a comma. 1=admin, 2=gmod, 3=mod, 4+=custom. To find this number, in the member group pulldown menu in their profile, starting from the dotted line, count down until you hit their member group. cannotIgnore="1,2,3";
//Enter the URLs to the images you want for the ignore/unignore icons ignoreIconUrl="http://www.proboards.com/v4images/lipsrsealed.gif"; unignoreIconUrl="http://www.proboards.com/v4images/cheesy.gif";
if(location.href.match(/action=(display|goto|viewprofile|pmview|(user)?recent|calendarview)/) && pb_username != "Guest") { usersToIgnore=((document.cookie.match(/\bignore\=([^;]+)/))?RegExp.$1:""); td=document.getElementsByTagName("td"); for(i=0;i<td.length;i++) { if(td.width=="20%" && td.className.match(/windowbg/)) { a=td.getElementsByTagName("a"); if(a.length>1) { temp=a[0].href.match(/user\=/)?1:2; user=(a[temp].href.match(/user\=\w+/))[0].split("=")[1]; group=0; if(a[temp].className.match(/group(\d+)/)) { group=parseInt(RegExp.$1,10); } if(!(","+cannotIgnore+",").match(","+group+",") && pb_username != user) { if(String(","+usersToIgnore+",").match(","+user+",")) { td.getElementsByTagName("center")[0].innerHTML+='<a href=javascript:unignore("'+user+'")><img src="'+unignoreIconUrl+'" border=0 alt="[Ignored: Click to unignore]"></a>'; if(!location.href.match(/action\=viewprofile/ )) { td.nextSibling.firstChild.style.display="none"; td.nextSibling.vAlign="middle"; c=document.createElement("center" ); c.innerHTML="You have chosen to ignore "+a[temp].innerHTML+"."; td.nextSibling.insertBefore(c,td.nextSibling.firstChild); } } else { td.getElementsByTagName("center")[0].innerHTML+='<a href=javascript:ignore("'+user+'")><img src="'+ignoreIconUrl+'" border=0 alt="[Click to ignore]"></a>'; } } } } } }
function ignore(user) { document.cookie="ignore="+String(user+","+usersToIgnore).replace(/(^,)|(,$)|(,{2,})/g,"")+"; expires=Monday, 04-Apr-2025 05:00:00 GMT"; location.reload(true); } function unignore(user) { document.cookie="ignore="+(","+usersToIgnore+",").replace(","+user+",", ",").replace(/(^,+)|(,+$)|(,{2,})/g,"")+"; expires=Monday, 04-Apr-2025 05:00:00 GMT"; location.reload(true); } </script>
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,324
January 2004
todge
|
Post by Todge on Sept 16, 2010 10:50:28 GMT -8
I'm not entirely sure that's an error.. Ignoring yourself could be a problem, admittedly, but why would you? And if you are viewing a forum you may not log-in unless you intended on posting, in which case you'd still want to ignore those you chose to, rather than to log in to ignore them.
|
|
inherit
143665
wildgoosespeeder wildgoosespeeder wildgoosespeeder
0
Jun 14, 2018 5:59:55 GMT -8
wildgoosespeeder
ProBoards V5 be trippin'. I'm disoriented. :P
4,393
August 2009
wildgoosespeeder
|
Post by wildgoosespeeder on Sept 17, 2010 20:48:59 GMT -8
Well it's more of a logic error fix for ignoring yourself. The major flaw with this code is the use of cookies when the data should be stored on the site on a per user basis which ProBoards doesn't allow (to my knowledge).
|
|
inherit
King Oligochaete
126470
0
Feb 24, 2021 12:23:15 GMT -8
Wormopolis
Stop rating plugins with 1 star that dont deserve it.
20,002
June 2008
tbserialkillers
Wormo's Mini-Profile
|
Post by Wormopolis on Sept 19, 2010 22:14:57 GMT -8
if its entirely up to the user to decide on ignoring someone, then why not use THEIR storage space to hold that data?
|
|
inherit
143665
wildgoosespeeder wildgoosespeeder wildgoosespeeder
0
Jun 14, 2018 5:59:55 GMT -8
wildgoosespeeder
ProBoards V5 be trippin'. I'm disoriented. :P
4,393
August 2009
wildgoosespeeder
|
Post by wildgoosespeeder on Sept 19, 2010 22:34:46 GMT -8
What if the computer is public when accessing the site? Plus ignored users with these codes are not transfered over from one computer to another.
|
|
inherit
King Oligochaete
126470
0
Feb 24, 2021 12:23:15 GMT -8
Wormopolis
Stop rating plugins with 1 star that dont deserve it.
20,002
June 2008
tbserialkillers
Wormo's Mini-Profile
|
Post by Wormopolis on Sept 19, 2010 22:55:44 GMT -8
thats a valid point, and the code could be updated to include a username in the cookie to keep accounts seperate. the alternative is that EVERY time a user wants to ignore someone, they will ahve to contact the admin to make a new line in the code to cause an ignore (or I guess anothe roption would be to port this over to a different language and use external storage for all the data). but lets say its a REALLY busy site. and someone from a competing site comes in and starts being annoying to everyone. the next time the admin logs in, he has 50 PMs asking to have ignore(thatjerk) added to the code so that member can feel good about reading things again.
using a cookie lets the user do it on their own, and can quickly UNignore someone just as fast. if someone is moving around to different computers, then they run the risk of having to set an ignore again.
|
|
inherit
143665
wildgoosespeeder wildgoosespeeder wildgoosespeeder
0
Jun 14, 2018 5:59:55 GMT -8
wildgoosespeeder
ProBoards V5 be trippin'. I'm disoriented. :P
4,393
August 2009
wildgoosespeeder
|
Post by wildgoosespeeder on Sept 19, 2010 23:22:32 GMT -8
I didn't think about the headers/footers but yeah that is a bad place to store that kind of data. The cookie is also a bad idea due to private vs. public computers but that's the best solution due to limitations of ProBoards. The only thing to hope for now is ProBoards releasing an official ignore system.
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,017
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Sept 21, 2010 20:47:50 GMT -8
I'm in total agreement with Wonder on this one, keeping accounts separate would not be desirable. If someone annoys you enough on your first account to merit an ignore then there's no reason to assume your feeling will drastically change when you switch to a second or third. If there's some reason that you must interact with them on a second account, unignore is just a click away. Global ignore was the way to go.
|
|
inherit
King Oligochaete
126470
0
Feb 24, 2021 12:23:15 GMT -8
Wormopolis
Stop rating plugins with 1 star that dont deserve it.
20,002
June 2008
tbserialkillers
Wormo's Mini-Profile
|
Post by Wormopolis on Sept 21, 2010 21:53:45 GMT -8
I was thinking more along the lines of a shared computer at a school or library. if two entirely different people are going to the same site, it wouldnt be desirable to ignore globally.
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,017
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Sept 21, 2010 23:09:13 GMT -8
Edge case I would think and with an impact that has nothing more detrimental than having to click unignore. The vast majority would definitely be the first case..
If I remember correctly the only time I actually took time to address that scenario was with Alias since the impact was potentially the loss of login credentials.
|
|
inherit
143665
wildgoosespeeder wildgoosespeeder wildgoosespeeder
0
Jun 14, 2018 5:59:55 GMT -8
wildgoosespeeder
ProBoards V5 be trippin'. I'm disoriented. :P
4,393
August 2009
wildgoosespeeder
|
Post by wildgoosespeeder on Oct 1, 2010 20:55:25 GMT -8
|
|
inherit
141773
0
Aug 6, 2011 0:40:04 GMT -8
Klomsky
16
June 2009
klomsky
|
Post by Klomsky on Oct 8, 2010 8:19:07 GMT -8
|
|
#00AF33
Official Code Helper
19529
0
1
Nov 19, 2012 14:18:28 GMT -8
Todge
**
17,324
January 2004
todge
|
Post by Todge on Oct 8, 2010 10:33:50 GMT -8
[CB] Highlight Tags v2Highlight Tags v2 is outdated and has several flaws in execution. Below is a complete overhaul named Highlight Tags v3 that has several fixes including: Thank you. I've PM'd Code Dragon to see if it's ok for us to update his code with yours.
|
|