Code Database Updates

[Todge]

Oct 8, 2010 8:19:07 GMT -8 Klomsky said:

support.proboards.com/index.cgi?board=codedatabase&action=display&thread=256314

This code sometimes works sometimes not after the latest updates. I posted this yesterday, it started working again so I deleted the post but here I am again...

Jordan suggests PMing him if there are problems with the code.. Have you tried that?

[Chris]

Code: Alphabetical skin list
Suggested Fix: Alphabetizing Skins

[Todge]

I have updated the code in the database.. Thanks.

[tuck]

This code is totally ripped. Should have some credit where credit is due. IMO.

/**
* reflection.js v2.0
* cow.neondragon.net/stuff/reflection/
* Freely distributable under MIT-style license.
*/

If you disagree go here, 2nd paragraph and change something?

If I remotely hosted a code from here and call it mine like this...

/*
Code Name
Hosted by tuck
Do Not Repost, Rip or Claim*/

Would that be ok if I rip a code by Todge or Wormopolis and remotely host it? Not cool! IMO.

[wildgoosespeeder]

CrAzY_J's Different On/Off Icons Code

I noticed several problems with this code. The problems tackled in the code below is color-coded for an explanation.

First problem is this code could apply an on/off image more than once if the board id is like "board" and "board1" or something.

Another problem is detecting new posts or no new posts. It does so by checking if the image url contains the text "on" or "off" followed by a common extension. One problem, that assuming you never change the board icon in your skin.

Another problem is that there is no need to recreate the image tag because it already exists.

Another problem is the number of times the code in the switchy function executes. The function doesn't terminate once the on/off image has been applied.

The last problem is this code can work for sub-board icons. Applying it to the Global Footer works but at a cost.

I propose the following fix:

Code removed to coincide with CrAzY_J's wishes

[Wormopolis]

Nov 15, 2010 13:29:52 GMT -8 @tuck said:

This code is totally ripped. Should have some credit where credit is due. IMO.

/**
* reflection.js v2.0
* cow.neondragon.net/stuff/reflection/
* Freely distributable under MIT-style license.
*/

If you disagree go here, 2nd paragraph and change something?

If I remotely hosted a code from here and call it mine like this...

/*
Code Name
Hosted by tuck
Do Not Repost, Rip or Claim*/

Would that be ok if I rip a code by Todge or Wormopolis and remotely host it? Not cool! IMO.

The moderators and staff discussed this code at length. The license states that the reflection code can be used within other codes as long as the license stays attached to it. The wrapping code itself CAN be held under a different set of rules however. which means that Wrighty CAN put it inside his own implementation and state that HIS code itself cannot be reclaimed, but he doesn't own the reflection engine itself. anyone else could utilize that same engine in their own code without any repercussion.

that being said, the code is being removed from the database per admin instruction because it is a remotely hosted code and goes against the new rule of no remotely hosted codes being allowed.

this doesn't mean you cant use it, it just means that PBS will not allow it to be part of its own database. Chris or Wrighty can still choose to have it part of whatever other databases they wish.

[Todge]

Nov 17, 2010 12:50:35 GMT -8 wildgoosespeeder said:

CrAzY_J's Different On/Off Icons Code

I noticed several problems with this code. The problems tackled in the code below is color-coded for an explanation.

First problem is this code could apply an on/off image more than once if the board id is like "board" and "board1" or something.

Another problem is detecting new posts or no new posts. It does so by checking if the image url contains the text "on" or "off" followed by a common extension. One problem, that assuming you never change the board icon in your skin.

Another problem is that there is no need to recreate the image tag because it already exists.

Another problem is the number of times the code in the switchy function executes. The function doesn't terminate once the on/off image has been applied.

The last problem is this code can work for sub-board icons. Applying it to the Global Footer works but at a cost.

I propose the following fix:

Code removed to coincide with CrAzY_J's wishes

I have removed the code from your post as CrAzY_J has asked for it not to be redistributed..

/*different on/off icons
created by naruto|recoded by CrAzY_J
Do not redistribute without permission of creator*/

The last three items you mentioned are not 'problems', just a different way of coding and would not resolve any issues the code may have, so I have not included those changes, but I have added the first two fixes that you suggested to the code in the database.

Thank you.

[tuck]

Nov 17, 2010 18:53:52 GMT -8 Wormopolis said:

Nov 15, 2010 13:29:52 GMT -8 @tuck said:

This code is totally ripped. Should have some credit where credit is due. IMO.

/**
* reflection.js v2.0
* cow.neondragon.net/stuff/reflection/
* Freely distributable under MIT-style license.
*/

If you disagree go here, 2nd paragraph and change something?

If I remotely hosted a code from here and call it mine like this...

/*
Code Name
Hosted by tuck
Do Not Repost, Rip or Claim*/

Would that be ok if I rip a code by Todge or Wormopolis and remotely host it? Not cool! IMO.

The moderators and staff discussed this code at length. The license states that the reflection code can be used within other codes as long as the license stays attached to it. The wrapping code itself CAN be held under a different set of rules however. which means that Wrighty CAN put it inside his own implementation and state that HIS code itself cannot be reclaimed, but he doesn't own the reflection engine itself. anyone else could utilize that same engine in their own code without any repercussion.

that being said, the code is being removed from the database per admin instruction because it is a remotely hosted code and goes against the new rule of no remotely hosted codes being allowed.

this doesn't mean you cant use it, it just means that PBS will not allow it to be part of its own database. Chris or Wrighty can still choose to have it part of whatever other databases they wish.

Thanks for the clarification.

[wildgoosespeeder]

Nov 18, 2010 11:51:38 GMT -8 Todge said:

Nov 17, 2010 12:50:35 GMT -8 wildgoosespeeder said:

CrAzY_J's Different On/Off Icons Code

I noticed several problems with this code. The problems tackled in the code below is color-coded for an explanation.

First problem is this code could apply an on/off image more than once if the board id is like "board" and "board1" or something.

Another problem is detecting new posts or no new posts. It does so by checking if the image url contains the text "on" or "off" followed by a common extension. One problem, that assuming you never change the board icon in your skin.

Another problem is that there is no need to recreate the image tag because it already exists.

Another problem is the number of times the code in the switchy function executes. The function doesn't terminate once the on/off image has been applied.

The last problem is this code can work for sub-board icons. Applying it to the Global Footer works but at a cost.

I propose the following fix:

Code removed to coincide with CrAzY_J's wishes

I have removed the code from your post as CrAzY_J has asked for it not to be redistributed..

/*different on/off icons
created by naruto|recoded by CrAzY_J
Do not redistribute without permission of creator*/

The last three items you mentioned are not 'problems', just a different way of coding and would not resolve any issues the code may have, so I have not included those changes, but I have added the first two fixes that you suggested to the code in the database.

Well how else was I going to get my message across as clear as possible? I know, the suggestion was accepted and that's what counts.

The third suggestion was to avoid one of two things that could happen, either CrAzY_J's code or my Board Icon Alt/Title Fix code would execute depending on which executes first (notice how each code works in terms of detecting new posts or no new posts). Just trying to avoid conflicting codes.

The fourth suggestion was just for a speed boost because after the image has been applied, it still scans other boards for the id which will never be true which is a waste of execution time.

[Todge]

Yeah, I could see why you made the changes, but as neither fixed a problem, I thought it best to change the code as little as possible.

Crazy has not asked that his code not be altered, but I'd still rather change only what was necessary.

[wildgoosespeeder]

OK, let's look at it this way. Short term, no problems but in the long term, let's just say some people take both CrAzY_J's code in it's current state and my code. They all wonder why one code works and not the other. They come to support all asking the same thing "why won't these codes work together?" Even more people after that do what the previous people did. The cycle just keeps on going. This problem could be avoided by taking my suggestion. Also you could always add an alt attribute to CrAzY_J's code.

As for the shorter execution time, let's take my forum. I found out that there are 133 TD tags active on the homepage. Other forums could have less, or more. I call "switchy" 19 times on my forum. CrAzY_J's code in it's current state would execute the same related TD tag statements 2,527 times! That break statement will easily trim that number to just around 1,000 times give or take (haven't actually counted).

I guess if I still haven't persuaded you I should just PM CrAzY_J. Is he still around?

[Chris]

I talked with CJ on MSN:

Joeri:
12:39:25 AM bah i tried remembering my password but can't
12:39:35 AM they can do w/e


So, he can't login to confirm, but he doesn't care.

[Wormopolis]

In the interest of streamlining Crazy-J's code so that it doesnt cause future problems by stripping the alt tag that MORE then just WGS's code uses, I agree adding in an alt attribute would be beneficial, as well as the loop break to help cut down on processing speed.

But I only voice this on the happenstance that CJ already gave his "consent". Otherwise I would be in total agreement with Todge.

Jordan/Candy/Trublu? do you have any thoughts?

[wildgoosespeeder]

Nov 20, 2010 22:21:20 GMT -8 Wormopolis said:

I agree adding in an alt attribute would be beneficial, as well as the loop break to help cut down on processing speed.

Well we don't even have to "reinvent the wheel".

TD[t].getElementsByTagName("img")[0].src = on;
TD[t].getElementsByTagName("img")[0].src = off;

or

TD[t].firstChild.src = on;
TD[t].firstChild.src = off;

Would work (not sure about firstChild because there could be more tag elements) instead of:

TD.item(t).innerHTML="<img src='"+on+"'>";
TD.item(t).innerHTML="<img src='"+off+"'>";

[Chris]

Do the first src change. Simple enough and using getElementsByTagName vs firstChild is an insignificant speed change if, given 133 boards, it is ran only 133 times.