Spoiler Tags (1.5.1)

[bleachstaff]

Our site has used this plugin for years to title our Spoilers. To my knowledge there isn't a single other plugin in the library that allows for that. This morning, all of a sudden, spoilers won't open up but only if they are using this plugin. Had to delete it out of the system in order to get them to actually open. Any ideas what could have changed?

[Todge]

Very strange.. Something must have changed with the page make-up.

Best we leave it for a day or so to see if it's an error that will be corrected. If it still doesn't work over the weekend I'll look to see if I can find out what has happened.

[svperstar]

Feb 23, 2018 10:56:33 GMT -8 Todge said:

Very strange.. Something must have changed with the page make-up.

Best we leave it for a day or so to see if it's an error that will be corrected. If it still doesn't work over the weekend I'll look to see if I can find out what has happened.

I just noticed this on my forum. It seems like the code changes when you hit save or edit vs. the preview. 

[sam8432]

Feb 23, 2018 0:51:38 GMT -8 bleachstaff said:

Our site has used this plugin for years to title our Spoilers. To my knowledge there isn't a single other plugin in the library that allows for that. This morning, all of a sudden, spoilers won't open up but only if they are using this plugin. Had to delete it out of the system in order to get them to actually open. Any ideas what could have changed?

My forum has had that issue as well. If your users want to view spoilers while the plugin is enabled, they can quote the post and go into BBCode mode.

[Prince of Wonderland]

Feb 23, 2018 10:56:33 GMT -8 Todge said:

Very strange.. Something must have changed with the page make-up.

Best we leave it for a day or so to see if it's an error that will be corrected. If it still doesn't work over the weekend I'll look to see if I can find out what has happened.

I hate to just add to the pile, but I've been using it for my site for a few years as well and it stopped working at the same time a few days ago and it hasn't started working. Our site is operating on the 1.4.3 version if that changes anything? They all work on the Mobile version of the site, but on a computer, or switching to desktop mode they all stop.

I know you said to ride it out through the weekend, just adding information that I found if it helps any?

[Former Member]

The advice on this thread instructs the admins to update the plugin to its latest version, but it doesn't seem to have worked for our forum.

[sam8432]

Feb 25, 2018 3:34:48 GMT -8 @therangeplace said:

The advice on this thread instructs the admins to update the plugin to its latest version, but it doesn't seem to have worked for our forum.

Yup! The newest update is from December 29, 2016. My forum installed it in early 2017 and still has the issue.

[Chris]

There is apparently a recent change to how spoilers are handled in the preview tab because prior to that change spoilers were simply ignored in preview and you would see the entire thing as if there was no spoiler wrapping it at all. It now appears Proboards is adding a style="display:none" (and a random id attribute) to the spoiler tag on the preview tab so you can no longer see the spoiler, and more importantly can no longer EDIT THE SPOILER on the preview tab in a place where you are suppose to make edits. My guess is this is some kind of unfinished idea meant to render spoilers the same way you would see them in posts but the javascript anchor portion necessary to expand/collapse that spoiler was somehow overlooked or rejected (by XSS Auditor?)  so it was just left hidden and effectively uneditable being you cannot see it without your magic inspector gadget glasses.

The act of adding display:none to the spoiler tag also appears to be destructive since it overwrites any other attributes written to the tag which I believe is how Todge's spoiler plugin operates. I used to be able to add a title attribute to a spoiler for example but now that is overwritten whenever you switch between bbcode and preview. 

[Todge]

Thanks Chris, that explains the sudden failure.

sam8432, @therangeplace, Prince of Wonderland, svperstar, bleachstaff and to anyone else that this is effecting...

Can you please try version 1.4.7

This should force the spoilers to work.

This plugin, along with most of the rest will have to be pretty much re-written when V6 comes along, so I won't make any drastic changes until then, but hopefully this is all that needs to be done.

[Prince of Wonderland]

Feb 25, 2018 15:22:33 GMT -8 Todge said:

Thanks Chris , that explains the sudden failure.

sam8432 , @therangeplace , Prince of Wonderland , svperstar , bleachstaff and to anyone else that this is effecting...

Can you please try version 1.4.7

This should force the spoilers to work.

This plugin, along with most of the rest will have to be pretty much re-written when V6 comes along, so I won't make any drastic changes until then, but hopefully this is all that needs to be done.

I updated to 1.4.7 and that fixed the problem for my site. Thank you for getting back to me so quickly!

[bleachstaff]

Thanks, it's working perfectly!

[Former Member]

Version 1.4.7 is indeed working, thank you!

[Matej]

Feb 25, 2018 12:39:23 GMT -8 Chris said:

There is apparently a recent change to how spoilers are handled in the preview tab because prior to that change spoilers were simply ignored in preview and you would see the entire thing as if there was no spoiler wrapping it at all. It now appears Proboards is adding a style="display:none" (and a random id attribute) to the spoiler tag on the preview tab so you can no longer see the spoiler, and more importantly can no longer EDIT THE SPOILER on the preview tab in a place where you are suppose to make edits. My guess is this is some kind of unfinished idea meant to render spoilers the same way you would see them in posts but the javascript anchor portion necessary to expand/collapse that spoiler was somehow overlooked or rejected (by XSS Auditor?)  so it was just left hidden and effectively uneditable being you cannot see it without your magic inspector gadget glasses.

The act of adding display:none to the spoiler tag also appears to be destructive since it overwrites any other attributes written to the tag which I believe is how Todge's spoiler plugin operates. I used to be able to add a title attribute to a spoiler for example but now that is overwritten whenever you switch between bbcode and preview. 

This will be reverted very soon. Sorry about the issues, it was not supposed to affect v5 at all.

[Philip]

Feb 26, 2018 16:22:05 GMT -8 Matej said:

This will be reverted very soon. Sorry about the issues, it was not supposed to affect v5 at all.

Pushing V6 code into V5? That's a little worrying, ie both code bases on the same platform.
This will no doubt cause alot of issue's, unless you guys are still using jQuery Widgets(which is even more worrying)

There is no way to run unit/intergration/e2e test's on the v6 platform, that would be compatible with v5, which makes me wonder why v5 will still be supported for a further 18mths after v6 launches.

Are you guys looking @ the grid for layouts or still sticking with flex? I wrote some LESS generators for less grid/layout and it still seems like alot of code.

An excerpt of a grid generator I was working on for V5 themes.

Even this sort of stuff is way more complicated that just committing to the CSS grid.

.GenerateColumns(@size: small, @n: 12, @i: 1) when(@i =< @n) {
   .grid-x>.@{size}-@{i} {
       width: ( @i * 100% / @n);
   }
   .GenerateColumns(@size, @n, (@i + 1));
}

.GenerateCell(@size: small, @n: 8, @i: 1) when(@i =< @n) {
   .@{size}-up-@{i}>.cell {
       width: ( @i * 100%);
   }
   .GenerateCell(@size, @n, (@i + 1));
}

[Matej]

Feb 26, 2018 17:00:28 GMT -8 Philip said:

Feb 26, 2018 16:22:05 GMT -8 Matej said:

This will be reverted very soon. Sorry about the issues, it was not supposed to affect v5 at all.

Pushing V6 code into V5? That's a little worrying, ie both code bases on the same platform.
This will no doubt cause alot of issue's, unless you guys are still using jQuery Widgets(which is even more worrying)

There is no way to run unit/intergration/e2e test's on the v6 platform, that would be compatible with v5, which makes me wonder why v5 will still be supported for a further 18mths after v6 launches.

Are you guys looking @ the grid for layouts or still sticking with flex? I wrote some LESS generators for less grid/layout and it still seems like alot of code.

An excerpt of a grid generator I was working on for V5 themes.

Even this sort of stuff is way more complicated that just committing to the CSS grid.

.GenerateColumns(@size: small, @n: 12, @i: 1) when(@i =< @n) {
 .grid-x>.@{size}-@{i} {
 width: ( @i * 100% / @n);
 }
 .GenerateColumns(@size, @n, (@i + 1));
}

.GenerateCell(@size: small, @n: 8, @i: 1) when(@i =< @n) {
 .@{size}-up-@{i}>.cell {
 width: ( @i * 100%);
 }
 .GenerateCell(@size, @n, (@i + 1));
}

I can't discuss anything beyond what I said.

This is a thread for a plugin. Let's keep it to the topic at hand.