"+name+" value not working

[Perseus]

I don't personally know this code and I only understand JavaScript to a certain degree, it's from a layout I'm interested in using although I'm not very happy that it fails to display the username of the member on the text menu.

This is the following code I pulled that sort of redesigns the menu's appearance. It divides the CPs and the rest like Members, Home, Search, etc into two different sets. One aligned to the left and the other aligned to the right.

But for some reason the "+name+" value is failing to work, I'm hoping that someone here could be able to see what I don't and get it to work. It's making me absolutely livid, logged in you can see the 'Welcome' no problem but the Username is not there.
As a Guest, you can see the 'Welcome Guest' no problem. So I don't understand why this isn't working, I have looked everywhere but I do not think I have a code on the board that cancels it out.

Can anyone give me a helping hand?


<script type="text/Javascript">
<!--


//Copyright All Rights Reserved to Nate
//This header must stay intact
//Do not repost without my permission
var TD = document.getElementsByTagName('TD');
if(TD[2].innerHTML.match(/welcome/i))
{
TD[5].innerHTML = "<table width='100%'><tr><td align='left'>Welcome Guest (<a href='index.cgi?action=login'>Login</a>|<a href='index.cgi?action=register'>Register</a>)</td><td align='right'>[<a href='index.cgi?'>Home</a>] [<a href='http://help.proboards.com'>Help</a>] [<a href='index.cgi?action=search'>Search</a>]</td></tr></table>";
}
if(TD[2].innerHTML.match(/hey, (.+?),/i) && TD[5].innerHTML.match(/=admin/i))
{
var name = RegExp.$1;
TD[5].innerHTML = "<table width='100%'><tr><td align='left'>Welcome "+name+"(<a href='index.cgi?action=viewprofile'> User CP </a>|<a href='index.cgi?action=admin'> Admin CP </a>)</td><td align='right'>[<a href='index.cgi?'>Home</a>] [<a href='http://help.proboards.com'>Help</a>] [<a href='index.cgi?action=search'>Search</a>] [<a href='index.cgi?action=calendar'>Calendar</a>] [<a href='index.cgi?action=members'>Members</a>] [<a href='index.cgi?action=logout'>Logout</a>]</td></tr></table>";
}
if(TD[2].innerHTML.match(/hey,s(.+?),s/i) && !TD[5].innerHTML.match(/admin/i))
{
var name = RegExp.$1;
TD[5].innerHTML = "<table width='100%'><tr><td align='left'>(<a href='index.cgi?action=viewprofile'> User CP </a>)</td><td align='right'>[<a href='index.cgi?'>Home</a>] [<a href='http://help.proboards.com'>Help</a>] [<a href='index.cgi?action=search'>Search</a>] [<a href='index.cgi?action=calendar'>Calendar</a>] [<a href='index.cgi?action=members'>Members</a>] [<a href='index.cgi?action=logout'>Logout</a>]</td></tr></table>";
}


//-->
</script>

[Chris]

this line
if(TD[2].innerHTML.match(/hey, (.+?),/i) && TD[5].innerHTML.match(/=admin/i))
try changing to
if (TD[5].innerHTML.match(/=admin/i) && TD[2].innerHTML.match(/hey,(.+?),/i)) {

It didn't used to be this way but it looks like some browsers are resetting captures now. This used to be a source of mysterious bugs in scripts where a failed match or a match with no capture would leave an unrelated previous capture value intact and accessible. This led to bugs in scripts most notably the "random character at end of post" bug in the v4 dice script. Now it appears that a new regex erases the results of the previous at least in the latest Firefox version (needs more research...).

[Perseus]

Perfect, thank you.
But it seems that the code doesn't work for the normal member?

I followed suit and did what you had done to the top half for the admin, logged onto a member account and the whole code for the Member account didn't work. It goes back to the basic proboards preset for the text menu.

I hadn't edited it before this, but do I need to give it a different var name?
or change the 'admin' in the code to 'member'?

I'm wondering if I would need to do this for every class/group on the board.

[Chris]

the other line would indeed get the same treatment and if you notice it tests for the negative (logged in but not able to see admin menu button) which would mean a regular member. The problem there however is although it saves the capture to a variable of "name" it never makes use of that variable for members like it does for staff. The code, wherever you got it has most likely been edited to not show member names only staff, just add it back at the location you want it to show