Broken Controls on Thread list

[katya]

I heavily rearranged the Thread list template, and I seem to have broken the Selection Menu, Action Menu, Search, and probably the Pagination too. All of them still work on my Thread/Post list template (I assume because that was more of a heavy restyle rather than a rearrange), but they won't on the board pages. I figure I broke everything(tm) by moving stuff around and losing whatever necessary classes/IDs that v5 requires for the menus and etc to work. I tried mimicking the default template though, and I couldn't fix it on my own. :c

See here. More details:

Select gives me all the usual options, but picking any of them doesn't do anything.

Action only gives me Mark Board As Read, and it doesn't work. Moderation and other options don't show up.

Search sort of works. I can input something and search it, but the thread list itself doesn't update. My url does though, and if I refresh q=blah url, my thread list will update with the search results.

And I haven't actually tested Pagination, but if it's broken, I'm pretty sure I can fix it alongside all the others--if it's fixable?

I'm pretty sure I broke a class or forgot an ID or missed something else that's important to keeping everything working. At the moment, we're working around the issue because everything still works in the thread page itself, but it'd be great if someone had a solution for the board template!

[Brian]

Hi, katya.

Lemme start by saying that your forum is freaking amazing so far. Awesome job on the board list.


Go to Structure > Layout Templates > Board and find this section of code.

        <tr><td class="list">
            <div class="$[list_class]">
    $[thread_list]
            </div>
            </td>
        </tr>
    </table>

Change it to this.

        <tbody class="$[list_class]">
            $[thread_list]
        </tbody>
    </table>

The problem was mostly due to the fact that your table was constructed improperly. You had a <div> element starting inside an unclosed table that didn't have any elements open to house it. This change simply uses V5's default method of using the <tbody> element to attach the $[list_class] variable to (which makes the pagination work), and houses the $[thread_list] variable inside the table body (this variable contains the Thread List template, where the table continues properly with <tr> and <td> elements).

[katya]

Awesome, thanks so much! <3