Thread Icons [v0.1.17 Updated on 15-Feb 2020]

[SailorEffinMoon]

Chris Hi, can you tell me why only the Admin can see the images on my forum? crystaltokyo.boards.net/board/4/totally-free-finds

[P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓]

Nov 12, 2017 2:38:54 GMT -8 SailorEffinMoon said:

Chris Hi, can you tell me why only the Admin can see the images on my forum? crystaltokyo.boards.net/board/4/totally-free-finds

I would have them hold left shift and hit refresh to do a fresh page load if it was a recent plugin addition. I think there is an option to ban certain people from it, make sure you didn't add anyone to that list.

[Chris]

Nov 2, 2017 11:23:16 GMT -8 SailorEffinMoon said:

Hi there, having a little issue on my new site. I've got it on default theme, my permissions for the plugin are set to "Everyone" and applied to my default theme, but I (admin) am the only one who can see the thread icons. Am I having a brain fart and missing something?

Here is the board in question

My apologies SailorEffinMoon, it's been awhile since I've visited this thread so it hasn't been showing up on neither my participated nor bookmark notifications.

What you're describing appears to be a bug introduced in the last edit when I had refactored the code and combined the handler for determining individual icon user/group restrictions with the global user/group permissions. The local (per icon) setting is meant to affect who can view as well as who can use the icon while the global setting is meant to determine who can use without having an affect on who can view but I completely forgot that distinction and combined the handlers.

I'll post a fix once my senses turn up in the lost and found dropbox.

[SailorEffinMoon]

OTG, I thought I was losing my mind. I checked everything and couldn't figure out why it was JUST ME seeing them lol. I figured if I didn't hear anything back anytime soon I'd just remove the plugin.  Would of been a shame tho, it's a great mod  

[Chris]

OK SailorEffinMoon , give version 0.1.9 a whirl.

Here is a list of changes that have been made in version 0.1.9 (for documentation)

1. 
   In the userAllowed function the line forum = forum || plugin.settings; was changed to forum = forum || {user_list:[]};so it uses a locally created fallback rather than the global plugin settings when no parameters are passed in. When checking local permissions, if the function returns false the plugin intentionally exits so the user sees nothing added by the plugin, this was unfortunately also occurring with global permission checks
   
2. 
   In the groupAllowed function the line forum = forum || plugin.settings; was changed to forum = forum || {group_list:[]};so it now uses a locally created fallback rather than the global plugin settings when no parameters are passed in. When checking local permissions, if the function returns false the plugin intentionally exits so the user sees nothing addedby the plugin, this was unfortunately also occurring with global permission checks
   
3. 
   In the buildMenu function the portion of code responsible for attaching the button and menu to the DOM is now wrapped in a conditional which checks if the current user has the appropriate global permissions to see this button/menu
   
   
   

   		if( (eton['eton_thread_image']['userAllowed'](undefined,plugin.settings) && eton['eton_thread_image']['groupAllowed'](undefined,plugin.settings)) ){
   		button.html(w.img ? '<img  alt="Set Icon" src="' + (w.img) + '" class="thread-icon thread-subject status" style="position:static;"><div class="icon"><span class="arrow down"><span></span></span></div>' : 'Set Icon')
   		.find('img')
   		.on('click', false)
   		$('.subject_input input')
   		.addClass('has-thread-image')
   		.wrap('<div style="overflow:hidden" class="subject-input-wrapper"></div>')
   		.parent()
   		.before('<label for="subject" class="subject-input-label"></label>')
   		.prev()
   		.append(button, menu);
   
   		}

   
   

Permissions that are dependent on board are still checked in combination since there is no distinction between user and viewer when it comes to determining if the plugin should be running within a board.

[SailorEffinMoon]

Hmm it didn't seem to make a difference. First I installed and overwrote the old file cuz I wanted to keep the data. That didn't work. Then I decided to delete it (still keeping old data) and reinstall it. That didn't work. You think I need to delete the data completely and install it fresh? I was trying to avoid having to redo all the pictures lol.

[Chris]

SailorEffinMoon , I'm headed to work in a few so I'll have to revisit this tomorrow but in the mean time can you temporarily try enabling the guest icon setting (see image below) and let me know the results so I can rule out a suspicion?

[SailorEffinMoon]

Yep you nailed it. It works now that I checked that box. 

Edit:
Also maybe I should add in now that when I try to set it as just INCLUDE "totally free finds" it doesn't work for me at all.  

[Chris]

Nov 14, 2017 11:29:15 GMT -8 SailorEffinMoon said:

Yep you nailed it. It works now that I checked that box. 

Edit:
Also maybe I should add in now that when I try to set it as just INCLUDE "totally free finds" it doesn't work for me at all.  

Guest should still be able to see the icon even if they cannot set one so that still needs to be fixed although you can enable it and use the permissions in the forum setup to determine whether a guest can post in a particular board or not thus effectively addressing the problem through a more robust mechanism than paper thin plugin restrictions.

try{

Can you give a bit more detail on what "doesn't work for me at all" mean such as what you are expecting to happen versus what you are seeing happen or not happen?

}catch(misinterpretation){

I just tested this by adding an icon into version 0.1.9 and configuring that icon to only be assignable in the general board using INCLUDE then I went to create or edit the first post of a thread and that icon only appears for use in the dropdown list only when I am in the general board and is absent from the dropdown in any other board, is this not what you are seeing? Am I testing this the way you are? Is there a difference you are seeing using INCLUDE versus EXCLUDE?

}finally{

If you are interpreting that feature as to somehow retroactively disqualify the icons of threads that have already been set within that board prior to the change you made then no, the only feature that does that is the url disqualifier. If you want an icon that has been used in the past perhaps across all boards to no longer be used on a thread in a particular board then remove the icon from that thread or change it to a different icon, the restrictions in place at the time that icon is being chosen will govern which images can be assigned to that thread.

Please let me know your results and/or your thinking of how you are expecting it to work.

}

[P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓]

Nov 15, 2017 14:59:14 GMT -8 Chris said:

Nov 14, 2017 11:29:15 GMT -8 SailorEffinMoon said:

Yep you nailed it. It works now that I checked that box. 

Edit:
Also maybe I should add in now that when I try to set it as just INCLUDE "totally free finds" it doesn't work for me at all.  

Guest should still be able to see the icon even if they cannot set one so that still needs to be fixed although you can enable it and use the permissions in the forum setup to determine whether a guest can post in a particular board or not thus effectively addressing the problem through a more robust mechanism than paper thin plugin restrictions.

try{

Can you give a bit more detail on what "doesn't work for me at all" mean such as what you are expecting to happen versus what you are seeing happen or not happen?

}catch(misinterpretation){

I just tested this by adding an icon into version 0.1.9 and configuring that icon to only be assignable in the general board using INCLUDE then I went to create or edit the first post of a thread and that icon only appears for use in the dropdown list only when I am in the general board and is absent from the dropdown in any other board, is this not what you are seeing? Am I testing this the way you are? Is there a difference you are seeing using INCLUDE versus EXCLUDE?

}finally{

If you are interpreting that feature as to somehow retroactively disqualify the icons of threads that have already been set within that board prior to the change you made then no, the only feature that does that is the url disqualifier. If you want an icon that has been used in the past perhaps across all boards to no longer be used on a thread in a particular board then remove the icon from that thread or change it to a different icon, the restrictions in place at the time that icon is being chosen will govern which images can be assigned to that thread.

Please let me know your results and/or your thinking of how you are expecting it to work.

}

Your humor is always amusing

[SailorEffinMoon]

Oh, what I meant was. I want it set so that the Thread Icons plugin only works on my board "Totally Free Finds".  So under "Board List Type" I put it to "Include", then the "Board List" to "Totally Free Finds".  When I do that, it doesn't show any thread icons on that board anymore.  I would just like to have thread icons only work on that board and have anyone be able to see them.    

[Chris]

Nov 16, 2017 4:41:41 GMT -8 SailorEffinMoon said:

Oh, what I meant was. I want it set so that the Thread Icons plugin only works on my board "Totally Free Finds".  So under "Board List Type" I put it to "Include", then the "Board List" to "Totally Free Finds".  When I do that, it doesn't show any thread icons on that board anymore.  I would just like to have thread icons only work on that board and have anyone be able to see them.    

So you are saying you create one or more icons in the plugin settings and specifically set them to only be usable in the TFF board but when you go to create a thread those icons are not available in the dropdown, that is not what I observe when I test that feature out like I said in my last post. I'll probabaly need to join the forum in order to observe this behaviour since it does not act that way when I set it up on 2 separate forums.

[SailorEffinMoon]

No. I'm not using the icon list. I let the plugin choose what the thread icon is going to be from the post. When I try set the plugin to only work in the one board it doesn't show the thread icons in  anymore.

1. Working
2. Edit
3. Not Working

[Chris]

Nov 17, 2017 6:16:03 GMT -8 SailorEffinMoon said:

No. I'm not using the icon list. I let the plugin choose what the thread icon is going to be from the post. When I try set the plugin to only work in the one board it doesn't show the thread icons in  anymore.

1. Working
2. Edit
3. Not Working

I cannot duplicate your results, for me they work as expected, could you give it another try with the visual aids again?

Just so there is no misunderstanding, you are saying when you configure the plugin to choose an image from the first post that when you create a thread it does not choose any images from the first post?

Threads that were created  prior to the plugin being installed will not auto-magically get an icon since the plugin waits until someone  actually opens the thread so it can take a peek to see if there are any images inside (only humans can open threads, plugins can get into trouble trying to do that) then those threads will gradually get their icons set if they too have images/avatars in the first post. The forced list options should be a bit quicker since there is no need to peek into the thread to see what images are available

[SailorEffinMoon]

Hey sry I've taken so long to message you back. Lemme try these images again.

Settings:



Not Showing the Thread Icons:




It does appear to still be trying to work.  When I edit a Thread it still shows the Thread Icon beside the Subject Title.