NPC Profiles

[Gene Hunt]

Thought I had this one solved but alas, I don't.

Is there a limit on number of NPC's?

[Brian]

Jun 29, 2018 12:27:12 GMT -8 Gene Hunt said:

Thought I had this one solved but alas, I don't.

Can you provide a link to the forum you're experiencing the issue on? I don't really have anything to go off of here.

Jun 29, 2018 12:27:12 GMT -8 Gene Hunt said:

Is there a limit on number of NPC's?

Sort of, but you'd definitely know if you hit it because you'd receive an error message about the plugin's space being exceeded when trying to save them. If you were able to save your new NPCs to the plugin at all then you haven't hit the limit.

Here's a long post explaining how the size limits in plugin settings work: support.proboards.com/post/6832565

[Gene Hunt]

Sorry for the delay Brian, I've been trying to figure this out.

I only have the plugin running on one section of the forum - >>>Here<<<

I use Chrome. When I view one of my existing posts, and click on the sword to get the dropdown list of available NPC's, I can see all of the available NPC's.
However, when I click to compose a new post, then click on the sword to get the dropdown list, I only get the last 12 or 18 available.

I've tried again in MS Edge. I get a very similar result but on a new post, I can see about 15 of the 18 available with one being cut in half off the top of the screen. I can't navigate any higher on the page as I'm already at the top. It appears to be the placing of the drop down list?

Thanks for taking a look.

GH.

[Brian]

Gene Hunt:

I can't seem to duplicate this. Every dropdown shows the full list of NPCs regardless of what action I'm performing on the forum.

Existing post: dev.prbrds.com/b/o/yfNQRJiEecrKvHfYkuRU.png
Reply: dev.prbrds.com/b/o/NQVrZhj0xqsFyZaoAmam.png
Create Thread: dev.prbrds.com/b/o/QReMPDQNXjbAkbrOOSjp.png

Can you provide a screenshot of what you're seeing?

[Gene Hunt]

Sure:

This is when replying to a post.

www.43tv.co.uk/43tvbuild/43tv%20Errors/NPC%20Error.jpg


It seems mine is not placing neatly under the NPC button like yours...

[Brian]

Jun 29, 2018 13:47:40 GMT -8 Gene Hunt said:

It seems mine is not placing neatly under the NPC button like yours...

This should only happen if your browser window isn't tall enough to accommodate the entire menu between the bottom of the button and the bottom of the window. If the menu doesn't have enough room to fit it moves to the top of the button instead, as is the case for most menus on the forum.

You could use CSS to tell it to add a scrollbar once it meets a certain height.

.user-npc-menu {
    overflow: auto;
    max-height: 300px;
}

Alternatively, in the newest version of the plugin there's an option to categorize your NPCs into submenus if you want to shorten the list that way.

[Gene Hunt]

Brilliant, as ever. Thanks Brian

GH.

[Gene Hunt]

Sorry Brian,

Where abouts would I place the CSS you gave above?

[Brian]

Jun 29, 2018 14:38:20 GMT -8 Gene Hunt said:

Sorry Brian,

Where abouts would I place the CSS you gave above?

I'd say your best bet is going into Plugins > Build > NPC Profiles and placing it at the end of the CSS section in the Components tab.

[Gene Hunt]

Perfect. Thanks Brian

[••Gaming.Boards.net••]

This doesn't work well with my current theme(can't see the poster in-thread, profile doesn't load, etc.), I'm just curious if any future versions will allow application to various types of themes. Other than that, I love the plugin!

Thanks!

[Brian]

Jun 29, 2018 15:05:19 GMT -8 ••Gaming.Boards.net•• said:

This doesn't work well with my current theme(can't see the poster in-thread, profile doesn't load, etc.), I'm just curious if any future versions will allow application to various types of themes. Other than that, I love the plugin!

Thanks!

It's already built to work that way. I try to make plugins like this work with as little dependencies as possible, but just barely enough was removed in your theme to make the mini-profiles unable to be replaced.

The reason the mini-profiles aren't working on your theme is because the .left-panel element where they reside in the default theme no longer exists. In Plugins > Build > NPC Profiles you only have to change a single line in the Javascript section of the Components tab to fix this.

This can be fixed by changing this:

$(this).find('.left-panel').append('<div class="mini-profile is-npc-element o-npc-mini">'+plugin.mini(post_id,npc)+'</div>');

To this:

$(this).find('.mini-profile').first().parent().append('<div class="mini-profile is-npc-element o-npc-mini">'+plugin.mini(post_id,npc)+'</div>');

Edit: This change is present in 1.2.4 which is now available in the plugin library.

[••Gaming.Boards.net••]

Jun 29, 2018 15:32:46 GMT -8 Brian said:

Jun 29, 2018 15:05:19 GMT -8 ••Gaming.Boards.net•• said:

This doesn't work well with my current theme(can't see the poster in-thread, profile doesn't load, etc.), I'm just curious if any future versions will allow application to various types of themes. Other than that, I love the plugin!

Thanks!

It's already built to work that way. I try to make plugins like this work with as little dependencies as possible, but just barely enough was removed in your theme to make the mini-profiles unable to be replaced.

The reason the mini-profiles aren't working on your theme is because the .left-panel element where they reside in the default theme no longer exists. In Plugins > Build > NPC Profiles you only have to change a single line in the Javascript section of the Components tab to fix this.

This can be fixed by changing this:

$(this).find('.left-panel').append('<div class="mini-profile is-npc-element o-npc-mini">'+plugin.mini(post_id,npc)+'</div>');

To this:

$(this).find('.mini-profile').first().parent().append('<div class="mini-profile is-npc-element o-npc-mini">'+plugin.mini(post_id,npc)+'</div>');

Edit: This change is present in 1.2.4 which is now available in the plugin library.

Thank you! It is now showing who has made the post as seen here: gamingboards.net/thread/3526/greedfall

However, it's still not showing the original author in the signature(it's on), and the profile doesn't have any content.

Thoughts there?

NPC Profile: gamingboards.net/user/1/npc/GBofficial

NPC Post: gamingboards.net/thread/3526/greedfall?page=1&scrollTo=40316

Thanks Brian!

[Brian]

Jun 29, 2018 15:54:45 GMT -8 ••Gaming.Boards.net•• said:

Thank you! It is now showing who has made the post as seen here: gamingboards.net/thread/3526/greedfall

However, it's still not showing the original author in the signature(it's on), and the profile doesn't have any content.

Thoughts there?

NPC Profile: gamingboards.net/user/1/npc/GBofficial

NPC Post: gamingboards.net/thread/3526/greedfall?page=1&scrollTo=40316

Thanks Brian!

That one unfortunately has a dependency that I can't change in the library version of the plugin. The author is meant to go where the signature goes, but I can't make the code check for where the signature usually is because not every user has a signature since they're optional (versus the mini-profile which is always there), so I had to tell the code to target the parent.

This is the line that controls that:

$(this).find('.foot').append('<div class="signature is-npc-element o-npc-signature">Posted by: </div>');

Changing .foot to .content should fix it on that theme, but if you use any other themes it might break on those.

As for viewing the NPC's profile, your NPC doesn't have any profile information to display so nothing shows there. The only fields that will ever show on that page are Birthday, Gender, and Location.

The HTML that produces the NPC's profile is controlled by the Profile HTML tab of the plugin's settings. The same goes for the mini-profile if you want to change that to match your actual mini-profiles.

[••Gaming.Boards.net••]

Very much appreciated, thank you!!