inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,017
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Oct 11, 2014 8:11:02 GMT -8
If you send me a copy of the plugin I'll probably get a better overview of the problem. By the way, I noticed a few minutes ago that a bug which was reported regarding a selection problem in the WYSIWYG ( link) is still present or perhaps has resurfaced although I never saw it mentioned in the update blog unless it was included in a phrase such as "..and other minor bug fixes". I'll also confirm that the bug noted earlier in this thread has also been fixed in the newest js file so the WYSIWYG should be back to saving selections and ranges on keyups and mouseups. My concern however is you did post a code earlier that messed extensively with the WYSIWYG's selection and ranges in the smearEditor function not only in the body of the function but also in the Apply button's click handler. Are you positive you removed all those tentacles?
|
|
inherit
King Oligochaete
126470
0
Feb 24, 2021 12:23:15 GMT -8
Wormopolis
Stop rating plugins with 1 star that dont deserve it.
20,002
June 2008
tbserialkillers
Wormo's Mini-Profile
|
Post by Wormopolis on Oct 11, 2014 18:33:19 GMT -8
that is why I did a manual call as the first thing on the button click. link to dropbox file in your PMs
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,017
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Oct 12, 2014 5:09:02 GMT -8
OK, a couple quick prelim observations: - It's tricky knowing when the WYSIWYG is ready for use and I see several attempts to grab it such as on a window load event and as a resource draining mousemove event. My preferred method has been to hook into the create method of the WYSIWYG, call the original method then do what I needed to do after creation, this can however cause problems for the WYSIWYG if your code encounters a problem it cannot handle so the safer method would be to listen for the custom 'wysiwygcreate' event on the document then you can be sure the WYSIWYG has loaded.
$(document).on('wysiwygcreate',function(evt){ globalEditorSave = $('.wysiwyg-textarea').data('wysiwyg')); //do more WYSIWYG stuff here });
-
I see a tentacle which still lingers in the code
if (!IEhold) $('div#colorSmear_bbcode').find('input#smearStart, input#smearEnd').click(); That references an undefined variable from the octopus which would undoubtedly cause a referenceError and crash the function You already know about this one
I'll take a more in-depth look this afternoon...
|
|
inherit
King Oligochaete
126470
0
Feb 24, 2021 12:23:15 GMT -8
Wormopolis
Stop rating plugins with 1 star that dont deserve it.
20,002
June 2008
tbserialkillers
Wormo's Mini-Profile
|
Post by Wormopolis on Oct 12, 2014 6:02:20 GMT -8
The button place was in there from the beginning. Even before you started experimenting I think. I know it loads slower but I had always had success with it do I never touched it again. I was actually going to redo that your way IF I can get the surround to work. On a link insert it brings up a dialog and works fine so I know its possible. I just have to figure out how to save the selection and re select it after the dialog box closes for replacement. I find myself on stackoverflow again for hints on that textarea.
|
|
inherit
King Oligochaete
126470
0
Feb 24, 2021 12:23:15 GMT -8
Wormopolis
Stop rating plugins with 1 star that dont deserve it.
20,002
June 2008
tbserialkillers
Wormo's Mini-Profile
|
Post by Wormopolis on Oct 13, 2014 5:33:53 GMT -8
I think Im going to have to write up something using getBookmark() and moveToBookmark() to get IE to play along.
|
|