mrdoe
New Member
Posts: 36
inherit
210300
0
Jul 31, 2014 10:34:07 GMT -8
mrdoe
36
June 2014
mrdoe
|
Post by mrdoe on Jun 26, 2014 12:07:31 GMT -8
Thanks for taking a look for me Peter , Ill add that to the stylesheet thingy, could you explain (in dummy terms) how to do the following? "You can overwrite them with CSS, they have a class for each ribbon. Just uploading then and set the background image for each of them with CS" Ill make them red writing in Photoshop and upload them to a hosting site so they will be seen. When/if you have time to explain man, thanks for everything
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jun 26, 2014 12:23:18 GMT -8
mrdoe.shop_ribbon_10 {
background-image: url(http://i.imgur.com/JmBL5Lm.png) !important;
}
.shop_ribbon_25 {
background-image: url(http://i.imgur.com/ebezAWa.png) !important;
}
.shop_ribbon_50 {
background-image: url(http://i.imgur.com/G4tmCri.png) !important;
}
.shop_ribbon_75 {
background-image: url(http://i.imgur.com/EaxBAKA.png) !important;
}
.shop_ribbon_90 {
background-image: url(http://i.imgur.com/yj3jfUI.png) !important;
}
|
|
mrdoe
New Member
Posts: 36
inherit
210300
0
Jul 31, 2014 10:34:07 GMT -8
mrdoe
36
June 2014
mrdoe
|
Post by mrdoe on Jun 26, 2014 12:41:20 GMT -8
You're the best! Ill try that, anywhere in the stylesheet I assume? I usually add them after the first line coz it worked before, but am clueless. thanks again for all you do Peter
|
|
Former Member
inherit
guest@proboards.com
189070
0
Nov 29, 2024 19:52:59 GMT -8
Former Member
0
January 1970
Former Member
|
Post by Former Member on Jun 26, 2014 16:37:09 GMT -8
Im still in awe of the animation lol, I be buying stuff just to watch them float to the basket, then refresh and start all over again, Im like a kid lol!
|
|
Former Member
inherit
guest@proboards.com
207982
0
Nov 29, 2024 19:52:59 GMT -8
Former Member
0
January 1970
Former Member
|
Post by Former Member on Jun 26, 2014 18:32:03 GMT -8
So I did say 5 votes were needed, but we got 4, so good enough A lot of changes to the code, so some bugs may have made their way in. I've done my best to test it as much as one person can. 0.4.0 [26/06/2014]- Items can now be discounted (items show discount ribbon on shop page) - Removing an item from a profile now possible (disabled by default; staff only feature) - Image size setting is now applied to the shop page and checkout dialog - Can now restrict the total amount a member can buy of one item ("Add to Cart" becomes disabled if they reach max quantity) - Various tweaks and bit of rewriting of the gift module (ripped out of main shop module and placed on it's own, as looking through 2000 lines was a bit of a pain). No trade feature in this release, a lot of work to do with that. Download from first post, or wait until the library has been updated. Yay! Thank you so much, Peter, for such a quick push with the awesome new features. Everything is working great from what I can see. =D
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Jun 26, 2014 22:51:12 GMT -8
Peter - re resizing, have you thought of using a max-width: option rather for resizing?
That way it would only hit anything over that width and if the height is then set to: auto; it'll automatically keep ratio
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jun 27, 2014 1:36:31 GMT -8
Boy_WonderThe problem is that the code doesn't know the size of the images until they have loaded, and using percentages doesn't work too well at all as the parent element won't shrink (so you get white space) as the browser has already rendered it's space used.
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Jun 27, 2014 1:43:11 GMT -8
I wasn't referring to percentages, I'm not sure if you're using css or anything to do the resizing of the images. As I'd be more likely to try and include somehow style="max-width: plugin setting.shopwidth px; height: auto; to let css to a resize of the shop images
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jun 27, 2014 1:49:38 GMT -8
Boy_WonderAs I already said, the code doesn't know the size of the images until loaded (not including any settings). The settings for height and width can be set, they are used inline, so that's not an issue, and that's down to the user to set the size correctly, otherwise images will still be too big, or skewed. So a max-width is pointless here. The proper way is to resize the images themselves (i.e Photoshop), otherwise using the percentage resize setting is recommended.
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Jun 27, 2014 1:53:22 GMT -8
Ahh - I understand this, however max-width I'd find is useful in the case of if you have a mix of image sizes (I'm currently redoing all of SHIELDs shop icons, the old ones are a smaller size ones when resized down especially in mini profile are going too small
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jun 27, 2014 2:03:28 GMT -8
Boy_Wonder, You can override the CSS with max-width / height yourself since you know the size
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Jun 27, 2014 2:05:59 GMT -8
Right now I've got all the items done that people are using but yes it was just a thought
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jun 27, 2014 2:12:06 GMT -8
Boy_Wonder, I think I misread your original post. Are you saying that instead of have width and height as a setting, make it a max-width / height setting instead? If you are, then yes, you are correct, it would be a lot better, that way you aren't resizing every image.
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Jun 27, 2014 2:26:24 GMT -8
0.4.2 [27/06/2014] - Image settings for width and height now uses max-width and max-height
|
|
inherit
Peabrained Codebreaker
107114
0
Mar 11, 2020 7:47:27 GMT -8
Boy_Wonder
6,249
July 2007
natzy24
|
Post by Boy_Wonder on Jun 27, 2014 2:28:10 GMT -8
Boy_Wonder, I think I misread your original post. Are you saying that instead of have width and height as a setting, make it a max-width / height setting instead? If you are, then yes, you are correct, it would be a lot better, that way you aren't resizing every image. Yes that's what I was meaning xD - that and css tends to handle things like that and auto resizes to fit best rather then risking distorted proportions
|
|