JavaScript Help?

[crystalfrost]

I'm not sure where I can post this, so if it's in the wrong place someone please move it. I just need some coding help.

I'm extremely new to JavaScript, and I've been messing around with trying to create a random generator. I want to be have two inputs (a min and a max), and then have the function return a number between the two (inclusive for both).

<script>
   function random() {
       var x, text;
       x = document.getElementById("min").value;
       var y, text;
       y = document.getElementById("max").value;
       
       var z = document.getElementById("numb")
           z.innerHTML = Math.floor((Math.random() * (y - x)) + x);
                                    }
</script>

<p>Please input a min and a max:</p>

<input id="min" type="text">
   
<input id="max" type="text">

<button type="button" onclick="random()">Submit</button>

<p id="numb"></p>

If I put in 5 and 10, it starts spitting out numbers less than five. Can someone tell me where I went wrong?

Oh, and here's the link to the page.

all-around-rp.proboards.com/page/test

[David Clark]

I moved this over to the plugins section

[Pebble]

This should work for you :

<script>
function random() {
var x, text;
x = parseInt(document.getElementById("min").value);
var y, text;
y = parseInt(document.getElementById("max").value);

var z = document.getElementById("numb")
z.innerHTML = Math.floor((Math.random() * (y - x)) + x);
}
</script>

<p>Please input a min and a max:</p>

<input id="min" type="text">

<input id="max" type="text">

<button type="button" onclick="random()">Submit</button>

<p id="numb"></p>
The value needs to be a number, so you need parseInt to do that. More info here : www.w3schools.com/jsref/jsref_parseint.asp

EDIT: So it makes more sense!
The x and y 'values' are returned as strings so you can use parseInt to convert x and y into numerical values..... Hope this helps!

[crystalfrost]

Thank you! That worked perfectly.