Flag Important Threads (0.1.5)

[Todge]

'style="display: none;'

Hiding the container cell will obviously hide it's contents, I'd say that that's the problem.

[Boy_Wonder]

That's part of the tabbed table code and it worked fine prior to 0.0.8.

When the tab is selected javascript turns the display:none; off

[Todge]

Strange.. There's no JS error showing up for me on your forum, and the function that displays the threads has not been changed, so if version 0.0.7 worked, then 0.0.8 should too..

I do see that the first key entry is incorrect, so that COULD be causing the issue.. Unfortunately, the easiest way to fix that is to clear the keys' data and start again..

Are you seeing the option to set threads important?

[Boy_Wonder]

Not at all on my staff account

[Todge]

Do you have a test forum where I can take a closer look at this?

[Boy_Wonder]

Not right now - its all live on SHIELD because I don't have the money to keep buying keys for new items to test

[Todge]

You don't need to buy any keys to have a test forum.. You get a few keys for free.

If you are willing, set up a test forum and just have the Important Thread plugin and tabbed table set up, it seems that those two codes do not like playing well together, so hopefully it's a issue that will be easily found.

If you'd rather not do that, give me the code for your tabbed table and I'll look into it on my test forum, but that may take a while as it is loaded with other stuff that could easily cause issues that I am not willing to remove right now,

[Boy_Wonder]

Let me try clearing key data and remarking a thread as important as a member after some from staff first so I can at least narrow down "what's" causing it... okay here's a REALLY odd thing. It's not got a key at all ... I just checked down the key list I can't find anything

Edit: Okay the place thing is no longer working (I've checked I'm using the right thing) and I can only make it display if I have the tickbox ticked to Use Default Layout


But without a member having set a thread as open it works fine

Edit: Can definitely clarify that there's two bugs here. a) Something isn't letting me to place it where I want it b) a member marking a thread as Important makes it so that the whole thing disappears - I'm assuming this is what's causing the key data error

[Todge]

The positioning part of the code is untouched, so if you could position the previous version in the cell of your choice, then you should be able to with this version too. The ONLY thing I added was a button beside the 'Reply' button for non-staff. Clicking that would even call up the original unaltered function to set the thread as important, so I'm at a loss as to what has happened.

You say you can only use the default layout? If you use an 'illegal' manual layout, that could break the code, but I'd have thought you'd just get strange results rather than stopping it from working.

Do you have a guest friendly thread, and can you take it back out of the ITS_Here cell for now so I can at least see it.

[Boy_Wonder]

It's not even displaying in the ITS_Here, and guest friendly threads can be found - I'll set one up now and link you to it

(and reset key data so you can see it)

shieldrp.com/thread/2650/welcome-all-guests

((Also apparently I can no longer set threads as important even with a key data clear ¬¬ ))

[Todge]

I can set that thread to Important/Unimportant without any issues.

What problems are you having concerning the setting of Important Threads?

[Boy_Wonder]

When a member sets the thread to important unimportant it corrupts the key and throws a tizzy fit in google chrome.

As you can see the plugin is working fine now. Its still complaining that it cannot read the property style of null but without the full error.

[Boy_Wonder]

Okay even wierder... its... working fine now! Now just to get it back where I want it

Edit: Nope sorry Todge. I've broken it again. I will write my steps down here

That error I quoted earlier has shown up so I'm assuming I corrupted the key again.

Step one on staff account I created a new thread. (http://shieldrp.com/thread/2652/who < that thread)
I marked it as 'important' in the actions before hitting new post.

The key was corrupted.

The same thing happened when I did that from a member account (hitting the mark as important button in the new thread view).

So I think I've narrowed it down to it happening in the new thread view NOT when viewing the thread itself.

[Todge]

Apr 7, 2015 2:37:53 GMT -8 Boy_Wonder said:

Okay even wierder... its... working fine now! Now just to get it back where I want it

Edit: Nope sorry Todge. I've broken it again. I will write my steps down here

That error I quoted earlier has shown up so I'm assuming I corrupted the key again.

Step one on staff account I created a new thread. (http://shieldrp.com/thread/2652/who < that thread)
I marked it as 'important' in the actions before hitting new post.

The key was corrupted.

The same thing happened when I did that from a member account (hitting the mark as important button in the new thread view).

So I think I've narrowed it down to it happening in the new thread view NOT when viewing the thread itself.

AH-HA

So you are trying to mark a thread as important before the first post of said thread has been posted.. That should not be possible, and yes, it will cause an error because the code will not be able to save the data for the thread, as it doesn't exist yet.

Try this version, it should no longer be possible to seat a thread as important while you are posting.

[Boy_Wonder]

I'M GLAD WE SOLVED IT AS I WAS SO CONFUSED!

Also any help getting it to sit in the "ITS_HERE" place as its... kinda refusing