Fading Quotes 1.0.0

[Lynx]

Peter - Would it be alright if I played around with the code on it? I saw you left it open source ... not to mention it might help with my learning process.

[Peter]

Jul 15, 2015 14:35:25 GMT -8 Lynx said:

Peter - Would it be alright if I played around with the code on it? I saw you left it open source ... not to mention it might help with my learning process.

Sure, do what you want with it

[Lynx]

Jul 15, 2015 14:40:05 GMT -8 Peter said:

Jul 15, 2015 14:35:25 GMT -8 Lynx said:

Peter - Would it be alright if I played around with the code on it? I saw you left it open source ... not to mention it might help with my learning process.

Sure, do what you want with it

Thank you, kind sir!

[Former Member]

well im going to keep it just how it is peter, its cool and iv only set it for 1 board where jesus posts a guy on my site i mentioned.

thanks

[monmonmoney]

Is anyone having issues with the fading quote plugin not working?

[Peter]

monmonmoney

I done some quick tests, no issues. Maybe expand on the issues you are having.

[Sav]

Excellent plug-in thanks makes my forum much easier to scroll through.

As I noted in my review there seems to be an issue if the quote has an open "div" in the bbcode in front of it, the condensing does not work. Close off the "div" before the quote and it works fine.

May also apply to other tags.

[Lynx]

Dec 28, 2021 10:46:07 GMT -8 Sav said:

Excellent plug-in thanks makes my forum much easier to scroll through.

As I noted in my review there seems to be an issue if the quote has an open "div" in the bbcode in front of it, the condensing does not work. Close off the "div" before the quote and it works fine.

May also apply to other tags.

Just to note - a plugin's review in the library is not the place to post issues, those should go in the plugin's support thread (which you did - thank you). Reviews may not be looked at as often as the support thread, so issues posted there may not get noticed in a reasonable amount of time. I rarely check the reviews of my plugins in the library, as I state in most (if not all) of my plugins that issues should be reported in their respective support threads.

[Sav]

I think that's called "stating the obvious"

The issue was a part of my favourable review for anyone installing the plug-in.

The issue (and work-around) was also reported here in the support thread for possible resolution.

[Lynx]

Dec 29, 2021 3:55:17 GMT -8 Sav said:

I think that's called "stating the obvious"

The issue was a part of my favourable review for anyone installing the plug-in.

The issue (and work-around) was also reported here in the support thread for possible resolution.

You may be surprised at how it's not as obvious as you may think and in many cases. I've seen a number of issues posted in various plugin reviews (and not just my plugins) that were never put into their support thread - where they should have been posted.

[Sav]

Perhaps you would be kind enough to leave this thread to the topic the O.P. set it up for.

[Chris]

The plugin is coded to ignore nested quotes and the way it does that is by targeting only quotes that are direct children of the .message body (anything deeper such as grandchildren, great-grandchildren and so on gets ignored). This is the reason why a quote nested inside a div element or any other element for that matter gets no attention.

If you want to fix this you can try modifying the following line in the plugin's code:

var quotes = $("tr.item td.content div.message > div.quote");

to read

var quotes = $("tr.item td.content div.message  div.quote").filter(function(x,y){return $(y).closest('.quote_body').length === 0})

instead.

^{*note: The child combinator (">") is removed and a filter is instead added to test each found quote in turn to see if it is within another quote
*caveat: not tested for conflicts}

[Sav]

Thx. will take a look and report back.

[Sav]

Appears to do the business, have deliberately added open divs, no side effects noted thus far.

O.P. has not posted for over six months but will keep an eye on the original plug in being updated.

Many thanks, it's a very useful plug in as my forum has some horribly long posts that I can control with manual quote tag addition. Hopefully your fix will solve the problem for the earlier posters as well.

Perhaps a moderator could delete the four irrelevant posts from Dec 28, 2021 at 8:13pm onwards and also this line

[PF]

Hello Chris,

I installed this plug-in on my forum, but it shows on boards that aren't selected in the settings. The description reads that it will only work on selected boards, but I've seen it on boards that aren't selected.

How can that be fixed?

Thank you.