inherit
96289
0
May 17, 2020 9:37:00 GMT -8
elli
1,822
January 2007
ebbymac
|
Post by elli on Apr 7, 2015 13:48:44 GMT -8
For those of you who have made a v5 skin, I'm sure you've become quite acquainted with the stylesheets. You may know that it's written using LESS (a CSS preprocessor language), and has lots of variables and mixins.
My question is this... Do you prefer to edit the existing variables and styles directly (the ones at the top of the stylesheet), or do you prefer to overwrite them at the bottom? The great thing about LESS is that you can redeclare variables just like you can overwrite any regular property, but it can get kind of messy trying to undo all of ProBoards' default styles.
Additionally, which method do you think works best for premades (multiple users)? For commissioned skins (single users)? For your own board (personally)?
|
|
Kami
Forum Cat
Posts: 40,063
Mini-Profile Theme: Kami's Mini-Profile
#f35f71
156500
0
Offline
Jul 24, 2021 11:48:29 GMT -8
Kami
40,063
July 2010
kamiyakaoru
Kami's Mini-Profile
|
Post by Kami on Apr 7, 2015 14:20:11 GMT -8
I think my answer to all three is overrides at the bottom. It just feels faster to me to override a value rather than sorting through the CSS and finding specific variables and editing them.
|
|
inherit
220360
0
Jul 4, 2015 10:35:30 GMT -8
Philip
31
April 2015
legions
|
Post by Philip on Apr 7, 2015 14:39:31 GMT -8
You can actually delete most of the proboards styles, apart from those that are needed for the theme builder. After those lines you can delete most(if not all) of the styles, HOWEVER you will need to delete them one by one, as some rules lower done the chain require rules up the chain, once you delete the rules below the chain, you can most probably delete the ones up the chain. BE CAREFUL when deleting rules, delete one section at a time and save to see what the compiler says.
|
|
Kami
Forum Cat
Posts: 40,063
Mini-Profile Theme: Kami's Mini-Profile
#f35f71
156500
0
Offline
Jul 24, 2021 11:48:29 GMT -8
Kami
40,063
July 2010
kamiyakaoru
Kami's Mini-Profile
|
Post by Kami on Apr 7, 2015 14:44:10 GMT -8
You can actually delete most of the proboards styles, apart from those that are needed for the theme builder. After those lines you can delete most(if not all) of the styles, HOWEVER you will need to delete them one by one, as some rules lower done the chain require rules up the chain, once you delete the rules below the chain, you can most probably delete the ones up the chain. BE CAREFUL when deleting rules, delete one section at a time and save to see what the compiler says. I presume this is a reply to me since you didn't actually answer any of the questions.
I'm not saying that you can't. All I'm saying is that it's easier to override the default styles by writing your own CSS at the bottom.
Removing by trial and error sounds just as time consuming.
|
|
inherit
220360
0
Jul 4, 2015 10:35:30 GMT -8
Philip
31
April 2015
legions
|
Post by Philip on Apr 7, 2015 14:50:18 GMT -8
Kami Removing by trail and error is time consuming, without a doubt! It can be done. It would mean they would have to re-write every style themselves, or change the templates to include their own styles. Overriding styles is OK I guess, but it will slow your website down if your looking for maximum performance.
|
|
Kami
Forum Cat
Posts: 40,063
Mini-Profile Theme: Kami's Mini-Profile
#f35f71
156500
0
Offline
Jul 24, 2021 11:48:29 GMT -8
Kami
40,063
July 2010
kamiyakaoru
Kami's Mini-Profile
|
Post by Kami on Apr 7, 2015 14:53:10 GMT -8
Kami Removing by trail and error is time consuming, without a doubt! It can be done. It would mean they would have to re-write every style themselves, or change the templates to include their own styles. Overriding styles is OK I guess, but it will slow your website down if your looking for maximum performance. Hardly? I mean, I've been doing this a long time and even with as extensive as my modifications are, overriding the css creates barely a fraction of a second of difference than loading support.
The only time I've seen extensive slowing is with a forum that has 75+ themes and CSS effects on just about every single element possible.
|
|
inherit
220360
0
Jul 4, 2015 10:35:30 GMT -8
Philip
31
April 2015
legions
|
Post by Philip on Apr 7, 2015 15:03:20 GMT -8
Kami I won't argue with you about it, If you think overriding is the way to go, so be it. Personally I wouldn't do it myself. Have you run any performance tests to back up your statement? I haven't(at least on proboards).
|
|
Kami
Forum Cat
Posts: 40,063
Mini-Profile Theme: Kami's Mini-Profile
#f35f71
156500
0
Offline
Jul 24, 2021 11:48:29 GMT -8
Kami
40,063
July 2010
kamiyakaoru
Kami's Mini-Profile
|
Post by Kami on Apr 7, 2015 15:13:16 GMT -8
Kami I won't argue with you about it, If you think overriding is the way to go, so be it. Personally I wouldn't do it myself. Have you run any performance tests to back up your statement? I haven't(at least on proboards). Repeatedly, thank you.
|
|
inherit
96289
0
May 17, 2020 9:37:00 GMT -8
elli
1,822
January 2007
ebbymac
|
Post by elli on Apr 7, 2015 15:17:07 GMT -8
Kami I won't argue with you about it, If you think overriding is the way to go, so be it. Personally I wouldn't do it myself. Have you run any performance tests to back up your statement? I haven't(at least on proboards). Considering that stylesheets are just text files, they don't take up much room. My personal website's single CSS file has over 2000 lines of code, but is only 38kb. 100kb or less is probably ideal. And since ProBoards have separate styles for mobile users, a larger stylesheet won't really affect many people since a good majority have high speed internet these days. That being said, if there's any reason not to overwrite everything, it's for the sake of keeping things simple. DRY (don't repeat yourself) CSS is good practice, not to mention easier to edit. But here on PB, it might be easier to overwrite in some cases, which is why I've posed this question. Mostly, I'm just interested in others' preferences, as I try to decide which method seems more logical for myself.
|
|
inherit
220360
0
Jul 4, 2015 10:35:30 GMT -8
Philip
31
April 2015
legions
|
Post by Philip on Apr 7, 2015 15:22:43 GMT -8
elli fair point well made! You clearly have an understanding. I have overrode styles myself in proboards, you gotta play by the rules sometimes. BUT from a DRY approach then no I wouldn't.
|
|
Kami
Forum Cat
Posts: 40,063
Mini-Profile Theme: Kami's Mini-Profile
#f35f71
156500
0
Offline
Jul 24, 2021 11:48:29 GMT -8
Kami
40,063
July 2010
kamiyakaoru
Kami's Mini-Profile
|
Post by Kami on Apr 7, 2015 15:23:51 GMT -8
That being said, if there's any reason not to overwrite everything, it's for the sake of keeping things simple. DRY (don't repeat yourself) CSS is good practice, not to mention easier to edit. But here on PB, it might be easier to overwrite in some cases, which is why I've posed this question. Mostly, I'm just interested in others' preferences, as I try to decide which method seems more logical for myself. I definitely agree with this wholeheartedly. It would also be easier IMO to do this if there were more accessible documentation for the CSS we have available to us.
|
|
inherit
220360
0
Jul 4, 2015 10:35:30 GMT -8
Philip
31
April 2015
legions
|
Post by Philip on Apr 7, 2015 15:29:48 GMT -8
elli Kami I guess my case was more against overriding styles that you didn't really have access to, unless you used !important
|
|
Kami
Forum Cat
Posts: 40,063
Mini-Profile Theme: Kami's Mini-Profile
#f35f71
156500
0
Offline
Jul 24, 2021 11:48:29 GMT -8
Kami
40,063
July 2010
kamiyakaoru
Kami's Mini-Profile
|
Post by Kami on Apr 7, 2015 15:34:46 GMT -8
elli Kami I guess my case was more against overriding styles that you didn't really have access to, unless you used !important since v5 I'm fairly certain we have access to everything CSS wise (:
|
|