inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,022
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Oct 24, 2015 15:29:01 GMT -8
I just did an update for a plugin adding some extra configuration options for some new features and populated an autoform with default entries of a few of the more common reading score/grade level formulas to save time and aggravation for the user. It works well when importing the plugin and saying NO to the question asking to import settings from an older version but if the answer is YES then those default values disappear from the autoform. In the past new configuration options were left untouched if they never existed in the older imported configuration set but now they are being zeroed? BUG? Edit:
to further clarify, the autoform has never existed before this update nor were there ever any settings now or in the past bearing the name "reading_formulas" (yes, shorten from "reading_level_formulas" prior to setting the default entries). The default values that existed in the older configurations are still there but the newer ones appear to have been overwritten by the settings import even though they never existed in the older config. Enter build mode then preview UI and the default values for the newer options are still there. I also appear to be hanging off the cliff edge regarding JS component size (71183 chars) evidenced with a few saves that truncated the JS so I've minified down to 40K and retested the import process with the same results, ignore previous version settings and fine, try to keep old settings and uh oh. word counter v1.0.8Tim Camara Vinh Brian David Clark
|
|
inherit
201984
0
Sept 11, 2023 1:23:07 GMT -8
P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓
Using My Talents Elsewhere
3,314
November 2013
pastuleo23
|
Post by P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓ on Oct 25, 2015 2:04:21 GMT -8
I just did an update for a plugin adding some extra configuration options for some new features and populated an autoform with default entries of a few of the more common reading score/grade level formulas to save time and aggravation for the user. It works well when importing the plugin and saying NO to the question asking to import settings from an older version but if the answer is YES then those default values disappear from the autoform. In the past new configuration options were left untouched if they never existed in the older imported configuration set but now they are being zeroed? BUG? Edit:
to further clarify, the autoform has never existed before this update nor were there ever any settings now or in the past bearing the name "reading_formulas" (yes, shorten from "reading_level_formulas" prior to setting the default entries). The default values that existed in the older configurations are still there but the newer ones appear to have been overwritten by the settings import even though they never existed in the older config. Enter build mode then preview UI and the default values for the newer options are still there. I also appear to be hanging off the cliff edge regarding JS component size (71183 chars) evidenced with a few saves that truncated the JS so I've minified down to 40K and retested the import process with the same results, ignore previous version settings and fine, try to keep old settings and uh oh. word counter v1.0.8Tim Camara Vinh Brian David ClarkThe truncate is normal for over 70k. That is why you can now add two js components to fit 70 in each. Js component is no longer greyed out when only one component exists. Also if im reading this right: I have had this problem since I started. I just post the new defaults on my plugin page for anyone interested.
|
|
inherit
The Great Cinnamon Roll
191518
0
Oct 19, 2016 22:17:44 GMT -8
David Clark
Care for some tai chi with your chai tea?
17,602
March 2013
davidlinc1
|
Post by David Clark on Oct 25, 2015 8:59:22 GMT -8
I'm not sure if there have been any changes to how our software behaves in cases where you import settings from an old plugin that had inconsistent option fields (or whether what you've described is a bug), Eton, so I'm gonna let Tim reply to this one!
|
|
inherit
Official Code Helper
65613
0
1
Oct 22, 2024 1:56:19 GMT -8
Chris
"'Oops' is the sound we make when we improve"
9,022
December 2005
horace
RedBassett's Mini-Profile
|
Post by Chris on Oct 25, 2015 18:43:27 GMT -8
I seem to recall updating a plugin in the past with a plethora of newer options added and the default values for those newer options were left intact when settings were carried over from an older version. I want to say it was the bbcode buttons plugin where a more configurable/advanced version named control freak (but bearing the same plugin_id) was released. This version pretty much redid the entire UI but retained one tab which enabled importing the settings from the simpler version while retaining the default values on all the other tabs, apparently such a thing is no longer possible... P̌̓aͧś̀t̀u͒le͆o͂2̀3̃̓, I mentioned the truncating-while-saving problem only to show I considered it as a possible factor then ruled it out by minifying to get within limits then retested. It would however be a nice feature to have some indicator such as a counter or perhaps a meter that redlines when you are at the point of no return ( ) or }else{
|
|
inherit
The Dream Crusher (Ret.)
164921
0
Apr 1, 2014 11:00:25 GMT -8
Tim Camara
Teach a man to fish, etc., etc.
1,721
March 2011
tcamara
|
Post by Tim Camara on Oct 26, 2015 7:51:25 GMT -8
The code in question doesn't appear to have been changed since June 17th, 2013, so unlikely that it's a new issue. However, it does seem non-optimal to have that happen, so I'll file a bug for it.
|
|
inherit
217348
0
Jul 27, 2022 7:26:44 GMT -8
Lynx
5,849
January 2015
msg
|
Post by Lynx on Dec 2, 2015 21:44:16 GMT -8
Hi! Just popping in here to see if there was progress on this, as I see Chris has a V1.0.8 listed but the library still shows V1.0.5 as the current. Thanks! (I've got an RP Forum and liking the new options in the spoiler)
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Dec 3, 2015 6:14:00 GMT -8
I can confirm the bug as well.
I done a quick test, and new fields added to an auto form that has defaults setup do not get imported.
|
|
inherit
217348
0
Jul 27, 2022 7:26:44 GMT -8
Lynx
5,849
January 2015
msg
|
Post by Lynx on Dec 3, 2015 9:23:07 GMT -8
Hey, Peter. Was this your actual reaction when you found out the bug was still there? (I know your avatar rotates around - I just thought it comical that it had this one when I viewed your post. )
|
|
inherit
2671
0
May 14, 2013 14:40:03 GMT -8
Peter
🐺
10,615
February 2002
peter3
|
Post by Peter on Dec 3, 2015 10:15:11 GMT -8
Lynx , Lol Until today (am working on a not so secret plugin as a Christmas treat ), I've never took much notice at auto forms when testing updates, I just assumed it was all working fine when importing settings.
|
|
inherit
The Dream Crusher (Ret.)
164921
0
Apr 1, 2014 11:00:25 GMT -8
Tim Camara
Teach a man to fish, etc., etc.
1,721
March 2011
tcamara
|
Post by Tim Camara on Dec 3, 2015 11:02:28 GMT -8
I can confirm that this bug still exists, and is still on our 'To Fix' list. Unfortunately we're currently in the middle of a few other projects that are taking precedence. It will get fixed, but I can't promise any specific ETA.
|
|
inherit
217348
0
Jul 27, 2022 7:26:44 GMT -8
Lynx
5,849
January 2015
msg
|
Post by Lynx on Dec 3, 2015 13:29:00 GMT -8
Thanks for the confirmation and feedback, Tim Camara.
|
|