Adding coding moving the board names around

[ayeates]

Hi All,

Our forum - cheapofifaleague.freeforums.net/ seems to work fine with a couple of embedded tables with help from someone on the forum last night.

I've spent about 6 hours today creating a cup table using Javascript, excuse my novice coding! However, the problem is as soon as I add the cup javascript to the board it's headings seem to move all over the place.

I've added the code some images of the site pre and post adding of the cup code.

If anyone has anytime to look at this I would be really grateful.

Andrew

Attachments:

Cupthreadcoding.txt (60.67 KB)

[Tumbleweed]

Jun 20, 2017 10:14:12 GMT -8 ayeates said:

Hi All,

Our forum - cheapofifaleague.freeforums.net/ seems to work fine with a couple of embedded tables with help from someone on the forum last night.

I've spent about 6 hours today creating a cup table using Javascript, excuse my novice coding! However, the problem is as soon as I add the cup javascript to the board it's headings seem to move all over the place.

I've added the code some images of the site pre and post adding of the cup code.

If anyone has anytime to look at this I would be really grateful.

Andrew

ayeates ,
Do you have a link to where you have it working how you like? Like on Code pen or JSFiddle?

I see some coding mistakes and coding I have no clue why it is there but since I know nothing about sports, I can't even hazzard a guess what you needed to go where. It looks like, after you set up the titles you then went to set up everything that would go in the first  column (not really a column per say) and once that was done, moved on to the next column in your html with a left positioning for the second column, etc.

I do think you could have cut your html by probably more than 2/3rds doing it a different way but I won't know for sure unless I really understand what should be in column one, two, three, four, etc.

If there were a sports fan that knows coding, that would be ideal as they could probably take one look and know the problem but since I am not a sports fan, I need baby steps telling me what should go where. lol

[ayeates]

Hi there,
Thank you for responding

I have never used either of the two things you mention, but will look in the morning when I have laptop access.
.
You are correct in your assessment, it's a knockout tournament starting with 16 games then 8, 4,2 and a winner.

I have no doubt that there errors with my first time coding of the columns, but I guess it's not the tournament I am worried about, although could be the cause I guess?! but In fact how when entering the code the board titles move, for example in the pre cup code photos you can see leagues is directly above the two tables... however once the code is placed in this jumps up into a random place.

Andrew

[Tumbleweed]

Jun 20, 2017 13:38:38 GMT -8 ayeates said:

Hi there,
Thank you for responding

I have never used either of the two things you mention, but will look in the morning when I have laptop access.
.
You are correct in your assessment, it's a knockout tournament starting with 16 games then 8, 4,2 and a winner.

I have no doubt that there errors with my first time coding of the columns, but I guess it's not the tournament I am worried about, although could be the cause I guess?! but In fact how when entering the code the board titles move, for example in the pre cup code photos you can see leagues is directly above the two tables... however once the code is placed in this jumps up into a random place.

Andrew

The code pen thing may not be necessary.  I was assuming you knew something in the tournament list code you added messed things up but looking closer, I'm not sure what you think is messed up. Plus, since you posted the tournament coding, I thought you wanted me to look through it for errors but I take it the tournament looks how you want it to look.  Anyway, all the boards look aligned the same both directly looking at your site and the screen caps you posted. So I'm obviously not getting what you think is wrong. 

[ayeates]

Hello Tumbleweed,

Apologies if I didn't explain my self well previously and I did not mean to offend you, below I have re written the problem. 

Some friends and I have created a forum for an online football league (link) that we run, with help from another board member we have managed to get the tables we want appearing correctly. However, as soon as I add some probably poorly written Javascript (Attached) to create a Knockout tournament structure (Games reducing from 16 > 8 > 4 > 2 > 1 > Winner) the category & board order changes oddly.

The set board order prior to adding the code is:

(Bold is the category, Italic are the boards and ** Is javascripted tables from league republic)


CFL News
News, Holidays, Suggestions, Waiting Lists & Kits
Squads
Club Squads & Free Agents
Leagues
**Table for Premier league**
Premier League
**Table for Championship**
Championship
League 1
Cups
Champions League
Europa League
CFL Cup
Super Cup
Euro Super Cup
Rules
Rules & Prize Money
Transfers
Transfers, Loans, Releasing & Auctions
Scorers
Top Scorers
Awards
Awards
History
Previous Winners

The categories and boards then appear in this order, which seem to have moved each of the Categories up one and included a category call legend:

(I have attached photos of this too.)

CFL News
Squads
News, Holidays, Suggestions, Waiting Lists & Kits
Leagues
Club Squads & Free Agents
Cups
**Table for Premer League**
Premier League
**Table for Championship**
Championship
League 1
Rules
Champions League
Europa League
**Javascripted Knockout CFL Cup** - Where I'd like it to appear
CFL Cup
Super Cup
Euro Super Cup
Transfers
Rules & Prize Money
Scorers
Transfers, Loans, Releasing & Auctions
Awards
Top Scorers
History
Awards
Legend - Not in Category/board list in the admin area
Previous Winners

Any assistance on why this changes would be great.

Kind regards,

Andrew

Attachments:

Cupthreadcoding.txt (60.67 KB)

[Kami]

Why did you create a new thread in the support board when you were already receiving help here?

support.proboards.com/thread/625999/board-changing-adding-custom-javascript

Having multiple threads to try and get helped faster is disallowed, and the question you posted in the support board will likely get moved here anyway because the support board is for technical help with proboards software and this is custom javascript. This coding board was actually created specifically in order to help people with coding questions that don't pertain to themes, templates, or plugins, so you were correct to post here to begin with.

[ayeates]

I apologise, first time using these forum posts and thought it was as support question but didn't know how to move it, but as you've said I was wrong to post twice.

How do I go about deleting the duplicate?

[Kami]

You can't, now that people have replied to it (if no one had replied, deleting your first post would have deleted the thread).

I've linked to this thread in the post you made in the support board to let folks know it's a duplicate and being handled here, though, so the second thread will likely be locked by a staff member in light of that.

[ayeates]

Kami Sorry to have caused an issue.

[Tumbleweed]

Jun 21, 2017 4:45:34 GMT -8 ayeates said:

Kami Sorry to have caused an issue.

We know you are new so mistakes can be made.

I keep editing my post so sorry to anyone reading this.

Couple things. The code you posted is simply html and not JavaScript. Ayeates, I'm assuming you are adding this code to your board list template since you are using if statements. We may actually need your whole board list template as it might be your if statements that are messing things up. I am looking at the coding you provided and so far your images are causing a closing div to be red (meaning error) and changing the <IMG SRC to lower case...<img src ...seems to fix that. I'm combing your code for any other issues.


The legend is there by default to show what the folders stand for in each board (new posts/no new posts). So it isn't a category per say and won't show in your list of categories/boards. However, it does look like it is moving the legend title bar and now I understand your problem which I didn't before.

[ayeates]

Thank you for your response Tumbleweed another of the board members craig came back to me on the duplicate board I created (Sorry again) and checked the Board list template and it was discovered that there was far too many line of code, so the template could not recongnise.

So I have been playing with the site today and made the code far more simple, which seems to work well, what do you think of it?

cheapofifaleague.freeforums.net/

Just need to sort the tables now that look dreadful :-(

Andrew

[Tumbleweed]

Jun 21, 2017 10:42:32 GMT -8 ayeates said:

Thank you for your response Tumbleweed another of the board members craig came back to me on the duplicate board I created (Sorry again) and checked the Board list template and it was discovered that there was far too many line of code, so the template could not recongnise.

So I have been playing with the site today and made the code far more simple, which seems to work well, what do you think of it?

cheapofifaleague.freeforums.net/

Just need to sort the tables now that look dreadful :-(

Andrew

I love it when I don't have to comb through hundreds of lines of code.  Glad your friend came back and lent you a helping hand. Anyway, it looks good to me. The only thing I might do is add some css to differentiate the titles from the data. 

Best of luck with your forum.

[ayeates]

Jun 21, 2017 18:50:58 GMT -8 Tumbleweed said:

Jun 21, 2017 10:42:32 GMT -8 ayeates said:

Thank you for your response Tumbleweed another of the board members craig came back to me on the duplicate board I created (Sorry again) and checked the Board list template and it was discovered that there was far too many line of code, so the template could not recongnise.

So I have been playing with the site today and made the code far more simple, which seems to work well, what do you think of it?

cheapofifaleague.freeforums.net/

Just need to sort the tables now that look dreadful :-(

Andrew

I love it when I don't have to comb through hundreds of lines of code.  Glad your friend came back and lent you a helping hand. Anyway, it looks good to me. The only thing I might do is add some css to differentiate the titles from the data. 

Best of luck with your forum.

Thanks again Tumbleweed I am sure I'll be back with more issues I've caused for myself

Andrew