Updated Theme, now pagination not going to top?

[hotwire]

Hi there,

I'm bedding in a new theme at forum.retro-rides.org and there are a whole host of changes going on, but one of the things I've not changed compared to the previous custom theme is the pagination.  However when you click between pages the scroll position stays in the same location, rather than going to the top. I have the $[scroll_class] attribute in the same place as previously.

Any ideas? I'm sure it is just something I'm missing, but not sure quite what.

Going to add a tag for Kami in the hope of help

[Kami]

Aug 27, 2023 7:51:23 GMT -8 hotwire said:

Hi there,

I'm bedding in a new theme at forum.retro-rides.org and there are a whole host of changes going on, but one of the things I've not changed compared to the previous custom theme is the pagination.  However when you click between pages the scroll position stays in the same location, rather than going to the top. I have the $[scroll_class] attribute in the same place as previously.

Any ideas? I'm sure it is just something I'm missing, but not sure quite what.

Going to add a tag for Kami in the hope of help

Sorry friend, I do not have a desktop PC right now so I am unable to do any in-depth review. I can try and help troubleshoot more generally though.

- Have you installed any plugins relating to the pagination?

- Have you installed any plugins that immediately preceded you noticing the pagination did not auto-scroll you to the top of the next page?

- You mentioned you were messing around in templates, are all of your HTML and template tags properly closed and in the correct nesting order?

[hotwire]

Thanks for the reply Kami

I've not done anything new with plugins (I don't run any plugins at all).  I maaaaay have radically altered how the site operates, but I don't think that should have affected the pagination (trust me, I'm a professional... of sorts). I'll double check the closing tag thing though, that is a good shout, I found an unclosed span causing an issue a couple of weeks back.

I'd assumed the Scroll_Class variable was all that I'd need, for the pagination to jump to the right spot, I'm wondering if I'm missing something else too.

I'll keep investigating.

[Kami]

Aug 30, 2023 12:53:58 GMT -8 hotwire said:

Thanks for the reply Kami

I've not done anything new with plugins (I don't run any plugins at all).  I maaaaay have radically altered how the site operates, but I don't think that should have affected the pagination (trust me, I'm a professional... of sorts). I'll double check the closing tag thing though, that is a good shout, I found an unclosed span causing an issue a couple of weeks back.

I'd assumed the Scroll_Class variable was all that I'd need, for the pagination to jump to the right spot, I'm wondering if I'm missing something else too.

I'll keep investigating.

The easiest way to test would be find a page where it's exhibiting the incorrect behaviour, then go to the corresponding type template (so if you see it when browsing the thread list, look at the thread list template); copy and save the current structure to a notepad doc, then reset the template, refresh your sample page and see if the behaviour continues.

if it does, the problem lies elsewhere (I would actually keep the template reset until identifying where the issue is so you'll need more than one notepad document for the changes you made), so repeat for other pages. once you figure out which page is the culprit you can start adding stuff back in and see what happens.

[hotwire]

Aug 30, 2023 13:52:48 GMT -8 Kami said:

Aug 30, 2023 12:53:58 GMT -8 hotwire said:

Thanks for the reply Kami

I've not done anything new with plugins (I don't run any plugins at all).  I maaaaay have radically altered how the site operates, but I don't think that should have affected the pagination (trust me, I'm a professional... of sorts). I'll double check the closing tag thing though, that is a good shout, I found an unclosed span causing an issue a couple of weeks back.

I'd assumed the Scroll_Class variable was all that I'd need, for the pagination to jump to the right spot, I'm wondering if I'm missing something else too.

I'll keep investigating.

The easiest way to test would be find a page where it's exhibiting the incorrect behaviour, then go to the corresponding type template (so if you see it when browsing the thread list, look at the thread list template); copy and save the current structure to a notepad doc, then reset the template, refresh your sample page and see if the behaviour continues.

if it does, the problem lies elsewhere (I would actually keep the template reset until identifying where the issue is so you'll need more than one notepad document for the changes you made), so repeat for other pages. once you figure out which page is the culprit you can start adding stuff back in and see what happens.

Thanks for your help.

Somewhere along the line in the bug fixes I did yesterday it has started working. I wonder if maybe I deleted an element that wasn't closing correctly, or the update I've done to my javascript has sorted it out.

Your steps here are a useful guide for how to find errors though, so hopefully serve someone in the future.

[Kami]

Ah, technology; a fickle mistress. I am glad it sorted itself out somehow, best not question it lest the internet gods decide to revoke their blessing. :P