Code Database Updates

[Chris]

Jul 18, 2011 9:55:33 GMT -8 Chris said:

Find
if(location.href.match(/\.com\/?(index.cgi)?\??(&?action=home)?(#\w+)?$/)) {

Change it to
if(location.href.match(/action=home/) || !location.href.match(/action=/)) {


The issue is your custom domain. The location check for that code needs to be updated. It relies on a .com address, but you use a .co.uk address. Where did you originally get that code? Looks like it might be a SoCal code...

Rename News Fader

I'm also willing to bet quite a few other codes in the DB suffer from this defect. I already gave him 3 other corrections for his h/f.

Edit: Both this code and this one also need to have their location checks updated.

Edit 2: And it just dawned on me that my location check is out of date anymore. You should probably use the pb_action == "home" check instead.

[Todge]

The first two codes have been modified.. Unfortunately, boccy109 is specifically stating 'DO NOT EDIT BELOW THIS LINE', so we are not allowed to modify that code.

[hpmad]

Jul 18, 2011 13:41:39 GMT -8 Todge said:

The first two codes have been modified.. Unfortunately, boccy109 is specifically stating 'DO NOT EDIT BELOW THIS LINE', so we are not allowed to modify that code.

That sounds a bit ridiculous. I'm sure he just put it there so that people using the code would know when to stop changing the settings. I understand that there are copyrights to follow, but I think this is a bit extreme. I would just go ahead and fix the code...

[Wormopolis]

and if it were your code, we would keep that in mind. but without consent, we dont typically make those changes unless its deemed a security risk or hazardous to a board. regardless of what anyone assumes his intent was, we try to respect the code headers instructions.

if you want to use the code on a custom domain, then no one can really stop you from adding the fix yourself. Posted codes, however, will wait for author's permission.

[SubDevo]

Navigation Mod - By iAlex

Would THIS be considered a bug?

[Bennett 🚀]

Uhm, not to be seeming like a grouch or anything, or lazy, but has any problems arisen with any of my codes that I haven't heard from anyone about? Just curious, I haven't really been following this thread.

[Wormopolis]

typically the mods will send a PM to an author if the code has a "do not edit" clause in it. otherwsie we just go ahead an edit in the fixes and add notes at the bottom of the post explaining what was edited and why

[Wormopolis]

Aug 7, 2011 19:54:21 GMT -8 SubDevo said:

Navigation Mod - By iAlex

Would THIS be considered a bug?

it would..mainly because it was written before PB fixed how the form was nested. I just added in the fix your found

[SubDevo]

form did need to be added. But the up and down movement issue the OP brought up will only be fixed if you remove the br from the regex. I also removed tr|td|div|tbody for my fix but that isn't important. You can keep those in for safety, but I don't see a use for them. I haven't had a single issue/complaint with my nav tree customize combo which I only use table|form for the regex.

[Bennett 🚀]

Aug 8, 2011 1:12:30 GMT -8 Wormopolis said:

typically the mods will send a PM to an author if the code has a "do not edit" clause in it. otherwsie we just go ahead an edit in the fixes and add notes at the bottom of the post explaining what was edited and why

Okie doke, I'll have to look through to see if any of my codes have any edits..

[SubDevo]

Alignment In Mini Profile.
If using the "non staff" option, the alignment data [A:3] is not removed from the location field on the profile page.
Code edit is HERE.

[Trublu]

Aug 16, 2011 11:01:21 GMT -8 SubDevo said:

Alignment In Mini Profile.
If using the "non staff" option, the alignment data [A:3] is not removed from the location field on the profile page.
Code edit is HERE.

Update made, thanks Sub.

[SubDevo]

'New Thread' button next to 'Reply'

Hover text of the button is "[Share Topic]". The "fix" is here.

There should also be a note in the code post indicating that the code does not create a new button and add it. It REPLACES the "Share" button. How odd...

[SubDevo]

Multi-Colored Display Names

Not a bug fix but...
The instructions clearly states:
[username, color 1, color 2, etc...]
This remark is in the code:
// [username, display name, color 1, color 2, etc...]

The red should be removed to avoid confusion. It got me. But, I'm easily confused... lol

[Todge]

Done and done.

Thank you.