Code Database Updates

[Chris]

I do have a vague memory of some low market browsers not supporting it but that was years ago, I guess that is why I've subconsciously avoided using it.

Elegant solution and no major editing.

I'll look into the compatibility aspect..

[Chris]

Danke. I'd say push it through as long as it's ie6+ and fx 1+. I mean, I guarantee Chrome and Opera have it anyways.

[Chris]

Well according to w3School all 5 of the big boys support it so I vote Sí
^{Edit:(maybe) I still am wary of the aforementioned IE bugs coming into play here, it could in fact be these very bugs that have plagued this code. A definite IE run testcase has to be constructed}

[Chris]

Code: Clickable Banner [CB] [edit:oops]

Issue: Social Networks not accessible...

Solution: A simple change to that unfortunate variable name choice perhaps from Image to image

[Wormopolis]

both links go to the discussion thread.

I will convert it to encapsulated.

[SubDevo]

Custom "Time Based" Welcome Greetings

Actually, there are a couple issues with this code I do not like.
If I'm being picky, just let me know!

var myOldString = "Welcome" +pb_username;
This variable isn't even used and is not needed.

var myNewString="";
This is the wrong variable name. The variable used in the code is "newString".

if (time < 12)
{
newString="Good Morning, ";
}
else if (time>12 && time<20){
newString="Good Afternoon, ";


Since, the code checks the "hours" the second message will not be displayed until 1pm.
That should be changed to time>=12 && time<20

Regards,
SubDevo

[Todge]

Good catch, and code updated.

Just a though, but instead of else if (time>=12 && time<20) all that is needed is else if (time<20)

[SubDevo]

Tis true Todge. I'm just concerned that if users add/change the times, I think they will get confused...
Maybe should add the "=" to the "How To Add More Options:" section too.
But, heck. If they are editing the code, they should know what they are doing! lol

EDIT:
I just noticed that the custom message will only be added IF you are a member.
replace("Hey, ",newString);
Guests are left out... pfft oh well.

[Todge]

Yup, I noticed that too..

I will make the change to the instructions too, I forgot about that bit.

Thanks.

[Zatch]

Two codes in the database seem to have been deleted, but not removed. Under "Additional Posting Hacks":
Characters left
Characters Left

Also, the Add Colour Box code also realigned my forum's signatures. That might need a fix.

[SubDevo]

Regarding Daily Calendar Events...

Is THIS a bug or meant to be this way?

Regards,
SubDevo

[Todge]

Feb 13, 2011 14:34:26 GMT -8 Zatch said:

Two codes in the database seem to have been deleted, but not removed. Under "Additional Posting Hacks":
Characters left
Characters Left

Also, the Add Colour Box code also realigned my forum's signatures. That might need a fix.

The two offending links have been removed..

Thank you.

[Wormopolis]

Feb 15, 2011 22:09:22 GMT -8 SubDevo said:

Regarding Daily Calendar Events...

Is THIS a bug or meant to be this way?

Regards,
SubDevo

probably an oversight on the creators part. Did your fix clear up all of them?

[SubDevo]

It should. I tried on a test site (but with only one calendar entry).
OP said it didn't remove one for the next day. Not sure why it wouldn't.
I just changed to match innerHTML of the links if on the calendar page. So, it should take care of all of them. Hopefully, the OP will post to say yay or nay...

[Zatch]

Code Index > Additional Posting Hacks > Ultimate Quick Reply Mod (http://support.proboards.com/index.cgi?action=display&board=codedatabase&thread=358479)
Another broken link.