Code Database Updates

[Trublu]

Jan 11, 2011 11:13:19 GMT -8 Simie said:

Go for it

I believe we had already done so with the file uploader actually, so it was just the "report posts" feature. Thanks again for getting that quickly resolved!

[Simie]

There are more requests for CFHeader than CFFooter. How many people forgot to install both parts?


(Stats are from today and yesterday)

[Chris]

Jan 11, 2011 15:47:57 GMT -8 Simie said:

There are more requests for CFHeader than CFFooter. How many people forgot to install both parts?


(Stats are from today and yesterday)

Could be stopped requests?

[Chris]

PM button next to Quote [CB] references the "user" cookie which is no longer visible to scripts, it should be modified to use pb_username instead.

[Wormopolis]

updated. thank you Eton!

[Andrea]

Hey guys.

I ran across this when a member requested for a code like this. Unfortunately, the one we have now does not appear to be working. It's pretty old (from 2006). Just thought I'd throw it out there.

Sticky/Announcement Link Color Change

[SubDevo]

Jan 28, 2011 14:59:54 GMT -8 Andrea said:

Sticky/Announcement Link Color Change

Easy fix.
support.proboards.com/index.cgi?action=gotopost&board=coderequests&thread=380762&post=4334271

[Trublu]

Jan 28, 2011 16:02:08 GMT -8 SubDevo said:

Jan 28, 2011 14:59:54 GMT -8 Andrea said:

Sticky/Announcement Link Color Change

Easy fix.
support.proboards.com/index.cgi?action=gotopost&board=coderequests&thread=380762&post=4334271

Updated, nice catch.

[SubDevo]

support.proboards.com/index.cgi?board=codedatabase&action=display&n=1&thread=70404

Code pukes if a sub-board name has a hyphen and a space following it. Like "Studies - Math"

I quickly tested in a test site with a sub-board named "umm - what" and adding an extra hyphen in this line (the regexp for the split) seemed to fix the issue.

Link.appendChild( document.createTextNode( Options[opl2].innerHTML.split(/--\s/)[1].replace(/&/gi, '&') ) );

Need some more input/testing from Wormo/Eton/Todge if this change will indeed fix the issue and not cause any other problems.

Regards,
SubDevo

[Chris]

Feb 1, 2011 15:22:18 GMT -8 SubDevo said:

support.proboards.com/index.cgi?board=codedatabase&action=display&n=1&thread=70404

Code pukes if a sub-board name has a hyphen and a space following it. Like "Studies - Math"

I quickly tested in a test site with a sub-board named "umm - what" and adding an extra hyphen in this line (the regexp for the split) seemed to fix the issue.

Link.appendChild( document.createTextNode( Options[opl2].innerHTML.split(/--\s/)[1].replace(/&/gi, '&') ) );

Need some more input/testing from Wormo/Eton/Todge if this change will indeed fix the issue and not cause any other problems.

Regards,
SubDevo

Wouldn't the problem then reoccur if it encountered a sub with a double dash followed by space in the name? /^-+\s/ might be a better solution. Six lines up from that line that is the exact regex being used to check the name but mysteriously it disappears when splitting.

This might have to do with IE's behavior of automatically trimming trailing and leading spaces of option contents (which I just noticed FF3.x now also does, previous versions did not). Another peculiarity with using split in this fashion is a small and not widely known difference between IE and other browsers. If the split pattern occurs at the beginning of the string other browsers will return an array with the first element set to an empty string while IE will omit that first element.

"- test".split(/-\s/)
IE returns: ["subBoard"]
FF returns ["","subBoard"]

I would avoid split and just use a regex capture to get the name.
Also be careful when editing that code since special care must be taken to ensure Proboards doesn't convert that HTML entity back into its ASCII equiv: .replace(/&/gi, '&')
or just use option.text instead of option.innerHTML to avoid having to deal with entities.

[SubDevo]

Yea, I just did a quick test after reading this thread.

If someone doesn't want to fix this, then should there, at least, be a "warning" in the code instructions about this potential issue? Is CrAzY_J still around?

[Chris]

I've actually done several modifications in various support threads over the years to address unique issues in that code. If you notice the last edit to the code was to address a bug where it was displaying & instead of & back when using double ampersands became vogue . I'm pretty sure there are at least 4 or 5 other issues that have been addressed but never applied to the database itself.

I've never seen Crazy_J online

[Chris]

I addressed it earlier in this thread, but CJ said we're free to update his codes as needed. If you want me to handle it, I will.

[Chris]

Feb 2, 2011 8:36:41 GMT -8 Chris said:

I addressed it earlier in this thread, but CJ said we're free to update his codes as needed. If you want me to handle it, I will.

By all means do
And while you're at it could you pop your head into this thread

[Chris]

Eton: Shouldn't this code it?

Link.appendChild( document.createTextNode( Options[opl2].innerHTML.split(/-\s/, 2)[1].replace(/&/gi, '&') ) );

I don't know the support for split's second parameter across all browsers. Do you?

also, I bookmarked that thread. If you make any head way, woot. Otherwise, I'll look tomorrow. >.<