Personal Smilies (v 1.3.0)

[Chris]

OK that error identifies a second issue at line 120 of the plugin code since it is using an undeclared parameter of "code" (which was apparently changed to "smc" in other parts of the code). The error however only occurs when the typing carat is at zero so theoretically if you type something into the quick reply box BEFORE clicking on a smiley to insert you should then get an inserted image bbcode (although still mangled by the missing double quote)

SPOILER: Click to show

[Former Member]

Feb 7, 2022 22:26:17 GMT -8 Chris said:

OK that error identifies a second issue at line 120 of the plugin code since it is using an undeclared parameter of "code" (which was apparently changed to "smc" in other parts of the code). The error however only occurs when the typing carat is at zero so theoretically if you type something into the quick reply box BEFORE clicking on a smiley to insert you should then get an inserted image bbcode (although still mangled by the missing double quote)

Funny, I never did try typing before hitting a PS, but when just tried, still wont put it into the post. I'm guessing Todge will have to read these posts and see if she can fix these issues.

Thank you, my friend for the help and info. It should help her fix it, so the PS works correctly in the QR.

[Chris]

Line 120 occurs after insertion so that would not prevent it from appearing in the quick reply box.

Another possibility that comes to mind is you may have an element with the name of "message" that is located on the page prior to the quick reply. So for example you are using a theme or layout edit not seen by guests which uses something with a "message" name (such as a shoutbox) appearing before the quick reply box instead of after, you would then be sending smileys to the shoutbox since the code opts to send to the first message box on the page.

[Former Member]

Feb 7, 2022 23:49:30 GMT -8 Chris said:

Another possibility that comes to mind is you may have an element with the name of "message" that is located on the page prior to the quick reply. So for example you are using a theme or layout edit not seen by guests which uses something with a "message" name (such as a shoutbox) appearing before the quick reply box instead of after, you would then be sending smileys to the shoutbox since the code opts to send to the first message box on the page.

Yes, I now see it trying to send to the shoutbox.

However, I'm not certain how to fix that.

Good find, my friend!

[Chris]

All three of these issues would need the plugin author (Todge ) to fix the plugin's code

1. 113: smc = '[img class="smilie" src="'+smc+'"]';
   
   
2. 114: var messarea = $(".form_post_quick_reply [name='message']")[0];
   
   
3. 120: var newcPos = code smc.length;
   
   

[Todge]

Feb 7, 2022 23:52:20 GMT -8 @burkeknight said:

Yes, I now see it trying to send to the shoutbox.

However, I'm not certain how to fix that.

Good find, my friend!

Feb 7, 2022 23:56:49 GMT -8 Chris said:

All three of these issues would need the plugin author (Todge ) to fix the plugin's code

1. 113: smc = '[img class="smilie" src="'+smc+'"]';
   
   
2. 114: var messarea = $(".form_post_quick_reply  [name='message']")[0];
   
   
3. 120: var newcPos = code smc.length;
   
   

@burkeknight, can you please try version 1.2.62.

All three issues highlighted by Chris (thank you) have now been fixed, though the PB software seemed to fix the missing quote, and the part of the code with the erroneous variable seems to be ignored, even if I do try to add a smiley to the beginning of the textarea..

[Former Member]

Todge, that did the trick.

Thank you so much! 

[Chris]

Feb 9, 2022 9:32:26 GMT -8 Todge said:

the part of the code with the erroneous variable seems to be ignored, even if I do try to add a smiley to the beginning of the textarea..

The error appears in the console but does not prevent insertion since it appears after insertion has occurred, and since it is happening in an event handler it would not take down the entire plugin (browser deems code faulty and skips over it)

Feb 7, 2022 23:49:30 GMT -8 Chris said:

Line 120 occurs after insertion so that would not prevent it from appearing in the quick reply box.

[Todge]

Feb 9, 2022 9:46:32 GMT -8 Chris said:

Feb 9, 2022 9:32:26 GMT -8 Todge said:

the part of the code with the erroneous variable seems to be ignored, even if I do try to add a smiley to the beginning of the textarea..

The error appears in the console but does not prevent insertion since it appears after insertion has occurred, and since it is happening in an event handler it would not take down the entire plugin (browser deems code faulty and skips over it)

Feb 7, 2022 23:49:30 GMT -8 Chris said:

Line 120 occurs after insertion so that would not prevent it from appearing in the quick reply box.

Yeah, I understand that.. I must have included that snippet of code for a reason, but obviously changes to the code made at a later date must have rendered it unnecessary. I see I made changes to the QR function in version 1.2.1, maybe I did it then..

Methinks this plugin needs tidying up.

[Chris]

Looks like that value is needed when it wants to update the caret position at setPSCaretPosition(messarea, newcPos) but the error prevented that update.
I totally forgot that was a community-created code but I don't recall a setPSCaretPos function in the original code so that may have been a feature added by you or Wormo.
If you do refactor the code keep in mind that $.fn.replaceSelection does the same in a far simpler way and manages caret position behind the scenes.

[Todge]

Oh wow.. That brings back memories, and headaches..

The caret position functions was something I put together from code snippets I got elsewhere and reworked to work with the PB. I believe it was originally for the Spoiler Plugin, when the original version just added the spoiler to the end of the post.

$.fn.replaceSelection does make it look a lot simpler, and neater.. Thanks.

[sculptorgalaxy]

Been a while since anyone has commented in this thread, but how are you supposed to access the emojis? Usually they would be in the emoji menu when you're editing a reply, but i don't find them there even though id already linked a few in my user settings..plus, my friend DOES have the menu even though we're messaging in the same forum

[m2marsh]

Apr 25, 2023 2:40:26 GMT -8 sculptorgalaxy said:

Been a while since anyone has commented in this thread, but how are you supposed to access the emojis? Usually they would be in the emoji menu when you're editing a reply, but i don't find them there even though id already linked a few in my user settings..plus, my friend DOES have the menu even though we're messaging in the same forum

If you post a screenshot of your smiley settings in your profile, we might be able to troubleshoot for you. You are supposed to see your personal smilies in the same smiley menu along with the defaults when you post.

[sculptorgalaxy]

It's just this

[sculptorgalaxy]

Update - the emojis seem to work for me now. I don't know what happened but it seems everything is in order now