Member Thread Count (0.2.4)

[Todge]

Sept 13, 2016 23:30:23 GMT -8 Ghost77 said:

Sept 12, 2016 17:07:41 GMT -8 Todge said:

Can you please post a link to your forum, hopefully if there's two forums with the same problem I can find a common problem.

The one in my siggy

Here's a link to a thread about/by one of the members it's happening to:
2peasrefugees.boards.net/thread/46405/why-message-thread-count-reset

and another affected member: 2peasrefugees.boards.net/user/3988

There are at least a couple more. I've reset the count for the first person more than once - it seems to reset to a correct figure when I do it. Not sure what the trigger is for it to go back to 1000 but it always does. 

So, in your case, the threads are updating correctly when you visit a member's profile page, but are then resetting to 1000 later on?

[Ghost77]

Yep, exactly.

[Todge]

Do you have any idea whet you did right before the thread count jumps?

I have scanned the code several times and I can't see anything that would make the count 1000, so right now I'm stumped.

[Chris]

Sept 15, 2016 11:25:36 GMT -8 Todge said:

Do you have any idea whet you did right before the thread count jumps?

I have scanned the code several times and I can't see anything that would make the count 1000, so right now I'm stumped.

Todge , I took a look myself yesterday and the only thing that jumped out at me was the use of pb.data('route') in a few functions that run waaay after DOMContentLoaded. This is important because any AJAX operation will overwrite the route with a new one reflecting what just happened, so someone whose timezone has changed for example and the elapsed time script shoots off an AJAX to update that info or another plugin that ran before yours shooting off some update would mean the data you are expecting in the route is no longer there. This is why it is recommended that the route be saved in a variable on initial code execution then referenced via that variable when testing for something later on.

I personally however could not connect the dots that would then lead to an explanation of someone having started 56^* threads somehow getting 1000 . This however doesn't mean it couldn't be the cause and I am somehow not seeing the entire chess board to backtrace the moves that got that piece into that position.

[Todge]

Ghost77, can you please try this version (0.1.45)...

Thanks Chris, I have updated the plugin linked above to grab pb.data('route') on page-load now, fingers crossed that will fix it, but...

If I set a variable, for example, MTCpbData = pb.data('route'), doesn't that just set a reference for pb.data('route')? so that whenever I look at the content of MTCpbData it is still looking at the pb.data('route')?

Also, the only time that pb.data('route') is used to grab the thread count is on the Recent Threads page, which, from what I understand, is updating correctly, there after it is the key content being counted up on 'thread-new'.

I don't know... This 'simple' plugin is making my head hurt.

[Chris]

Sept 15, 2016 16:26:43 GMT -8 Todge said:

If I set a variable, for example, MTCpbData = pb.data('route'), doesn't that just set a reference for pb.data('route')? so that whenever I look at the content of MTCpbData it is still looking at the pb.data('route')?

Correct, only primitives are passed byVal in javascript, everything else is passed byRef so when you call pb.data("route") it passes a reference to the object back to you. Once that object gets replaced by a new object however the reference is lost unless you have saved your own reference to it, pb.data("route") would be passing you reference to a brand new object since it has been replaced. If nothing holds reference to the old object then garbage collection clears it from memory so keep your references close to the vest.

---

[Edit]: The answer was apparently in this thread all the time

Aug 25, 2016 15:52:13 GMT -8 ₪» ⅀ ƪ Ƒ «₪ said:

EDIT: I then went to my account's personal recent threads and nothing happened. Then I went to the site's overall recent threads and the popup happened that's supposed to recount the threads, so I hit OK, and now it's back to 1,000

recent_threads_created vs recent_threads and the line
else if(proboards.data('route').name.match(/recent_threads/) && (pb.plugin.get('member_thread_count').settings.member_change == 'y' || proboard.data('user').is_staff == 1))

I was able to duplicate this and it grabbed the thread starter of the first thread in the forum's overall recent threads list and asked to reset the count for that poor guy If I was not paying attention I would have simply hit "do it" or whatever the button said which would have then reset my counter to 1000 since var mid = proboards.data('route').params.user_id; evals to undefined on that page and an undefined object_id for a user key resolves to the user id of the current user.

[Todge]

That was it?? I forgot to take the Forum's recent threads page into account???



Ghost77 , ₪» ⅀ ƪ Ƒ «₪ and to whoever else this concerns, please use version 0.1.45.

And a massive thanks to Chris who has saved me from going bald yet again.

[Ghost77]

Have installed the new version, big thanks to you both

[Ghost77]

Todge a couple of us are having problems with this plugin, just suddenly seemed to stop updating, and everywhere except the profile page it shows the thread count as zero. I'm not sure exactly when it happened, but the first report I had about it was 12 Nov. I hadn't made any changes to the forum for quite a while before that.

Thread with more details is here: support.proboards.com/thread/604435/member-thread-suddenly-stopped-working

[Todge]

Nov 18, 2016 3:42:01 GMT -8 Ghost77 said:

Todge a couple of us are having problems with this plugin, just suddenly seemed to stop updating, and everywhere except the profile page it shows the thread count as zero. I'm not sure exactly when it happened, but the first report I had about it was 12 Nov. I hadn't made any changes to the forum for quite a while before that.

Thread with more details is here: support.proboards.com/thread/604435/member-thread-suddenly-stopped-working

Can you please try version 0.1.6.

[Ghost77]

Nov 18, 2016 14:10:04 GMT -8 Todge said:

Nov 18, 2016 3:42:01 GMT -8 Ghost77 said:

Todge a couple of us are having problems with this plugin, just suddenly seemed to stop updating, and everywhere except the profile page it shows the thread count as zero. I'm not sure exactly when it happened, but the first report I had about it was 12 Nov. I hadn't made any changes to the forum for quite a while before that.

Thread with more details is here: support.proboards.com/thread/604435/member-thread-suddenly-stopped-working

Can you please try version 0.1.6.

That looks to have done the trick, have only done a couple of quick checks but I'm seeing realistic numbers in my member list instead of a whole column of red zeros, so an instant improvement! I'll look more thoroughly tomorrow, but I think that has solved it. 

Thanks for for a super quick response!

[suzukirider]

Just wanna say a humongous thank you Todge for helping out with this... all seems to be working again

Thanks also to Ghost & MSG for directing me here, when I messed-up and posted in the wrong place....doh!

All the Best

SR

[Todge]

No worries..

[johnwalkerq]

The plugin isn't working 100% on my forum. In the Members navigation it says 0 with a red color.

Can you help me find out what the problem is?

I also tried deleting the plugin and download it again but it's still not working.

[Todge]

Nov 21, 2016 4:01:24 GMT -8 johnwalkerq said:

The plugin isn't working 100% on my forum. In the Members navigation it says 0 with a red color.

Can you help me find out what the problem is?

I also tried deleting the plugin and download it again but it's still not working.

A red '0' means that that member's threads have not been counted yet. Clicking on the red 0 should take you to the member's thread list so that they can be counted and the key updated.

If this is not the case, can you please post a link to your forum so I can take a look.

Thanks.