Experiencing Yourshop Bugs?

[Chris]

Eton: if you wanna help compile a list of issues, I think I/we can get this done pretty quickly. (week or two?) Or just post links to threads and I can examine the bugs myself. Whatever works best for you, if you don't mind. I just haven't been around PBS enough to track the issues with this code.

[Chris]

Actually I've never kept a record of any "bugs" in the code and Proboards search sucketh massively. Bradley has said the donation system is "buggy" on his shop forum but I have no idea what this refers to, perhaps members here who actually use the shop can shed some light.

Off the top of my head I could list a few, two most common problems that come to mind has to do with editing errors (nothing to do with the code itself);

• Shop fails in IE if last element in an array is followed by a comma
  (IE creates an additional undefined element at end of array which crashes shop when it loops through the array)
  
• Purchasing an item ends up purchasing the wrong item.
  This is due to users editing the code directly in footer and leaving gaps or non-sequential runs in the array elements numbering.
  

There are only a few rare cases where the shop needs to be edited directly since it provides admin panel links to shield code users from such errors but they persist. I have however seen users swear that they did use the shop links to do the edits and the numbering gaps still appear...[bug?]

The third most common error has to do with the menu buttons not being at TD[5]. The shop crashes if useButton=1 but TD[5] refers to a cell that has no firstChild.lastChild. The rise of codes that move the welcome table has seen a corresponding rise with this error. This is one of the few cases where you need to edit the shop directly to set useButton=0. An improvement to the code in this scenario would be to gracefully handle the error and continue.

The fourth most common would be conflicts with mini-profile remodeling codes. Since the shop uses deferred scripts coupled with setTimeouts there really is no reordering of codes that can solve this. It however has a compatibility mode for Cali's miniprofile tables code which can be enabled provided the remodeling code can be modified to put a <div class="leftCell"> containing "Posts:" in a left cell and a nextSibling cell containing a number wrapped in div.<tr><td><div class="leftCell">Posts:</div></td><td><div>4,321</div></td></tr>

• additional bugs
  • Another would be recentUserInfo containing default values (NaN) due to an apparent failure to grab user stats most likely attributed to cookies such as "shp-act" being present from a previously failed redirect attempt.
    
    
  • One bug that I've never seen mentioned but discovered while integrating Todge's achievements code with the shop was its inability to recognize currency exceeding 999,999 since it does a replace for /,/ instead of /,/g.
    
    
  • After the PBv4.5 conversion all miniprofiles now contain TWO anchors (the newer incremented identifier and the older time-based post identifier). I'm sure an effort was made to update for this but one case where it was not is in post.js:
    /*
    YourShop
    Version 0.3
    
    Copyright 2005-2008 Bradley Nelson a.k.a CCWorld
    All Rights Reserved
    
    For use on Proboards Boards only.
    This Header must remain intact at all times.
    Do not re-post without permission.
    
    Posts Code
    */
    
    var recentUserInfo; var cell; var sigC; var repStr; var linkNum = 1; var tempTitle; var tL1; var tL2; var tL3;
    
    
    linkNum should default to linkNum = 2 in order to point to the user's profile link. This may actually be the donation bug referred to since the donation link would be constructed with "&user=NaN", which means a donation can only be sent while viewing the full profile of the recipient (miniprofile has no anchors).
    
    
    
  • Confusion over shop not working when forum is placed in maintenance mode (link)
    
    
  • If user decides to set var buttonUrl = "" to hide shop button instead of useButton=0 to disable the button entirely then the authenticated form hash error comes into play. An empty buttonUrl should be treated as if useButton is set to 0 else an image with src="" will cause register, header/footer and modifyprofile form submission problems.
    
    
  • Shop has a 10 item limit
    
  • Hides IP cell on some browsers since it checks last cell for alt="IP: " border="0" (in that order) while browsers are free to rearrange the attribute order any way they see fit. If no match then it's assumed to be signature and hidden if not purchased.
    
  
  

[Thesealion]

One problem i had was that the code did not work at all with Wormo's Banner Remodel and he could not get it to work.

[Chris]

Jul 6, 2010 15:04:21 GMT -8 Thesealion said:

One problem i had was that the code did not work at all with Wormo's Banner Remodel and he could not get it to work.

That would probably fall under

The third most common error has to do with the menu buttons not being at TD[5]. The shop crashes if useButton=1 but TD[5] refers to a cell that has no firstChild.lastChild. The rise of codes that move the welcome table has seen a corresponding rise with this error. This is one of the few cases where you need to edit the shop directly to set useButton=0. An improvement to the code in this scenario would be to gracefully handle the error and continue.

[Thesealion]

oops well i didn't understand any of that i was just trying to help

[Chris]

Jul 6, 2010 15:13:57 GMT -8 Thesealion said:

oops well i didn't understand any of that i was just trying to help

Much appreciated NightWalker, this is exactly what we need to get a more complete list of bugs.

This one however would fall under "conflicts" and would depend on whether we feel ambitious enough to widen the definition of "bugs" to account for conflicts with thousands of other codes. More likely if there's a conflict it would addressed only if the conflicting code has a major following (such as Smangii's side tables) . As it is now, the code only makes one single exception for conflict with Cali's miniprofile tables code.

[Chris]

Actually I've never kept a record of any "bugs" in the code and Proboards search sucketh massively. Bradley has said the donation system is "buggy" on his shop forum but I have no idea what this refers to, perhaps members here who actually use the shop can shed some light.

I didn't expect you to have a list, but I know you deal with it FAR more than me. So I figured you were the best to ask. As for the donations... I'll test them in different browsers and see what happens.

Off the top of my head I could list a few, two most common problems that come to mind has to do with editing errors (nothing to do with the code itself);

• Shop fails in IE if last element in an array is followed by a comma
  (IE creates an additional undefined element at end of array which crashes shop when it loops through the array)
  
• Purchasing an item ends up purchasing the wrong item.
  This is due to users editing the code directly in footer and leaving gaps or non-sequential runs in the array elements numbering.
  

I could easily do a "patch" loop that fixes that, no? Shouldn't be too difficult.

There are only a few rare cases where the shop needs to be edited directly since it provides admin panel links to shield code users from such errors but they persist. I have however seen users swear that they did use the shop links to do the edits and the numbering gaps still appear...[bug?]

I'll look into it. Do you remember what browsers the users tend to use? I'm assuming IE or Fx...

The third most common error has to do with the menu buttons not being at TD[5]. The shop crashes if useButton=1 but TD[5] refers to a cell that has no firstChild.lastChild. The rise of codes that move the welcome table has seen a corresponding rise with this error. This is one of the few cases where you need to edit the shop directly to set useButton=0. An improvement to the code in this scenario would be to gracefully handle the error and continue.

try {} catch(e) {}. The end. You know, as a last resort.

The fourth most common would be conflicts with mini-profile remodeling codes. Since the shop uses deferred scripts coupled with setTimeouts there really is no re-ordering of codes that can solve this. It however has a compatibility mode for Cali's miniprofile tables code which can be enabled provided the remodel can be modified to put a <div class="leftCell"> containing "Posts:" in a left cell and a nextSibling cell containing a number wrapped in div.

Hmm... I'll see what I can do about that conflict. It couldn't be too hard to patch honestly.

Another would be recentUserInfo containing default values (NaN) with the failure to grab user stats most likely due to cookies such as shp-act being present from a previously failed redirect attempt.

Another fairly simple patch I'd think.

One bug that I've never seen mentioned but discovered while integrating Todge's achievements code with the shop was its inability to recognize currency exceeding 999,999 since it does a replace for /,/ instead of /,/g.

Easy enough.

I'll try to start on this sometime this week in patching this.



Night: Eton's right. Please post any "bugs" you think might exist. It's all a step towards a patch.

[Chris]

I'll keep adding to the bug list as others bubble up to the surface (just added another)

Jul 6, 2010 17:44:22 GMT -8 Chris said:

There are only a few rare cases where the shop needs to be edited directly since it provides admin panel links to shield code users from such errors but they persist. I have however seen users swear that they did use the shop links to do the edits and the numbering gaps still appear...[bug?]

I'll look into it. Do you remember what browsers the users tend to use? I'm assuming IE or Fx...

Alas Proboards search fails me again...
I found one thread where the user claims they used the admin panel links exclusively to edit items (here) and the gaps still occurred. This user happens to be Nightwalker so maybe he/she can answer that question.

[Vanya]

I don't remember what browser, but it was either firefox, IE, or safari, I could add items, but I couldn't edit them. Also, I understood almost nothing from above, but the donations thing, I donated some currency to a member, and it gave him the money but it didn't subtract it from my profile. Later, it started redirecting me to my profile to "perform an update", and it was just the modify profile screen. Then it redirected me to the page veiwing my profile, and it said somthing about subtracting the value or somthing like that. I don't know much about these problems, but I'm trying to help! I'll test some more features to see if they work.

[Chris]

Jul 7, 2010 6:59:22 GMT -8 Vanya said:

I don't remember what browser, but it was either firefox, IE, or safari, I could add items, but I couldn't edit them. Also, I understood almost nothing from above, but the donations thing, I donated some currency to a member, and it gave him the money but it didn't subtract it from my profile. Later, it started redirecting me to my profile to "perform an update", and it was just the modify profile screen. Then it redirected me to the page veiwing my profile, and it said somthing about subtracting the value or somthing like that. I don't know much about these problems, but I'm trying to help! I'll test some more features to see if they work.

That's the kind of info I need actually. If you could remember what browser, that'd be great.

[Trublu]

Thanks for tackling this Chris & Eton. Two things:

1. Would it at all help to either sticky this thread, or create a sticky thread so that people know you are looking for bugs?

2. We aren't accepting any more remotely hosted codes, and we're trying to pare down the ones we already have, so if you (Chris) are going to edit this, then you don't need to host it. We can always provide instructions to people on how to host it, since this is a large code and that would likely be beneficial, but remotely hosted codes have caused too many problems for us to accept any more.

[Vanya]

I'm thinking FireFox, but if I get the chance I'll test it in both browsers.

[Thesealion]

Jul 6, 2010 18:14:11 GMT -8 Chris said:

I'll keep adding to the bug list as others bubble up to the surface (just added another)

Jul 6, 2010 17:44:22 GMT -8 Chris said:

I'll look into it. Do you remember what browsers the users tend to use? I'm assuming IE or Fx...

Alas Proboards search fails me again...
I found one thread where the user claims they used the admin panel links exclusively to edit items (here) and the gaps still occurred. This user happens to be Nightwalker so maybe he/she can answer that question.

What happens here was one of my other mods deleted something out of the header and didn't fix the numbers. So this is not a bug that i know of

[Vanya]

Today a member reported buying a red potion, a cutlass, and a sword, the potion morphed into a bunny, and the cutlass and sword didn't show up.


Just trying to help!

[Chris]

Jul 7, 2010 8:16:27 GMT -8 Trublu said:

Thanks for tackling this Chris & Eton. Two things:

1. Would it at all help to either sticky this thread, or create a sticky thread so that people know you are looking for bugs?

2. We aren't accepting any more remotely hosted codes, and we're trying to pare down the ones we already have, so if you (Chris) are going to edit this, then you don't need to host it. We can always provide instructions to people on how to host it, since this is a large code and that would likely be beneficial, but remotely hosted codes have caused too many problems for us to accept any more.

1) Once I start doing the fixing and get the current bugs ironed out, I think I'll create another thread.

2) I... don't see how this code can't be hosted. Asking a user to host it themselves is a ridiculous change from the "plug and chug" strategy that is currently occurring. That's asking for more issues than there currently are. Where are they going to host it? wImg? what if that goes down again? How would it work with their random file naming? Ripway? What about the daily bandwidth limit? The possibilities go on.

I have been using a reliable host for 6 years now and the only issues were when all of Yahoo's hosting went down temporarily. I would think I would be a reliable host considering some of my hosted codes are used by over 3k forums (last I checked), including Adv. Aff. Viewer. I was also the host for Users Online Today before v4.5 came out and that was well over 6k forums. Either way, my point is having a host is the best strategy, especially with MORE v4.5 updates coming out (Martyn already leaked a few of them in another thread.) I'll gladly host it on numerous mirror sites if that'll make you feel better, but asking a user to host it would just cause more issues than it's worth and would also make it impractical to update such a large code that is bound to have bugs.

Sorry to go off on a tangent.

Jul 7, 2010 19:08:51 GMT -8 Vanya said:

Today a member reported buying a red potion, a cutlass, and a sword, the potion morphed into a bunny, and the cutlass and sword didn't show up.


Just trying to help!

Can you give me a link to the member's profile? It'll help with analysis.